mirror of
https://github.com/zebrajr/react.git
synced 2025-12-06 12:20:20 +01:00
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Part 2 of adding a "Config Override" panel to the React compiler playground. Added sync from the config editor (still only accessible with the "showConfig" param) to the main source code editor. Adding a valid config to the editor will add/replace the `@OVERRIDE` pragma above the source code. Additionally refactored the old implementation to remove `useEffect`s and unnecessary renders. Realized upon testing that the user experience is quite jarring, planning to add a `sync` button in the next PR to fix this. ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> https://github.com/user-attachments/assets/a71b1b5f-0539-4c00-8d5c-22426f0280f9
88 lines
2.6 KiB
TypeScript
88 lines
2.6 KiB
TypeScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
import parserBabel from 'prettier/plugins/babel';
|
|
import prettierPluginEstree from 'prettier/plugins/estree';
|
|
import * as prettier from 'prettier/standalone';
|
|
import {parseConfigPragmaAsString} from '../../../packages/babel-plugin-react-compiler/src/Utils/TestUtils';
|
|
|
|
/**
|
|
* Parse config from pragma and format it with prettier
|
|
*/
|
|
export async function parseAndFormatConfig(source: string): Promise<string> {
|
|
const pragma = source.substring(0, source.indexOf('\n'));
|
|
let configString = parseConfigPragmaAsString(pragma);
|
|
if (configString !== '') {
|
|
configString = `(${configString})`;
|
|
}
|
|
|
|
try {
|
|
const formatted = await prettier.format(configString, {
|
|
semi: true,
|
|
parser: 'babel-ts',
|
|
plugins: [parserBabel, prettierPluginEstree],
|
|
});
|
|
return formatted;
|
|
} catch (error) {
|
|
console.error('Error formatting config:', error);
|
|
return ''; // Return empty string if not valid for now
|
|
}
|
|
}
|
|
|
|
function extractCurlyBracesContent(input: string): string {
|
|
const startIndex = input.indexOf('{');
|
|
const endIndex = input.lastIndexOf('}');
|
|
if (startIndex === -1 || endIndex === -1 || endIndex <= startIndex) {
|
|
throw new Error('No outer curly braces found in input');
|
|
}
|
|
return input.slice(startIndex, endIndex + 1);
|
|
}
|
|
|
|
function cleanContent(content: string): string {
|
|
return content
|
|
.replace(/[\r\n]+/g, ' ')
|
|
.replace(/\s+/g, ' ')
|
|
.trim();
|
|
}
|
|
|
|
/**
|
|
* Generate a the override pragma comment from a formatted config object string
|
|
*/
|
|
export async function generateOverridePragmaFromConfig(
|
|
formattedConfigString: string,
|
|
): Promise<string> {
|
|
const content = extractCurlyBracesContent(formattedConfigString);
|
|
const cleanConfig = cleanContent(content);
|
|
|
|
// Format the config to ensure it's valid
|
|
await prettier.format(`(${cleanConfig})`, {
|
|
semi: false,
|
|
parser: 'babel-ts',
|
|
plugins: [parserBabel, prettierPluginEstree],
|
|
});
|
|
|
|
return `// @OVERRIDE:${cleanConfig}`;
|
|
}
|
|
|
|
/**
|
|
* Update the override pragma comment in source code.
|
|
*/
|
|
export function updateSourceWithOverridePragma(
|
|
source: string,
|
|
newPragma: string,
|
|
): string {
|
|
const firstLineEnd = source.indexOf('\n');
|
|
const firstLine = source.substring(0, firstLineEnd);
|
|
|
|
const pragmaRegex = /^\/\/\s*@/;
|
|
if (firstLineEnd !== -1 && pragmaRegex.test(firstLine.trim())) {
|
|
return newPragma + source.substring(firstLineEnd);
|
|
} else {
|
|
return newPragma + '\n' + source;
|
|
}
|
|
}
|