OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 00:20:04 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

[DevTools] Don't keep stale root instances we never mounted around (#34504)

Browse Source
This commit is contained in:
Sebastian "Sebbie" Silbermann 2025-09-16 19:17:28 +02:00 committed by GitHub
parent 851bad0c88
commit 941cd803a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/react-devtools-shared/src/backend/fiber/renderer.js vendored
View File

@ -1516,7 +1516,7 @@ export function attach(
currentRoot = rootInstance;
unmountInstanceRecursively(rootInstance);
rootToFiberInstanceMap.delete(root);
flushPendingEvents(root);
flushPendingEvents();
currentRoot = (null: any);
});
@ -1541,7 +1541,7 @@ export function attach(
currentRoot = newRoot;
setRootPseudoKey(currentRoot.id, root.current);
mountFiberRecursively(root.current, false);
flushPendingEvents(root);
flushPendingEvents();
currentRoot = (null: any);
});
@ -2099,7 +2099,7 @@ export function attach(
}
}
function flushPendingEvents(root: Object): void {
function flushPendingEvents(): void {
if (shouldBailoutWithPendingOperations()) {
// If we aren't profiling, we can just bail out here.
// No use sending an empty update over the bridge.
@ -5349,7 +5349,7 @@ export function attach(
mountFiberRecursively(root.current, false);
flushPendingEvents(root);
flushPendingEvents();
needsToFlushComponentLogs = false;
currentRoot = (null: any);
@ -5452,6 +5452,9 @@ export function attach(
unmountInstanceRecursively(rootInstance);
removeRootPseudoKey(currentRoot.id);
rootToFiberInstanceMap.delete(root);
} else if (!prevWasMounted && !nextIsMounted) {
// We don't need this root anymore.
rootToFiberInstanceMap.delete(root);
}
if (isProfiling && isProfilingSupported) {
@ -5475,7 +5478,7 @@ export function attach(
}
// We're done here.
flushPendingEvents(root);
flushPendingEvents();
needsToFlushComponentLogs = false;