OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 00:20:04 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

[DevTools] Ignore repeated removals of the same IO (#34495)

Browse Source
This commit is contained in:
Sebastian "Sebbie" Silbermann 2025-09-16 18:54:52 +02:00 committed by GitHub
parent 5e0c951b58
commit 851bad0c88
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/react-devtools-shared/src/backend/fiber/renderer.js vendored
View File

@ -2902,9 +2902,22 @@ export function attach(
// Let's remove it from the parent SuspenseNode.
const ioInfo = asyncInfo.awaited;
const suspendedBySet = parentSuspenseNode.suspendedBy.get(ioInfo);
// A boundary can await the same IO multiple times.
// We still want to error if we're trying to remove IO that isn't present on
// this boundary so we need to check if we've already removed it.
// We're assuming previousSuspendedBy is a small array so this should be faster
// than allocating and maintaining a Set.
let alreadyRemovedIO = false;
for (let j = 0; j < i; j++) {
const removedIOInfo = previousSuspendedBy[j].awaited;
if (removedIOInfo === ioInfo) {
alreadyRemovedIO = true;
break;
}
}
if (
suspendedBySet === undefined ||
!suspendedBySet.delete(instance)
(!alreadyRemovedIO && !suspendedBySet.delete(instance))
) {
throw new Error(
'We are cleaning up async info that was not on the parent Suspense boundary. ' +