PyTorch MergeBot
3443627e07
Revert "[BE]: Enable RUFF TRY400 rule - log.exception ( #153473 )"
...
This reverts commit 4f4ecc583ehttps://github.com/pytorch/pytorch/pull/153473 on behalf of https://github.com/jeanschmidt due to seems to have broken internal signals, @albanD may I count on you to help the author merge his PR? D74837988 ([comment](https://github.com/pytorch/pytorch/pull/153473#issuecomment-2886017075 ))
2025-05-16 08:29:26 +00:00
Aaron Gokaslan
4f4ecc583e
[BE]: Enable RUFF TRY400 rule - log.exception ( #153473 )
...
Change logging.error to logging.exception to log additional information when relevant. A few places have slipped in logging.errors in try except since I last did a clean up here and the rule is stabilized so I am enabling it codebase wide. I have NOQA'd much of our custom exception stack trace handling for RPC calls and distributed and tried to a fix a few errors based on whether we immediately reraised it or if we didn't print any exception handling where it could be useful.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/153473
Approved by: https://github.com/albanD , https://github.com/cyyever
2025-05-15 13:36:59 +00:00
Xuehai Pan
3b798df853
[BE][Easy] enable UFMT for torch/distributed/{fsdp,optim,rpc}/ ( #128869 )
...
Part of #123062
- #123062
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128869
Approved by: https://github.com/fegin
ghstack dependencies: #128868
2024-06-18 21:49:08 +00:00
Aaron Orenstein
7c12cc7ce4
Flip default value for mypy disallow_untyped_defs [6/11] ( #127843 )
...
See #127836 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127843
Approved by: https://github.com/oulgen
ghstack dependencies: #127842
2024-06-08 18:49:29 +00:00
Edward Z. Yang
9a8f71f23e
Convert logging f-strings to use % format ( #98697 )
...
Codemod done with
https://gist.github.com/ezyang/2e8b0463cdc6be278478495b23ff0530 with
assistance from ChatGPT.
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/98697
Approved by: https://github.com/voznesenskym
2023-04-10 12:19:31 +00:00
Howard Huang
31d03c2f63
[RPC small change] Improving logging for store.wait error
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76548
Approved by: https://github.com/mrshenli
2022-05-05 18:23:17 +00:00
Howard Huang
811ccde41a
[Dynamic RPC] Add graceful shutdown for dynamic RPC members
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74561
Approved by: https://github.com/mrshenli
2022-04-26 13:12:55 +00:00
