OSSForks/tensorflow
1
0
Fork 0
mirror of https://github.com/zebrajr/tensorflow.git synced 2025-12-06 12:20:11 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

In profile_data_lib.cc, throw std::runtime_error instead of check fail.

Browse Source 
PiperOrigin-RevId: 820351230
This commit is contained in:
A. Unique TensorFlower 2025-10-16 12:32:49 -07:00 committed by TensorFlower Gardener
parent 83c407040a
commit c8b47aac14
3 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
third_party/xla/xla/python/profiler/BUILD vendored
View File

@ -16,13 +16,14 @@ cc_library(
"//xla/python:__pkg__",
],
deps = [
"//xla/pjrt:status_casters",
"//xla/tsl/platform:env",
"//xla/tsl/platform:logging",
"@com_google_absl//absl/log",
"@com_google_absl//absl/log:check",
"@com_google_protobuf//:protobuf_lite",
"@local_tsl//tsl/platform:env",
"@local_tsl//tsl/platform:logging",
"@local_tsl//tsl/platform:protobuf",
"@local_tsl//tsl/platform:status",
"@local_tsl//tsl/profiler/protobuf:xplane_proto_cc",
"@nanobind",
],

23
third_party/xla/xla/python/profiler/profile_data_lib.cc vendored
View File

@ -18,15 +18,16 @@ limitations under the License.
#include <cstddef>
#include <cstdint>
#include <memory>
#include <stdexcept>
#include <string>
#include "absl/log/check.h"
#include "absl/log/log.h"
#include "nanobind/nanobind.h"
#include "nanobind/stl/string.h" // IWYU pragma: keep
#include "tsl/platform/env.h"
#include "tsl/platform/logging.h"
#include "tsl/platform/status.h"
#include "xla/pjrt/status_casters.h"
#include "xla/tsl/platform/env.h"
#include "xla/tsl/platform/logging.h"
#include "tsl/profiler/protobuf/xplane.pb.h"
namespace tensorflow::profiler::python {
@ -186,8 +187,8 @@ VisitorIterator<nb::tuple, XStat> ProfilePlane::stats_end() {
/*static*/ ProfileData ProfileData::from_file(
const std::string& proto_file_path) {
std::string serialized_xspace;
TF_CHECK_OK(tsl::ReadFileToString(tsl::Env::Default(), proto_file_path,
&serialized_xspace));
xla::ThrowIfError(tsl::ReadFileToString(tsl::Env::Default(), proto_file_path,
&serialized_xspace));
return ProfileData(serialized_xspace.c_str(), serialized_xspace.size());
}
@ -198,14 +199,16 @@ VisitorIterator<nb::tuple, XStat> ProfilePlane::stats_end() {
return ProfileData(proto_ptr);
}
ProfileData::ProfileData(const char* serialized_xspace_ptr,
ProfileData::ProfileData(const void* serialized_xspace_ptr,
size_t serialized_xspace_size) {
CHECK_NOTNULL(serialized_xspace_ptr);
if (!xspace_) {
xspace_ = std::make_shared<XSpace>();
}
CHECK(xspace_->ParseFromArray(serialized_xspace_ptr, serialized_xspace_size));
if (!xspace_->ParseFromArray(serialized_xspace_ptr, serialized_xspace_size)) {
throw std::runtime_error("Failed to parse XSpace from array");
}
}
/*explicit*/ ProfileData::ProfileData(std::shared_ptr<XSpace> xspace_ptr) {
@ -216,8 +219,10 @@ ProfileData::ProfileData(const char* serialized_xspace_ptr,
if (!xspace_) {
xspace_ = std::make_shared<XSpace>();
}
CHECK(xspace_->ParseFromArray(serialized_xspace.data(),
serialized_xspace.size()));
if (!xspace_->ParseFromArray(serialized_xspace.data(),
serialized_xspace.size())) {
throw std::runtime_error("Failed to parse XSpace from array");
}
}
VisitorIterator<ProfilePlane, XPlane> ProfileData::planes_begin() {

2
third_party/xla/xla/python/profiler/profile_data_lib.h vendored
View File

@ -165,7 +165,7 @@ class ProfileData {
ProfileData() = delete;
ProfileData(const char* serialized_xspace_ptr, size_t serialized_xspace_size);
ProfileData(const void* serialized_xspace_ptr, size_t serialized_xspace_size);
explicit ProfileData(std::shared_ptr<XSpace> xspace_ptr);