OSSForks/tensorflow
1
0
Fork 0
mirror of https://github.com/zebrajr/tensorflow.git synced 2025-12-06 12:20:11 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Add some clarifying comments for Dockerfiles.

Browse Source 
PiperOrigin-RevId: 716675943
This commit is contained in:
Vladimir Belitskiy 2025-01-17 08:15:39 -08:00 committed by TensorFlower Gardener
parent 83ccbd99b7
commit 1ae20f1e43
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ci/devinfra/docker/windows/Dockerfile
View File

@ -1,3 +1,7 @@
# NOTE: This Dockerfile is no longer in use.
# It is kept just in case, but it's recommended to use the 2022 version,
# and that is what internal CI uses as well.
# This Dockerfile creates an image that has: # This Dockerfile creates an image that has:
# - the correct MTU setting for networking from inside the container to work. # - the correct MTU setting for networking from inside the container to work.
# - Visual Studio 2022 Build Tools # - Visual Studio 2022 Build Tools

3
ci/official/envs/windows_x86_2022
View File

@ -31,7 +31,6 @@ TFCI_WHL_SIZE_LIMIT_ENABLE=1
TFCI_WHL_IMPORT_TEST_ENABLE=1 TFCI_WHL_IMPORT_TEST_ENABLE=1
TFCI_PYTHON_VERIFY_PIP_INSTALL_ARGS="" TFCI_PYTHON_VERIFY_PIP_INSTALL_ARGS=""
# TODO(belitskiy): Add a link to the Dockerfile comment that explains this more.
# Used to simulate a T:\ drive within the container, to a limited extent, # Used to simulate a T:\ drive within the container, to a limited extent,
# via a symlink. # via a symlink.
# Helpful since the internal CI utilizes a T:\ drive, part of which is mounted # Helpful since the internal CI utilizes a T:\ drive, part of which is mounted
@ -39,6 +38,8 @@ TFCI_PYTHON_VERIFY_PIP_INSTALL_ARGS=""
# when using variables like `TFCI_OUTPUT_DIR` in `docker exec commands, # when using variables like `TFCI_OUTPUT_DIR` in `docker exec commands,
# requiring conditional path adjustments throughout the CI scripts. # requiring conditional path adjustments throughout the CI scripts.
# Note: This does not work for `docker cp` commands. # Note: This does not work for `docker cp` commands.
# For a little more detail, see:
# https://github.com/tensorflow/tensorflow/blob/cc3006af6fea8d2a1360b3b5e65f9d14bbdb7094/ci/devinfra/docker/windows2022/Dockerfile#L196
TFCI_OUTPUT_WIN_DOCKER_DIR='C:/drive_t' TFCI_OUTPUT_WIN_DOCKER_DIR='C:/drive_t'
# Docker on Windows doesn't support the `host` networking mode, and so # Docker on Windows doesn't support the `host` networking mode, and so