OSSForks/tensorflow
1
0
Fork 0
mirror of https://github.com/zebrajr/tensorflow.git synced 2025-12-08 07:38:39 +01:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

[TF:XLA] Don't pass HLO operands in HandleAtan2.

Browse Source 
This makes it consistent with the rest of the Visit methods where we only
pass the HLO itself.

PiperOrigin-RevId: 173990595
This commit is contained in:
A. Unique TensorFlower 2017-10-30 20:49:51 -07:00 committed by TensorFlower Gardener
parent 113be57466
commit 17695212cc
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tensorflow/compiler/xla/service/dfs_hlo_visitor.h
View File

@ -52,9 +52,6 @@ class HloInstruction;
// "unimplemented" error status.
//
// Note: this may change to an iterator in the future for flexibility purposes.
//
// TODO(b/26548304): Stop passing in information about the visited
// instruction that is accessible from the instruction object itself.
class DfsHloVisitor {
public:
DfsHloVisitor() {}
@ -110,8 +107,7 @@ class DfsHloVisitor {
virtual Status HandleAbs(HloInstruction* abs) {
return HandleElementwiseUnary(abs);
}
virtual Status HandleAtan2(HloInstruction* atan2, HloInstruction* y,
HloInstruction* x) {
virtual Status HandleAtan2(HloInstruction* atan2) {
return HandleElementwiseBinary(atan2);
}
virtual Status HandleRound(HloInstruction* round) {

2
tensorflow/compiler/xla/service/hlo_instruction.cc
View File

@ -2131,7 +2131,7 @@ Status HloInstruction::Visit(DfsHloVisitor* visitor) {
case HloOpcode::kAbs:
return visitor->HandleAbs(this);
case HloOpcode::kAtan2:
return visitor->HandleAtan2(this, operands_[0], operands_[1]);
return visitor->HandleAtan2(this);
case HloOpcode::kRoundNearestAfz:
return visitor->HandleRound(this);
case HloOpcode::kBatchNormTraining: