mirror of
https://github.com/zebrajr/react.git
synced 2025-12-06 12:20:20 +01:00
6090cab099
We basically have four kinds of recoverable errors: - Hydration mismatches. - Server errored but client didn't. - Hydration render errored but client render didn't (in Root or Suspense boundary). - Concurrent render errored but synchronous render didn't. For the first three we log an additional error that the root or Suspense boundary didn't error. This provides some context about what happened. However, the problem is that for hydration mismatches that's unnecessary extra context that is confusing. We also don't log any additional context for concurrent render errors that could recover. This used to be the only recoverable error so it didn't need extra context but now we need to distinguish them. When we log these to `reportError` it's confusing to just see the error because you didn't see anything error on the page. It's also hard to group them together as one. In this PR, I remove the unnecessary context for hydration mismatches. For hydration and concurrent errors, I now wrap them in an error that describes that what happened but then use the new `cause` field to link the original error so we can keep that as the cause. The error that happened was that hydration client rendered or you deopted to sync render, the cause of that error is some other error. For server errors, we control the Error object so I already had added some context to that error object's message. Since we hide the message in prod, it's nice not to have the raw message in DEV neither. We could potentially split these into two errors for parity though. |
||
|---|---|---|
| .. | ||
| babel | ||
| bench | ||
| circleci | ||
| devtools | ||
| error-codes | ||
| eslint | ||
| eslint-rules | ||
| flags | ||
| flow | ||
| git | ||
| jest | ||
| perf-counters | ||
| prettier | ||
| print-warnings | ||
| release | ||
| rollup | ||
| shared | ||
| tasks | ||
| authors | ||