mirror of
https://github.com/zebrajr/react.git
synced 2025-12-06 12:20:20 +01:00
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Part 3 of adding a "Config Override" panel to the React compiler playground. Added a button to apply config changes to the Input panel, as well as making the tab collapsible. Added validation for the the PluginOptions type (although comes with a bit more boilerplate) to make it very obvious what the possible config errors could be. Added some toasts for trying to apply broken configs. <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? https://github.com/user-attachments/assets/63ab8636-396f-45ba-aaa5-4136e62ccccc <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
353 lines
9.5 KiB
TypeScript
353 lines
9.5 KiB
TypeScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
import {parse as babelParse, ParseResult} from '@babel/parser';
|
|
import * as HermesParser from 'hermes-parser';
|
|
import * as t from '@babel/types';
|
|
import BabelPluginReactCompiler, {
|
|
CompilerError,
|
|
CompilerErrorDetail,
|
|
CompilerDiagnostic,
|
|
Effect,
|
|
ErrorSeverity,
|
|
parseConfigPragmaForTests,
|
|
ValueKind,
|
|
type Hook,
|
|
PluginOptions,
|
|
CompilerPipelineValue,
|
|
parsePluginOptions,
|
|
printReactiveFunctionWithOutlined,
|
|
printFunctionWithOutlined,
|
|
} from 'babel-plugin-react-compiler';
|
|
import clsx from 'clsx';
|
|
import invariant from 'invariant';
|
|
import {useSnackbar} from 'notistack';
|
|
import {useDeferredValue, useMemo} from 'react';
|
|
import {useMountEffect} from '../../hooks';
|
|
import {defaultStore} from '../../lib/defaultStore';
|
|
import {
|
|
createMessage,
|
|
initStoreFromUrlOrLocalStorage,
|
|
MessageLevel,
|
|
MessageSource,
|
|
type Store,
|
|
} from '../../lib/stores';
|
|
import {useStore, useStoreDispatch} from '../StoreContext';
|
|
import ConfigEditor from './ConfigEditor';
|
|
import Input from './Input';
|
|
import {
|
|
CompilerOutput,
|
|
CompilerTransformOutput,
|
|
default as Output,
|
|
PrintedCompilerPipelineValue,
|
|
} from './Output';
|
|
import {transformFromAstSync} from '@babel/core';
|
|
import {LoggerEvent} from 'babel-plugin-react-compiler/dist/Entrypoint';
|
|
import {useSearchParams} from 'next/navigation';
|
|
|
|
function parseInput(
|
|
input: string,
|
|
language: 'flow' | 'typescript',
|
|
): ParseResult<t.File> {
|
|
// Extract the first line to quickly check for custom test directives
|
|
if (language === 'flow') {
|
|
return HermesParser.parse(input, {
|
|
babel: true,
|
|
flow: 'all',
|
|
sourceType: 'module',
|
|
enableExperimentalComponentSyntax: true,
|
|
});
|
|
} else {
|
|
return babelParse(input, {
|
|
plugins: ['typescript', 'jsx'],
|
|
sourceType: 'module',
|
|
}) as ParseResult<t.File>;
|
|
}
|
|
}
|
|
|
|
function invokeCompiler(
|
|
source: string,
|
|
language: 'flow' | 'typescript',
|
|
options: PluginOptions,
|
|
): CompilerTransformOutput {
|
|
const ast = parseInput(source, language);
|
|
let result = transformFromAstSync(ast, source, {
|
|
filename: '_playgroundFile.js',
|
|
highlightCode: false,
|
|
retainLines: true,
|
|
plugins: [[BabelPluginReactCompiler, options]],
|
|
ast: true,
|
|
sourceType: 'module',
|
|
configFile: false,
|
|
sourceMaps: true,
|
|
babelrc: false,
|
|
});
|
|
if (result?.ast == null || result?.code == null || result?.map == null) {
|
|
throw new Error('Expected successful compilation');
|
|
}
|
|
return {
|
|
code: result.code,
|
|
sourceMaps: result.map,
|
|
language,
|
|
};
|
|
}
|
|
|
|
const COMMON_HOOKS: Array<[string, Hook]> = [
|
|
[
|
|
'useFragment',
|
|
{
|
|
valueKind: ValueKind.Frozen,
|
|
effectKind: Effect.Freeze,
|
|
noAlias: true,
|
|
transitiveMixedData: true,
|
|
},
|
|
],
|
|
[
|
|
'usePaginationFragment',
|
|
{
|
|
valueKind: ValueKind.Frozen,
|
|
effectKind: Effect.Freeze,
|
|
noAlias: true,
|
|
transitiveMixedData: true,
|
|
},
|
|
],
|
|
[
|
|
'useRefetchableFragment',
|
|
{
|
|
valueKind: ValueKind.Frozen,
|
|
effectKind: Effect.Freeze,
|
|
noAlias: true,
|
|
transitiveMixedData: true,
|
|
},
|
|
],
|
|
[
|
|
'useLazyLoadQuery',
|
|
{
|
|
valueKind: ValueKind.Frozen,
|
|
effectKind: Effect.Freeze,
|
|
noAlias: true,
|
|
transitiveMixedData: true,
|
|
},
|
|
],
|
|
[
|
|
'usePreloadedQuery',
|
|
{
|
|
valueKind: ValueKind.Frozen,
|
|
effectKind: Effect.Freeze,
|
|
noAlias: true,
|
|
transitiveMixedData: true,
|
|
},
|
|
],
|
|
];
|
|
|
|
function compile(
|
|
source: string,
|
|
mode: 'compiler' | 'linter',
|
|
): [CompilerOutput, 'flow' | 'typescript'] {
|
|
const results = new Map<string, Array<PrintedCompilerPipelineValue>>();
|
|
const error = new CompilerError();
|
|
const otherErrors: Array<CompilerErrorDetail | CompilerDiagnostic> = [];
|
|
const upsert: (result: PrintedCompilerPipelineValue) => void = result => {
|
|
const entry = results.get(result.name);
|
|
if (Array.isArray(entry)) {
|
|
entry.push(result);
|
|
} else {
|
|
results.set(result.name, [result]);
|
|
}
|
|
};
|
|
let language: 'flow' | 'typescript';
|
|
if (source.match(/\@flow/)) {
|
|
language = 'flow';
|
|
} else {
|
|
language = 'typescript';
|
|
}
|
|
let transformOutput;
|
|
try {
|
|
// Extract the first line to quickly check for custom test directives
|
|
const pragma = source.substring(0, source.indexOf('\n'));
|
|
const logIR = (result: CompilerPipelineValue): void => {
|
|
switch (result.kind) {
|
|
case 'ast': {
|
|
break;
|
|
}
|
|
case 'hir': {
|
|
upsert({
|
|
kind: 'hir',
|
|
fnName: result.value.id,
|
|
name: result.name,
|
|
value: printFunctionWithOutlined(result.value),
|
|
});
|
|
break;
|
|
}
|
|
case 'reactive': {
|
|
upsert({
|
|
kind: 'reactive',
|
|
fnName: result.value.id,
|
|
name: result.name,
|
|
value: printReactiveFunctionWithOutlined(result.value),
|
|
});
|
|
break;
|
|
}
|
|
case 'debug': {
|
|
upsert({
|
|
kind: 'debug',
|
|
fnName: null,
|
|
name: result.name,
|
|
value: result.value,
|
|
});
|
|
break;
|
|
}
|
|
default: {
|
|
const _: never = result;
|
|
throw new Error(`Unhandled result ${result}`);
|
|
}
|
|
}
|
|
};
|
|
const parsedOptions = parseConfigPragmaForTests(pragma, {
|
|
compilationMode: 'infer',
|
|
environment:
|
|
mode === 'linter'
|
|
? {
|
|
// enabled in compiler
|
|
validateRefAccessDuringRender: false,
|
|
// enabled in linter
|
|
validateNoSetStateInRender: true,
|
|
validateNoSetStateInEffects: true,
|
|
validateNoJSXInTryStatements: true,
|
|
validateNoImpureFunctionsInRender: true,
|
|
validateStaticComponents: true,
|
|
validateNoFreezingKnownMutableFunctions: true,
|
|
validateNoVoidUseMemo: true,
|
|
}
|
|
: {
|
|
/* use defaults for compiler mode */
|
|
},
|
|
});
|
|
const opts: PluginOptions = parsePluginOptions({
|
|
...parsedOptions,
|
|
environment: {
|
|
...parsedOptions.environment,
|
|
customHooks: new Map([...COMMON_HOOKS]),
|
|
},
|
|
logger: {
|
|
debugLogIRs: logIR,
|
|
logEvent: (_filename: string | null, event: LoggerEvent) => {
|
|
if (event.kind === 'CompileError') {
|
|
otherErrors.push(event.detail);
|
|
}
|
|
},
|
|
},
|
|
});
|
|
transformOutput = invokeCompiler(source, language, opts);
|
|
} catch (err) {
|
|
/**
|
|
* error might be an invariant violation or other runtime error
|
|
* (i.e. object shape that is not CompilerError)
|
|
*/
|
|
if (err instanceof CompilerError && err.details.length > 0) {
|
|
error.merge(err);
|
|
} else {
|
|
/**
|
|
* Handle unexpected failures by logging (to get a stack trace)
|
|
* and reporting
|
|
*/
|
|
console.error(err);
|
|
error.details.push(
|
|
new CompilerErrorDetail({
|
|
severity: ErrorSeverity.Invariant,
|
|
reason: `Unexpected failure when transforming input! ${err}`,
|
|
loc: null,
|
|
suggestions: null,
|
|
}),
|
|
);
|
|
}
|
|
}
|
|
// Only include logger errors if there weren't other errors
|
|
if (!error.hasErrors() && otherErrors.length !== 0) {
|
|
otherErrors.forEach(e => error.details.push(e));
|
|
}
|
|
if (error.hasErrors()) {
|
|
return [{kind: 'err', results, error}, language];
|
|
}
|
|
return [
|
|
{kind: 'ok', results, transformOutput, errors: error.details},
|
|
language,
|
|
];
|
|
}
|
|
|
|
export default function Editor(): JSX.Element {
|
|
const store = useStore();
|
|
const deferredStore = useDeferredValue(store);
|
|
const dispatchStore = useStoreDispatch();
|
|
const {enqueueSnackbar} = useSnackbar();
|
|
const [compilerOutput, language] = useMemo(
|
|
() => compile(deferredStore.source, 'compiler'),
|
|
[deferredStore.source],
|
|
);
|
|
const [linterOutput] = useMemo(
|
|
() => compile(deferredStore.source, 'linter'),
|
|
[deferredStore.source],
|
|
);
|
|
|
|
// TODO: Remove this once the config editor is more stable
|
|
const searchParams = useSearchParams();
|
|
const search = searchParams.get('showConfig');
|
|
const shouldShowConfig = search === 'true';
|
|
|
|
useMountEffect(() => {
|
|
// Initialize store
|
|
let mountStore: Store;
|
|
try {
|
|
mountStore = initStoreFromUrlOrLocalStorage();
|
|
} catch (e) {
|
|
invariant(e instanceof Error, 'Only Error may be caught.');
|
|
enqueueSnackbar(e.message, {
|
|
variant: 'warning',
|
|
...createMessage(
|
|
'Bad URL - fell back to the default Playground.',
|
|
MessageLevel.Info,
|
|
MessageSource.Playground,
|
|
),
|
|
});
|
|
mountStore = defaultStore;
|
|
}
|
|
|
|
dispatchStore({
|
|
type: 'setStore',
|
|
payload: {
|
|
store: mountStore,
|
|
},
|
|
});
|
|
});
|
|
|
|
let mergedOutput: CompilerOutput;
|
|
let errors: Array<CompilerErrorDetail | CompilerDiagnostic>;
|
|
if (compilerOutput.kind === 'ok') {
|
|
errors = linterOutput.kind === 'ok' ? [] : linterOutput.error.details;
|
|
mergedOutput = {
|
|
...compilerOutput,
|
|
errors,
|
|
};
|
|
} else {
|
|
mergedOutput = compilerOutput;
|
|
errors = compilerOutput.error.details;
|
|
}
|
|
return (
|
|
<>
|
|
<div className="relative flex basis top-14">
|
|
{shouldShowConfig && <ConfigEditor />}
|
|
<div className={clsx('relative sm:basis-1/4')}>
|
|
<Input language={language} errors={errors} />
|
|
</div>
|
|
<div className={clsx('flex sm:flex flex-wrap')}>
|
|
<Output store={deferredStore} compilerOutput={mergedOutput} />
|
|
</div>
|
|
</div>
|
|
</>
|
|
);
|
|
}
|