mirror of
https://github.com/zebrajr/react.git
synced 2025-12-06 00:20:04 +01:00
* s/flushPassiveEffects/unstable_flushWithoutYielding a first crack at flushing the scheduler manually from inside act(). uses unstable_flushWithoutYielding(). The tests that changed, mostly replaced toFlushAndYield(...) with toHaveYielded(). For some tests that tested the state of the tree before flushing effects (but still after updates), I replaced act() with bacthedUpdates(). * ugh lint * pass build, flushPassiveEffects returns nothing now * pass test-fire * flush all work (not just effects), add a compatibility mode of note, unstable_flushWithoutYielding now returns a boolean much like flushPassiveEffects * umd build for scheduler/unstable_mock, pass the fixture with it * add a comment to Shcduler.umd.js for why we're exporting unstable_flushWithoutYielding * run testsutilsact tests in both sync/concurrent modes * augh lint * use a feature flag for the missing mock scheduler warning I also tried writing a test for it, but couldn't get the scheduler to unmock. included the failing test. * Update ReactTestUtilsAct-test.js - pass the mock scheduler warning test, - rewrite some tests to use Scheduler.yieldValue - structure concurrent/legacy suites neatly * pass failing tests in batchedmode-test * fix pretty/lint/import errors * pass test-build * nit: pull .create(null) out of the act() call
178 lines
5.2 KiB
JavaScript
178 lines
5.2 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
*/
|
|
import type {Thenable} from 'react-reconciler/src/ReactFiberScheduler';
|
|
|
|
import {
|
|
batchedUpdates,
|
|
flushPassiveEffects,
|
|
} from 'react-reconciler/inline.test';
|
|
import ReactSharedInternals from 'shared/ReactSharedInternals';
|
|
import warningWithoutStack from 'shared/warningWithoutStack';
|
|
import {warnAboutMissingMockScheduler} from 'shared/ReactFeatureFlags';
|
|
import enqueueTask from 'shared/enqueueTask';
|
|
import * as Scheduler from 'scheduler';
|
|
|
|
const {ReactShouldWarnActingUpdates} = ReactSharedInternals;
|
|
|
|
// this implementation should be exactly the same in
|
|
// ReactTestUtilsAct.js, ReactTestRendererAct.js, createReactNoop.js
|
|
|
|
let hasWarnedAboutMissingMockScheduler = false;
|
|
const flushWork =
|
|
Scheduler.unstable_flushWithoutYielding ||
|
|
function() {
|
|
if (warnAboutMissingMockScheduler === true) {
|
|
if (hasWarnedAboutMissingMockScheduler === false) {
|
|
warningWithoutStack(
|
|
null,
|
|
'Starting from React v17, the "scheduler" module will need to be mocked ' +
|
|
'to guarantee consistent behaviour across tests and browsers. To fix this, add the following ' +
|
|
"to the top of your tests, or in your framework's global config file -\n\n" +
|
|
'As an example, for jest - \n' +
|
|
"jest.mock('scheduler', () => require.requireActual('scheduler/unstable_mock'));\n\n" +
|
|
'For more info, visit https://fb.me/react-mock-scheduler',
|
|
);
|
|
hasWarnedAboutMissingMockScheduler = true;
|
|
}
|
|
}
|
|
while (flushPassiveEffects()) {}
|
|
};
|
|
|
|
function flushWorkAndMicroTasks(onDone: (err: ?Error) => void) {
|
|
try {
|
|
flushWork();
|
|
enqueueTask(() => {
|
|
if (flushWork()) {
|
|
flushWorkAndMicroTasks(onDone);
|
|
} else {
|
|
onDone();
|
|
}
|
|
});
|
|
} catch (err) {
|
|
onDone(err);
|
|
}
|
|
}
|
|
|
|
// we track the 'depth' of the act() calls with this counter,
|
|
// so we can tell if any async act() calls try to run in parallel.
|
|
|
|
let actingUpdatesScopeDepth = 0;
|
|
|
|
function act(callback: () => Thenable) {
|
|
let previousActingUpdatesScopeDepth;
|
|
if (__DEV__) {
|
|
previousActingUpdatesScopeDepth = actingUpdatesScopeDepth;
|
|
actingUpdatesScopeDepth++;
|
|
ReactShouldWarnActingUpdates.current = true;
|
|
}
|
|
|
|
function onDone() {
|
|
if (__DEV__) {
|
|
actingUpdatesScopeDepth--;
|
|
if (actingUpdatesScopeDepth === 0) {
|
|
ReactShouldWarnActingUpdates.current = false;
|
|
}
|
|
if (actingUpdatesScopeDepth > previousActingUpdatesScopeDepth) {
|
|
// if it's _less than_ previousActingUpdatesScopeDepth, then we can assume the 'other' one has warned
|
|
warningWithoutStack(
|
|
null,
|
|
'You seem to have overlapping act() calls, this is not supported. ' +
|
|
'Be sure to await previous act() calls before making a new one. ',
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
const result = batchedUpdates(callback);
|
|
if (
|
|
result !== null &&
|
|
typeof result === 'object' &&
|
|
typeof result.then === 'function'
|
|
) {
|
|
// setup a boolean that gets set to true only
|
|
// once this act() call is await-ed
|
|
let called = false;
|
|
if (__DEV__) {
|
|
if (typeof Promise !== 'undefined') {
|
|
//eslint-disable-next-line no-undef
|
|
Promise.resolve()
|
|
.then(() => {})
|
|
.then(() => {
|
|
if (called === false) {
|
|
warningWithoutStack(
|
|
null,
|
|
'You called act(async () => ...) without await. ' +
|
|
'This could lead to unexpected testing behaviour, interleaving multiple act ' +
|
|
'calls and mixing their scopes. You should - await act(async () => ...);',
|
|
);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
// in the async case, the returned thenable runs the callback, flushes
|
|
// effects and microtasks in a loop until flushPassiveEffects() === false,
|
|
// and cleans up
|
|
return {
|
|
then(resolve: () => void, reject: (?Error) => void) {
|
|
called = true;
|
|
result.then(
|
|
() => {
|
|
flushWorkAndMicroTasks((err: ?Error) => {
|
|
onDone();
|
|
if (err) {
|
|
reject(err);
|
|
} else {
|
|
resolve();
|
|
}
|
|
});
|
|
},
|
|
err => {
|
|
onDone();
|
|
reject(err);
|
|
},
|
|
);
|
|
},
|
|
};
|
|
} else {
|
|
if (__DEV__) {
|
|
warningWithoutStack(
|
|
result === undefined,
|
|
'The callback passed to act(...) function ' +
|
|
'must return undefined, or a Promise. You returned %s',
|
|
result,
|
|
);
|
|
}
|
|
|
|
// flush effects until none remain, and cleanup
|
|
try {
|
|
flushWork();
|
|
onDone();
|
|
} catch (err) {
|
|
onDone();
|
|
throw err;
|
|
}
|
|
|
|
// in the sync case, the returned thenable only warns *if* await-ed
|
|
return {
|
|
then(resolve: () => void) {
|
|
if (__DEV__) {
|
|
warningWithoutStack(
|
|
false,
|
|
'Do not await the result of calling act(...) with sync logic, it is not a Promise.',
|
|
);
|
|
}
|
|
resolve();
|
|
},
|
|
};
|
|
}
|
|
}
|
|
|
|
export default act;
|