react

mirror of https://github.com/zebrajr/react.git synced 2025-12-07 12:20:38 +01:00

History

Flarnie Marchan e6af1580fa Update print warning script for low priority warning (#9756 ) * Add back caught error and other checks to 'lowPriorityWarning' what is the change?: This change makes 'lowPriorityWarning' an exact copy of 'warning.js' from `e66ba20ad5/packages/fbjs/src/__forks__/warning.js` where before we had skipped some checks from that module. - Adds an error which we catch, in order to let people find the error and resulting stack trace when using devtools with 'pause on caught errors' checked. - Adds check that 'format' argument is passed why make this change?: - To maintain a closer fork to 'warning.js' - To allow easier debugging using 'pause on caught errors' - To validate inputs to 'lowPriorityWarning' test plan: `yarn test` issue: * Update 'print-warnings' script to include 'lowPriorityWarning' output what is the change?: We print the logs from 'lowPriorityWarning' as well as 'warning' from the 'print-warnings' script. NOTE: This PR is branching off of https://github.com/facebook/react/pull/9754 why make this change?: We want to use the same process of white/blacklisting warnings with 'lowPriorityWarning' that we do with 'warning'. test plan: This is not super easy to test unless we are doing a sync with FB afaik. I plan on running a sync in the next few days, or next week at latest, for the sake of not landing big things on a Friday. That will be the actual test of this. issue: https://github.com/facebook/react/issues/9398	2017-05-26 07:47:49 -07:00
..
print-warnings.js	Update print warning script for low priority warning (#9756 )	2017-05-26 07:47:49 -07:00
README.md	Fix the print warnings script (#9344 )	2017-04-05 18:54:48 +01:00

Flarnie Marchan e6af1580fa Update print warning script for low priority warning (#9756 )

* Add back caught error and other checks to 'lowPriorityWarning'

**what is the change?:**
This change makes 'lowPriorityWarning' an exact copy of 'warning.js' from
e66ba20ad5/packages/fbjs/src/__forks__/warning.js
where before we had skipped some checks from that module.

- Adds an error which we catch, in order to let people find the error and resulting stack trace when using devtools with 'pause on caught errors' checked.
- Adds check that 'format' argument is passed

**why make this change?:**
- To maintain a closer fork to 'warning.js'
- To allow easier debugging using 'pause on caught errors'
- To validate inputs to 'lowPriorityWarning'

**test plan:**
`yarn test`

**issue:**

* Update 'print-warnings' script to include 'lowPriorityWarning' output

**what is the change?:**
We print the logs from 'lowPriorityWarning' as well as 'warning' from the 'print-warnings' script.

NOTE: This PR is branching off of https://github.com/facebook/react/pull/9754

**why make this change?:**
We want to use the same process of white/blacklisting warnings with 'lowPriorityWarning' that we do with 'warning'.

**test plan:**
This is not super easy to test unless we are doing a sync with FB afaik. I plan on running a sync in the next few days, or next week at latest, for the sake of not landing big things on a Friday. That will be the actual test of this.

**issue:**
https://github.com/facebook/react/issues/9398

2017-05-26 07:47:49 -07:00

print-warnings.js Update print warning script for low priority warning (#9756 ) 2017-05-26 07:47:49 -07:00

README.md Fix the print warnings script (#9344 ) 2017-04-05 18:54:48 +01:00

README.md

We use this script to extract all messages from warning() calls. They don't get substituted with anything in the source or the build. We only do this so we can have a copy of these messages in our internal repository and can spot accidental changes to them.