mirror of
https://github.com/zebrajr/react.git
synced 2025-12-07 00:20:28 +01:00
7939d92fcc
Removes `EnvironmentConfig.enableMinimalTransformsForRetry` in favor of `run` parameters. This is a minimal difference but lets us explicitly opt out certain compiler passes based on mode parameters, instead of environment configurations Retry flags don't really make sense to have in `EnvironmentConfig` anyways as the config is user-facing API, while retrying is a compiler implementation detail. (per @josephsavona's feedback https://github.com/facebook/react/pull/32164#issuecomment-2608616479) > Re the "hacky" framing of this in the PR title: I think this is fine. I can see having something like a compilation or output mode that we use when running the pipeline. Rather than changing environment settings when we re-run, various passes could take effect based on the combination of the mode + env flags. The modes might be: > > * Full: transform, validate, memoize. This is the default today. > * Transform: Along the lines of the backup mode in this PR. Only applies transforms that do not require following the rules of React, like `fire()`. > * Validate: This could be used for ESLint. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32511). * #32512 * __->__ #32511 |
||
|---|---|---|
| .. | ||
| e2e-classic.config.js | ||
| e2e-forget.config.js | ||
| main.config.js | ||
| makeE2EConfig.js | ||
| makeSnapshotResolver.js | ||
| makeTransform.ts | ||
| setupEnvE2E.js | ||
| snapshot-resolver-no-forget.js | ||
| snapshot-resolver-with-forget.js | ||
| transform-no-forget.js | ||
| transform-with-forget.js | ||