mirror of
https://github.com/zebrajr/react.git
synced 2025-12-06 12:20:20 +01:00
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary The `yarn flow` command, as suggested for every PR Submission (Task No. 9), tells us `The yarn flow command now requires you to pick a primary renderer` and provides a list for the same. However, in at the bottom of the prompt, it suggests `If you are not sure, run yarn flow dom`. This command `yarn flow dom` does not exist in the list and thus the command does nothing and exits with `status code 1` without any flow test. <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> While trying to submit a different PR for code cleaning, just during submission I read the PR Guidelines, and while doing `yarn test`, `yarn lint`, and `yarn flow`, I came across this issue and thought of submitting a PR for the same. ## How did you test this change? Since this code change does not change any logic, just the text information, I only ran `yarn linc` and `yarn test` for the same. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> Here is how the issue currently looks like:  Signed-off-by: abhiram11 <abhiramsatpute@gmail.com> Co-authored-by: abhiram11 <abhiramsatpute@gmail.com>
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
process.on('unhandledRejection', err => {
|
|
throw err;
|
|
});
|
|
|
|
const chalk = require('chalk');
|
|
const runFlow = require('../flow/runFlow');
|
|
const inlinedHostConfigs = require('../shared/inlinedHostConfigs');
|
|
|
|
// This script is using `flow status` for a quick check with a server.
|
|
// Use it for local development.
|
|
|
|
const primaryRenderer = inlinedHostConfigs.find(
|
|
info => info.isFlowTyped && info.shortName === process.argv[2]
|
|
);
|
|
if (!primaryRenderer) {
|
|
console.log(
|
|
'The ' +
|
|
chalk.red('yarn flow') +
|
|
' command now requires you to pick a primary renderer:'
|
|
);
|
|
console.log();
|
|
inlinedHostConfigs.forEach(rendererInfo => {
|
|
if (rendererInfo.isFlowTyped) {
|
|
console.log(' * ' + chalk.cyan('yarn flow ' + rendererInfo.shortName));
|
|
}
|
|
});
|
|
console.log();
|
|
console.log(
|
|
'If you are not sure, run ' + chalk.green('yarn flow dom-node') + '.'
|
|
);
|
|
console.log(
|
|
'This will still typecheck non-DOM packages, although less precisely.'
|
|
);
|
|
console.log();
|
|
console.log('Note that checks for all renderers will run on CI.');
|
|
console.log(
|
|
'You can also do this locally with ' +
|
|
chalk.cyan('yarn flow-ci') +
|
|
' but it will be slow.'
|
|
);
|
|
console.log();
|
|
process.exit(1);
|
|
}
|
|
|
|
runFlow(primaryRenderer.shortName, ['status']);
|