mirror of
https://github.com/zebrajr/react.git
synced 2025-12-07 00:20:28 +01:00
42c3c967d1
* Transform invariant to custom error type
This transforms calls to the invariant module:
```js
invariant(condition, 'A %s message that contains %s', adj, noun);
```
Into throw statements:
```js
if (!condition) {
if (__DEV__) {
throw ReactError(`A ${adj} message that contains ${noun}`);
} else {
throw ReactErrorProd(ERR_CODE, adj, noun);
}
}
```
The only thing ReactError does is return an error whose name is set
to "Invariant Violation" to match the existing behavior.
ReactErrorProd is a special version used in production that throws
a minified error code, with a link to see to expanded form. This
replaces the reactProdInvariant module.
As a next step, I would like to replace our use of the invariant module
for user facing errors by transforming normal Error constructors to
ReactError and ReactErrorProd. (We can continue using invariant for
internal React errors that are meant to be unreachable, which was the
original purpose of invariant.)
* Use numbers instead of strings for error codes
* Use arguments instead of an array
I wasn't sure about this part so I asked Sebastian, and his rationale
was that using arguments will make ReactErrorProd slightly slower, but
using an array will likely make all the functions that throw slightly
slower to compile, so it's hard to say which way is better. But since
ReactErrorProd is in an error path, and fewer bytes is generally better,
no array is good.
* Casing nit
87 lines
2.6 KiB
JavaScript
87 lines
2.6 KiB
JavaScript
'use strict';
|
|
|
|
const path = require('path');
|
|
|
|
const babel = require('babel-core');
|
|
const coffee = require('coffee-script');
|
|
|
|
const tsPreprocessor = require('./typescript/preprocessor');
|
|
const createCacheKeyFunction = require('fbjs-scripts/jest/createCacheKeyFunction');
|
|
|
|
// Use require.resolve to be resilient to file moves, npm updates, etc
|
|
const pathToBabel = path.join(
|
|
require.resolve('babel-core'),
|
|
'..',
|
|
'package.json'
|
|
);
|
|
const pathToBabelPluginDevWithCode = require.resolve(
|
|
'../error-codes/minify-error-messages'
|
|
);
|
|
const pathToBabelPluginWrapWarning = require.resolve(
|
|
'../babel/wrap-warning-with-env-check'
|
|
);
|
|
const pathToBabelPluginAsyncToGenerator = require.resolve(
|
|
'babel-plugin-transform-async-to-generator'
|
|
);
|
|
const pathToBabelrc = path.join(__dirname, '..', '..', '.babelrc');
|
|
const pathToErrorCodes = require.resolve('../error-codes/codes.json');
|
|
|
|
const babelOptions = {
|
|
plugins: [
|
|
// For Node environment only. For builds, Rollup takes care of ESM.
|
|
require.resolve('babel-plugin-transform-es2015-modules-commonjs'),
|
|
|
|
pathToBabelPluginDevWithCode,
|
|
pathToBabelPluginWrapWarning,
|
|
|
|
// Keep stacks detailed in tests.
|
|
// Don't put this in .babelrc so that we don't embed filenames
|
|
// into ReactART builds that include JSX.
|
|
// TODO: I have not verified that this actually works.
|
|
require.resolve('babel-plugin-transform-react-jsx-source'),
|
|
|
|
require.resolve('../babel/transform-prevent-infinite-loops'),
|
|
],
|
|
retainLines: true,
|
|
};
|
|
|
|
module.exports = {
|
|
process: function(src, filePath) {
|
|
if (filePath.match(/\.coffee$/)) {
|
|
return coffee.compile(src, {bare: true});
|
|
}
|
|
if (filePath.match(/\.ts$/) && !filePath.match(/\.d\.ts$/)) {
|
|
return tsPreprocessor.compile(src, filePath);
|
|
}
|
|
if (!filePath.match(/\/third_party\//)) {
|
|
// for test files, we also apply the async-await transform, but we want to
|
|
// make sure we don't accidentally apply that transform to product code.
|
|
const isTestFile = !!filePath.match(/\/__tests__\//);
|
|
return babel.transform(
|
|
src,
|
|
Object.assign(
|
|
{filename: path.relative(process.cwd(), filePath)},
|
|
babelOptions,
|
|
isTestFile
|
|
? {
|
|
plugins: [pathToBabelPluginAsyncToGenerator].concat(
|
|
babelOptions.plugins
|
|
),
|
|
}
|
|
: {}
|
|
)
|
|
).code;
|
|
}
|
|
return src;
|
|
},
|
|
|
|
getCacheKey: createCacheKeyFunction([
|
|
__filename,
|
|
pathToBabel,
|
|
pathToBabelrc,
|
|
pathToBabelPluginDevWithCode,
|
|
pathToBabelPluginWrapWarning,
|
|
pathToErrorCodes,
|
|
]),
|
|
};
|