mirror of
https://github.com/zebrajr/react.git
synced 2025-12-06 12:20:20 +01:00
ea0c17b095
We have a whole ton of compiler errors due to us using a helper to
return breakpoints for CSS-in-js, which results in code like:
```
const styles = {
[responsive.up('xl')]: { ... }
}
```
this results in TONS of bailouts due to `(BuildHIR::lowerExpression)
Expected Identifier, got CallExpression key in ObjectExpression`.
I was looking into what it would take to fix it and why we don't allow
it, and following the paper trail is seems like the gotchas have been
fixed with the new mutability aliasing model that is fully rolled out.
It looks like this is the same pattern/issue that was fixed (see
https://github.com/facebook/react/blob/main/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/repro-object-expression-computed-key-modified-during-after-construction-hoisted-sequence-expr.js
and the old bug in
|
||
|---|---|---|
| .. | ||
| babel-plugin-react-compiler | ||
| eslint-plugin-react-compiler | ||
| make-read-only-util | ||
| react-compiler-healthcheck | ||
| react-compiler-runtime | ||
| react-forgive | ||
| react-mcp-server | ||
| snap | ||