OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 12:20:20 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Hot reloading: Avoid stack overflow on wide trees (#34145)

Browse Source 
Every sibling added to the stack here. Not sure this needs to be
recursive at all but certainly for siblings this can just be a loop.
This commit is contained in:
Sophie Alpert 2025-08-09 08:02:22 -07:00 committed by GitHub
parent 3958d5d84b
commit cf6e502ed2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 59 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/react-reconciler/src/ReactFiberHotReloading.js vendored
View File

@ -261,6 +261,7 @@ function scheduleFibersWithFamiliesRecursively(
staleFamilies: Set<Family>,
): void {
if (__DEV__) {
do {
const {alternate, child, sibling, tag, type} = fiber;
let candidateType = null;
@ -323,12 +324,11 @@ function scheduleFibersWithFamiliesRecursively(
staleFamilies,
);
}
if (sibling !== null) {
scheduleFibersWithFamiliesRecursively(
sibling,
updatedFamilies,
staleFamilies,
);
}
if (sibling === null) {
break;
}
fiber = sibling;
} while (true);
}
}