OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 00:20:04 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Revert "Clear memoizedState on unmount of fiber to avoid memory leak (#14218)"

Browse Source 
This reverts commit 9b2fb24f99.
This commit is contained in:
Dominic Gannaway 2018-11-19 15:24:31 +00:00 committed by GitHub
parent 9b2fb24f99
commit 9a91f12002
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/react-reconciler/src/ReactFiberCommitWork.js vendored
View File

@ -726,20 +726,11 @@ function detachFiber(current: Fiber) {
// get GC:ed but we don't know which for sure which parent is the current
// one so we'll settle for GC:ing the subtree of this child. This child
// itself will be GC:ed when the parent updates the next time.
// We do not null out the 'nextEffect' field as it causes tests to fail.
current.return = null;
current.child = null;
current.memoizedState = null;
current.updateQueue = null;
current.firstEffect = null;
current.lastEffect = null;
if (current.alternate) {
current.alternate.return = null;
current.alternate.child = null;
current.alternate.memoizedState = null;
current.alternate.updateQueue = null;
current.alternate.firstEffect = null;
current.alternate.lastEffect = null;
current.alternate.return = null;
}
}