OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 00:20:04 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fix typo in dangerfile.js which results in an unreachable code path… (#32277)

Browse Source 
## Summary

Fix typo in dangerfile.js which results in an unreachable code path
which ought to be hit when there is no matching base artifact during
DangerCI automated code review.

See:
221f3002ca/dangerfile.js (L73)
Compare:
221f3002ca/dangerfile.js (L171)
And the case which should hit this code path:
221f3002ca/dangerfile.js (L160)

Given the above context, the condition `Number === Infinity` is clearly
meant to be `decimal === Infinity`, which it will be if the `catch`
statement triggers when there is no matching base artifact. Without this
fix, the primitive value `Infinity` is passed to
`percentFormatter.format(decimal)`, resulting in the string `'+∞%'`.
With this fix, the resulting string will be the intended `'New file'`.

## [Resolves issue
32278](https://github.com/facebook/react/issues/32278)
This commit is contained in:
David Michael Gregg 2025-01-31 01:44:02 -05:00 committed by GitHub
parent 221f3002ca
commit 87c03a0a13
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dangerfile.js
View File

@ -70,7 +70,7 @@ const percentFormatter = new Intl.NumberFormat('en', {
}); });
function change(decimal) { function change(decimal) {
if (Number === Infinity) { if (decimal === Infinity) {
return 'New file'; return 'New file';
} }
if (decimal === -1) { if (decimal === -1) {