OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 12:20:20 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Reconciler: Change commitUpdate signature to account for unused updatePayload parameter (#28909)

Browse Source
This commit is contained in:
Sebastian Silbermann 2024-04-25 19:14:06 +02:00 committed by GitHub
parent d285b3acba
commit 82d8129e58
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 2 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/react-art/src/ReactFiberConfigART.js vendored
View File

@ -415,13 +415,7 @@ export function commitMount(instance, type, newProps) {
// Noop
}
export function commitUpdate(
instance,
updatePayload,
type,
oldProps,
newProps,
) {
export function commitUpdate(instance, type, oldProps, newProps) {
instance._applyProps(instance, newProps, oldProps);
}

1
packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js vendored
View File

@ -702,7 +702,6 @@ export function commitMount(
export function commitUpdate(
domElement: Instance,
updatePayload: any,
type: string,
oldProps: Props,
newProps: Props,

1
packages/react-native-renderer/src/ReactFiberConfigNative.js vendored
View File

@ -348,7 +348,6 @@ export function commitMount(
export function commitUpdate(
instance: Instance,
updatePayloadTODO: Object,
type: string,
oldProps: Props,
newProps: Props,

1
packages/react-noop-renderer/src/createReactNoop.js vendored
View File

@ -651,7 +651,6 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
commitUpdate(
instance: Instance,
updatePayload: Object,
type: string,
oldProps: Props,
newProps: Props,

19
packages/react-reconciler/src/ReactFiberCommitWork.js vendored
View File

@ -13,7 +13,6 @@ import type {
SuspenseInstance,
Container,
ChildSet,
UpdatePayload,
HoistableRoot,
FormInstance,
} from './ReactFiberConfig';
@ -2676,14 +2675,9 @@ function commitMutationEffectsOnFiber(
);
}
} else if (newResource === null && finishedWork.stateNode !== null) {
// We may have an update on a Hoistable element
const updatePayload: null | UpdatePayload =
(finishedWork.updateQueue: any);
finishedWork.updateQueue = null;
try {
commitUpdate(
finishedWork.stateNode,
updatePayload,
finishedWork.type,
current.memoizedProps,
finishedWork.memoizedProps,
@ -2754,19 +2748,8 @@ function commitMutationEffectsOnFiber(
const oldProps =
current !== null ? current.memoizedProps : newProps;
const type = finishedWork.type;
// TODO: Type the updateQueue to be specific to host components.
const updatePayload: null | UpdatePayload =
(finishedWork.updateQueue: any);
finishedWork.updateQueue = null;
try {
commitUpdate(
instance,
updatePayload,
type,
oldProps,
newProps,
finishedWork,
);
commitUpdate(instance, type, oldProps, newProps, finishedWork);
} catch (error) {
captureCommitPhaseError(finishedWork, finishedWork.return, error);
}

1
packages/react-test-renderer/src/ReactFiberConfigTestHost.js vendored
View File

@ -237,7 +237,6 @@ export const supportsMutation = true;
export function commitUpdate(
instance: Instance,
updatePayload: null | {...},
type: string,
oldProps: Props,
newProps: Props,