OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 12:20:20 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Use sigil instead of comparing baseState to null

Browse Source
This commit is contained in:
Andrew Clark 2017-10-18 15:39:58 -07:00
parent d9647282e6
commit 76659c418f
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/renderers/shared/fiber/ReactFiberUpdateQueue.js
View File

@ -64,6 +64,7 @@ export type UpdateQueue<State> = {
last: Update<State> | null,
callbackList: Array<Update<State>> | null,
hasForceUpdate: boolean,
isInitialized: boolean,
// Dev only
isProcessing?: boolean,
@ -77,6 +78,7 @@ function createUpdateQueue<State>(baseState: State): UpdateQueue<State> {
last: null,
callbackList: null,
hasForceUpdate: false,
isInitialized: false,
};
if (__DEV__) {
queue.isProcessing = false;
@ -204,6 +206,7 @@ function processUpdateQueue<State>(
expirationTime: currentQueue.expirationTime,
first: currentQueue.first,
last: currentQueue.last,
isInitialized: currentQueue.isInitialized,
// These fields are no longer valid because they were already committed.
// Reset them.
callbackList: null,
@ -225,9 +228,13 @@ function processUpdateQueue<State>(
// It depends on which fiber is the next current. Initialize with an empty
// base state, then set to the memoizedState when rendering. Not super
// happy with this approach.
let state = queue.baseState === null
? workInProgress.memoizedState
: queue.baseState;
let state;
if (queue.isInitialized) {
state = queue.baseState;
} else {
state = queue.baseState = workInProgress.memoizedState;
queue.isInitialized = true;
}
let dontMutatePrevState = true;
let update = queue.first;
let didSkip = false;