OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 00:20:04 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Lower case "rsc stream" debug info (#34921)

Browse Source 
This is an aesthetic thing. Most simple I/O entries are things like
"script", "stylesheet", "fetch" etc. which are all a single word and
lower case. The "RSC stream" name sticks out and draws unnecessary
attention to itself where as it's really the least interesting to look
at.

I don't love the name because I'm not sure how to explain it. It's
really mainly the byte size of the payload itself without considering
things like server awaits things which will have their own cause. So I'm
trying to communicate the download size of the stream of downloading the
`.rsc` file or the `"rsc stream"`.
This commit is contained in:
Sebastian Markbåge 2025-10-19 23:42:38 -07:00 committed by GitHub
parent 1440f4f42d
commit 21272a680f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 23 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/internal-test-utils/debugInfo.js
View File

@ -64,7 +64,7 @@ function normalizeIOInfo(config: DebugInfoConfig, ioInfo) {
if (promise) {
promise.then(); // init
if (promise.status === 'fulfilled') {
if (ioInfo.name === 'RSC stream') {
if (ioInfo.name === 'rsc stream') {
copy.byteSize = 0;
copy.value = {
value: 'stream',
@ -117,7 +117,7 @@ export function getDebugInfo(config: DebugInfoConfig, obj) {
for (let i = 0; i < debugInfo.length; i++) {
if (
debugInfo[i].awaited &&
debugInfo[i].awaited.name === 'RSC stream' &&
debugInfo[i].awaited.name === 'rsc stream' &&
config.ignoreRscStreamInfo
) {
// Ignore RSC stream I/O info.

2
packages/react-client/src/ReactFlightClient.js vendored
View File

@ -2721,7 +2721,7 @@ export function createStreamState(
(debugValuePromise: any).status = 'fulfilled';
(debugValuePromise: any).value = streamDebugValue;
streamState._debugInfo = {
name: 'RSC stream',
name: 'rsc stream',
start: response._debugStartTime,
end: response._debugStartTime, // will be updated once we finish a chunk
byteSize: 0, // will be updated as we resolve a data chunk

10
packages/react-devtools-shared/src/backend/fiber/renderer.js vendored
View File

@ -6171,7 +6171,10 @@ export function attach(
}
}
const newIO = asyncInfo.awaited;
if (newIO.name === 'RSC stream' && newIO.value != null) {
if (
(newIO.name === 'RSC stream' || newIO.name === 'rsc stream') &&
newIO.value != null
) {
const streamPromise = newIO.value;
// Special case RSC stream entries to pick the last entry keyed by the stream.
const existingEntry = streamEntries.get(streamPromise);
@ -6230,7 +6233,10 @@ export function attach(
continue;
}
foundIOEntries.add(ioInfo);
if (ioInfo.name === 'RSC stream' && ioInfo.value != null) {
if (
(ioInfo.name === 'RSC stream' || ioInfo.name === 'rsc stream') &&
ioInfo.value != null
) {
const streamPromise = ioInfo.value;
// Special case RSC stream entries to pick the last entry keyed by the stream.
const existingEntry = streamEntries.get(streamPromise);

24
packages/react-server/src/__tests__/ReactFlightAsyncDebugInfo-test.js vendored
View File

@ -459,7 +459,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -867,7 +867,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -985,7 +985,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -1460,7 +1460,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"byteSize": 0,
"end": 0,
"env": "Server",
"name": "RSC stream",
"name": "rsc stream",
"start": 0,
"value": {
"value": "stream",
@ -1475,7 +1475,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -1789,7 +1789,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -2083,7 +2083,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -2499,7 +2499,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -2665,7 +2665,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -2845,7 +2845,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -3130,7 +3130,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {
@ -3275,7 +3275,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
"awaited": {
"byteSize": 0,
"end": 0,
"name": "RSC stream",
"name": "rsc stream",
"owner": null,
"start": 0,
"value": {