OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2025-12-06 12:20:20 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Release pooled cache reference in complete/unwind (#22464)

Browse Source
This commit is contained in:
Joseph Savona 2021-09-29 15:49:52 -07:00 committed by GitHub
parent 95ecd4a2c3
commit 201af81b01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/react-reconciler/src/ReactFiberCacheComponent.new.js
View File

@ -99,14 +99,16 @@ export function popRootCachePool(root: FiberRoot, renderLanes: Lanes) {
return; return;
} }
// The `pooledCache` variable points to the cache that was used for new // The `pooledCache` variable points to the cache that was used for new
// cache boundaries during this render, if any. Stash it on the root so that // cache boundaries during this render, if any. Move ownership of the
// parallel transitions may share the same cache. We will clear this field // cache to the root so that parallel transitions may share the same
// once all the transitions that depend on it (which we track with // cache. We will clear this field once all the transitions that depend
// `pooledCacheLanes`) have committed. // on it (which we track with `pooledCacheLanes`) have committed.
root.pooledCache = pooledCache; root.pooledCache = pooledCache;
if (pooledCache !== null) { if (pooledCache !== null) {
root.pooledCacheLanes |= renderLanes; root.pooledCacheLanes |= renderLanes;
} }
// set to null, conceptually we are moving ownership to the root
pooledCache = null;
} }
export function restoreSpawnedCachePool( export function restoreSpawnedCachePool(

10
packages/react-reconciler/src/ReactFiberCacheComponent.old.js
View File

@ -99,14 +99,16 @@ export function popRootCachePool(root: FiberRoot, renderLanes: Lanes) {
return; return;
} }
// The `pooledCache` variable points to the cache that was used for new // The `pooledCache` variable points to the cache that was used for new
// cache boundaries during this render, if any. Stash it on the root so that // cache boundaries during this render, if any. Move ownership of the
// parallel transitions may share the same cache. We will clear this field // cache to the root so that parallel transitions may share the same
// once all the transitions that depend on it (which we track with // cache. We will clear this field once all the transitions that depend
// `pooledCacheLanes`) have committed. // on it (which we track with `pooledCacheLanes`) have committed.
root.pooledCache = pooledCache; root.pooledCache = pooledCache;
if (pooledCache !== null) { if (pooledCache !== null) {
root.pooledCacheLanes |= renderLanes; root.pooledCacheLanes |= renderLanes;
} }
// set to null, conceptually we are moving ownership to the root
pooledCache = null;
} }
export function restoreSpawnedCachePool( export function restoreSpawnedCachePool(