From 190758e6236938283b51dce7d3fd21af6801a470 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= <sebastian@calyptus.eu>
Date: Fri, 25 Jul 2025 10:21:00 -0400
Subject: [PATCH] [DevTools] Add column to vscode editor preset (#33994)

We should jump to the right column.

Unfortunately, the way presets are set up now you have to switch off and
switch to the preset for this to take effect.
---
 .../src/devtools/views/Editor/utils.js                     | 7 +++++--
 .../src/devtools/views/Settings/CodeEditorOptions.js       | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/packages/react-devtools-shared/src/devtools/views/Editor/utils.js b/packages/react-devtools-shared/src/devtools/views/Editor/utils.js
index b239c9d213..a107c517cb 100644
--- a/packages/react-devtools-shared/src/devtools/views/Editor/utils.js
+++ b/packages/react-devtools-shared/src/devtools/views/Editor/utils.js
@@ -16,7 +16,7 @@ export function checkConditions(
   try {
     const url = new URL(editorURL);
 
-    const [, sourceURL, line] = source;
+    const [, sourceURL, line, column] = source;
     let filePath;
 
     // Check if sourceURL is a correct URL, which has a protocol specified
@@ -47,12 +47,15 @@ export function checkConditions(
     }
 
     const lineNumberAsString = String(line);
+    const columnNumberAsString = String(column);
 
     url.href = url.href
       .replace('{path}', filePath)
       .replace('{line}', lineNumberAsString)
+      .replace('{column}', columnNumberAsString)
       .replace('%7Bpath%7D', filePath)
-      .replace('%7Bline%7D', lineNumberAsString);
+      .replace('%7Bline%7D', lineNumberAsString)
+      .replace('%7Bcolumn%7D', columnNumberAsString);
 
     return {url, shouldDisableButton: false};
   } catch (e) {
diff --git a/packages/react-devtools-shared/src/devtools/views/Settings/CodeEditorOptions.js b/packages/react-devtools-shared/src/devtools/views/Settings/CodeEditorOptions.js
index 3c9a24ef8a..aa5a776786 100644
--- a/packages/react-devtools-shared/src/devtools/views/Settings/CodeEditorOptions.js
+++ b/packages/react-devtools-shared/src/devtools/views/Settings/CodeEditorOptions.js
@@ -17,7 +17,7 @@ import {getDefaultOpenInEditorURL} from 'react-devtools-shared/src/utils';
 
 import styles from './SettingsShared.css';
 
-const vscodeFilepath = 'vscode://file/{path}:{line}';
+const vscodeFilepath = 'vscode://file/{path}:{line}:{column}';
 
 export default function CodeEditorOptions({
   environmentNames,