From 048fe53b225ada24d06f6c77ec4e29e24f5d6502 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 9 Apr 2020 20:43:50 +0100 Subject: [PATCH] Revert "Clear more Fiber fields in detachFiber (#18556)" This reverts commit d48dbb824985166ecb7b2959db03090a8593dce0. --- packages/react-reconciler/src/ReactFiberCommitWork.new.js | 4 ---- packages/react-reconciler/src/ReactFiberCommitWork.old.js | 4 ---- 2 files changed, 8 deletions(-) diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js index 8ce01dc70f..2901e8ea35 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.new.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.new.js @@ -1118,7 +1118,6 @@ function detachFiber(fiber: Fiber) { // itself will be GC:ed when the parent updates the next time. fiber.return = null; fiber.child = null; - fiber.sibling = null; fiber.memoizedState = null; fiber.updateQueue = null; fiber.dependencies = null; @@ -1128,9 +1127,6 @@ function detachFiber(fiber: Fiber) { fiber.pendingProps = null; fiber.memoizedProps = null; fiber.stateNode = null; - if (__DEV__) { - fiber._debugOwner = null; - } } function emptyPortalContainer(current: Fiber) { diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js index a1c84399a5..6600cc4799 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.old.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.old.js @@ -1118,7 +1118,6 @@ function detachFiber(fiber: Fiber) { // itself will be GC:ed when the parent updates the next time. fiber.return = null; fiber.child = null; - fiber.sibling = null; fiber.memoizedState = null; fiber.updateQueue = null; fiber.dependencies = null; @@ -1128,9 +1127,6 @@ function detachFiber(fiber: Fiber) { fiber.pendingProps = null; fiber.memoizedProps = null; fiber.stateNode = null; - if (__DEV__) { - fiber._debugOwner = null; - } } function emptyPortalContainer(current: Fiber) {