mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-07 00:21:07 +01:00
With ufmt in place https://github.com/pytorch/pytorch/pull/81157, we can now use it to gradually format all files. I'm breaking this down into multiple smaller batches to avoid too many merge conflicts later on. This batch (as copied from the current BLACK linter config): * `tools/**/*.py` Upcoming batchs: * `torchgen/**/*.py` * `torch/package/**/*.py` * `torch/onnx/**/*.py` * `torch/_refs/**/*.py` * `torch/_prims/**/*.py` * `torch/_meta_registrations.py` * `torch/_decomp/**/*.py` * `test/onnx/**/*.py` Once they are all formatted, BLACK linter will be removed. Pull Request resolved: https://github.com/pytorch/pytorch/pull/81285 Approved by: https://github.com/suo
160 lines
4.9 KiB
Python
Executable File
160 lines
4.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
import argparse
|
|
import fnmatch
|
|
import pathlib
|
|
import subprocess
|
|
import textwrap
|
|
|
|
from typing import Any, Dict, List
|
|
|
|
import yaml
|
|
|
|
|
|
REPO_ROOT = pathlib.Path(__file__).parent.parent.parent
|
|
CONFIG_YML = REPO_ROOT / ".circleci" / "config.yml"
|
|
WORKFLOWS_DIR = REPO_ROOT / ".github" / "workflows"
|
|
|
|
|
|
WORKFLOWS_TO_CHECK = [
|
|
"binary_builds",
|
|
"build",
|
|
"master_build",
|
|
# These are formatted slightly differently, skip them
|
|
# "scheduled-ci",
|
|
# "debuggable-scheduled-ci",
|
|
# "slow-gradcheck-scheduled-ci",
|
|
# "promote",
|
|
]
|
|
|
|
|
|
def add_job(
|
|
workflows: Dict[str, Any],
|
|
workflow_name: str,
|
|
type: str,
|
|
job: Dict[str, Any],
|
|
past_jobs: Dict[str, Any],
|
|
) -> None:
|
|
"""
|
|
Add job 'job' under 'type' and 'workflow_name' to 'workflow' in place. Also
|
|
add any dependencies (they must already be in 'past_jobs')
|
|
"""
|
|
if workflow_name not in workflows:
|
|
workflows[workflow_name] = {"when": "always", "jobs": []}
|
|
|
|
requires = job.get("requires", None)
|
|
if requires is not None:
|
|
for requirement in requires:
|
|
dependency = past_jobs[requirement]
|
|
add_job(
|
|
workflows,
|
|
dependency["workflow_name"],
|
|
dependency["type"],
|
|
dependency["job"],
|
|
past_jobs,
|
|
)
|
|
|
|
workflows[workflow_name]["jobs"].append({type: job})
|
|
|
|
|
|
def get_filtered_circleci_config(
|
|
workflows: Dict[str, Any], relevant_jobs: List[str]
|
|
) -> Dict[str, Any]:
|
|
"""
|
|
Given an existing CircleCI config, remove every job that's not listed in
|
|
'relevant_jobs'
|
|
"""
|
|
new_workflows: Dict[str, Any] = {}
|
|
past_jobs: Dict[str, Any] = {}
|
|
for workflow_name, workflow in workflows.items():
|
|
if workflow_name not in WORKFLOWS_TO_CHECK:
|
|
# Don't care about this workflow, skip it entirely
|
|
continue
|
|
|
|
for job_dict in workflow["jobs"]:
|
|
for type, job in job_dict.items():
|
|
if "name" not in job:
|
|
# Job doesn't have a name so it can't be handled
|
|
print("Skipping", type)
|
|
else:
|
|
if job["name"] in relevant_jobs:
|
|
# Found a job that was specified at the CLI, add it to
|
|
# the new result
|
|
add_job(new_workflows, workflow_name, type, job, past_jobs)
|
|
|
|
# Record the job in case it's needed as a dependency later
|
|
past_jobs[job["name"]] = {
|
|
"workflow_name": workflow_name,
|
|
"type": type,
|
|
"job": job,
|
|
}
|
|
|
|
return new_workflows
|
|
|
|
|
|
def commit_ci(files: List[str], message: str) -> None:
|
|
# Check that there are no other modified files than the ones edited by this
|
|
# tool
|
|
stdout = subprocess.run(
|
|
["git", "status", "--porcelain"], stdout=subprocess.PIPE
|
|
).stdout.decode()
|
|
for line in stdout.split("\n"):
|
|
if line == "":
|
|
continue
|
|
if line[0] != " ":
|
|
raise RuntimeError(
|
|
f"Refusing to commit while other changes are already staged: {line}"
|
|
)
|
|
|
|
# Make the commit
|
|
subprocess.run(["git", "add"] + files)
|
|
subprocess.run(["git", "commit", "-m", message])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
parser = argparse.ArgumentParser(
|
|
description="make .circleci/config.yml only have a specific set of jobs and delete GitHub actions"
|
|
)
|
|
parser.add_argument("--job", action="append", help="job name", default=[])
|
|
parser.add_argument(
|
|
"--filter-gha", help="keep only these github actions (glob match)", default=""
|
|
)
|
|
parser.add_argument(
|
|
"--make-commit",
|
|
action="store_true",
|
|
help="add change to git with to a do-not-merge commit",
|
|
)
|
|
args = parser.parse_args()
|
|
|
|
touched_files = [CONFIG_YML]
|
|
with open(CONFIG_YML, "r") as f:
|
|
config_yml = yaml.safe_load(f.read())
|
|
|
|
config_yml["workflows"] = get_filtered_circleci_config(
|
|
config_yml["workflows"], args.job
|
|
)
|
|
|
|
with open(CONFIG_YML, "w") as f:
|
|
yaml.dump(config_yml, f)
|
|
|
|
if args.filter_gha:
|
|
for relative_file in WORKFLOWS_DIR.iterdir():
|
|
path = REPO_ROOT.joinpath(relative_file)
|
|
if not fnmatch.fnmatch(path.name, args.filter_gha):
|
|
touched_files.append(path)
|
|
path.resolve().unlink()
|
|
|
|
if args.make_commit:
|
|
jobs_str = "\n".join([f" * {job}" for job in args.job])
|
|
message = textwrap.dedent(
|
|
f"""
|
|
[skip ci][do not merge] Edit config.yml to filter specific jobs
|
|
|
|
Filter CircleCI to only run:
|
|
{jobs_str}
|
|
|
|
See [Run Specific CI Jobs](https://github.com/pytorch/pytorch/blob/master/CONTRIBUTING.md#run-specific-ci-jobs) for details.
|
|
"""
|
|
).strip()
|
|
commit_ci([str(f.relative_to(REPO_ROOT)) for f in touched_files], message)
|