mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-06 12:20:52 +01:00
e3900d2ba5
Summary:
As this diff shows, currently there are a couple hundred instances of raw `noqa` in the codebase, which just ignore all errors on a given line. That isn't great, so this PR changes all existing instances of that antipattern to qualify the `noqa` with respect to a specific error code, and adds a lint to prevent more of this from happening in the future.
Interestingly, some of the examples the `noqa` lint catches are genuine attempts to qualify the `noqa` with a specific error code, such as these two:
```
test/jit/test_misc.py:27: print(f"{hello + ' ' + test}, I'm a {test}") # noqa E999
test/jit/test_misc.py:28: print(f"format blank") # noqa F541
```
However, those are still wrong because they are [missing a colon](https://flake8.pycqa.org/en/3.9.1/user/violations.html#in-line-ignoring-errors), which actually causes the error code to be completely ignored:
- If you change them to anything else, the warnings will still be suppressed.
- If you add the necessary colons then it is revealed that `E261` was also being suppressed, unintentionally:
```
test/jit/test_misc.py:27:57: E261 at least two spaces before inline comment
test/jit/test_misc.py:28:35: E261 at least two spaces before inline comment
```
I did try using [flake8-noqa](https://pypi.org/project/flake8-noqa/) instead of a custom `git grep` lint, but it didn't seem to work. This PR is definitely missing some of the functionality that flake8-noqa is supposed to provide, though, so if someone can figure out how to use it, we should do that instead.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56272
Test Plan:
CI should pass on the tip of this PR, and we know that the lint works because the following CI run (before this PR was finished) failed:
- https://github.com/pytorch/pytorch/runs/2365189927
Reviewed By: janeyx99
Differential Revision: D27830127
Pulled By: samestep
fbshipit-source-id: d6dcf4f945ebd18cd76c46a07f3b408296864fcb
97 lines
4.7 KiB
Python
97 lines
4.7 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from torch.testing._internal.common_utils import run_tests
|
|
|
|
# Quantized Tensor
|
|
from quantization.test_quantized_tensor import TestQuantizedTensor # noqa: F401
|
|
# Quantized Op
|
|
# TODO: merge test cases in quantization.test_quantized
|
|
from quantization.test_quantized_op import TestQuantizedOps # noqa: F401
|
|
from quantization.test_quantized_op import TestQNNPackOps # noqa: F401
|
|
from quantization.test_quantized_op import TestQuantizedLinear # noqa: F401
|
|
from quantization.test_quantized_op import TestQuantizedConv # noqa: F401
|
|
from quantization.test_quantized_op import TestDynamicQuantizedLinear # noqa: F401
|
|
from quantization.test_quantized_op import TestComparatorOps # noqa: F401
|
|
from quantization.test_quantized_op import TestPadding # noqa: F401
|
|
from quantization.test_quantized_op import TestQuantizedEmbeddingOps # noqa: F401
|
|
from quantization.test_quantized_op import TestDynamicQuantizedRNNOp # noqa: F401
|
|
|
|
# Quantized Functional
|
|
from quantization.test_quantized_functional import TestQuantizedFunctional # noqa: F401
|
|
|
|
# Quantized Module
|
|
from quantization.test_quantized_module import TestStaticQuantizedModule # noqa: F401
|
|
from quantization.test_quantized_module import TestDynamicQuantizedModule # noqa: F401
|
|
|
|
# Quantization Aware Training
|
|
from quantization.test_qat_module import TestQATModule # noqa: F401
|
|
|
|
# Quantization specific fusion passes
|
|
from quantization.test_fusion_passes import TestFusionPasses # noqa: F401
|
|
|
|
# Module
|
|
# TODO: some of the tests are actually operator tests, e.g. test_forward_per_tensor, and
|
|
# should be moved to test_quantized_op
|
|
from quantization.test_workflow_module import TestFakeQuantize # noqa: F401
|
|
from quantization.test_workflow_module import TestObserver # noqa: F401
|
|
# TODO: merge with TestObserver
|
|
# TODO: some tests belong to test_quantize.py, e.g. test_record_observer
|
|
from quantization.test_workflow_module import TestRecordHistogramObserver # noqa: F401
|
|
from quantization.test_workflow_module import TestHistogramObserver # noqa: F401
|
|
from quantization.test_workflow_module import TestDistributed # noqa: F401
|
|
|
|
# Workflow
|
|
# 1. Eager mode quantization
|
|
from quantization.test_quantize import TestPostTrainingStatic # noqa: F401
|
|
from quantization.test_quantize import TestPostTrainingDynamic # noqa: F401
|
|
from quantization.test_quantize import TestQuantizationAwareTraining # noqa: F401
|
|
from quantization.test_quantize import TestEagerModeOps # noqa: F401
|
|
from quantization.test_quantize import TestEagerModeQATOps # noqa: F401
|
|
|
|
# TODO: merge with other tests in test_quantize.py?
|
|
from quantization.test_quantize import TestFunctionalModule # noqa: F401
|
|
from quantization.test_quantize import TestFusion # noqa: F401
|
|
from quantization.test_quantize import TestModelNumerics # noqa: F401
|
|
from quantization.test_quantize import TestQuantizeONNXExport # noqa: F401
|
|
from quantization.test_quantize import TestDeprecatedJitQuantized # noqa: F401
|
|
|
|
# 2. Graph mode quantization
|
|
from quantization.test_quantize_jit import TestQuantizeJit # noqa: F401
|
|
from quantization.test_quantize_jit import TestQuantizeJitPasses # noqa: F401
|
|
from quantization.test_quantize_jit import TestQuantizeJitOps # noqa: F401
|
|
from quantization.test_quantize_jit import TestQuantizeDynamicJitPasses # noqa: F401
|
|
from quantization.test_quantize_jit import TestQuantizeDynamicJitOps # noqa: F401
|
|
|
|
# 3. GraphModule based graph mode quantization
|
|
try:
|
|
from quantization.test_quantize_fx import TestFuseFx # noqa: F401
|
|
from quantization.test_quantize_fx import TestQuantizeFx # noqa: F401
|
|
from quantization.test_quantize_fx import TestQuantizeFxOps # noqa: F401
|
|
from quantization.test_quantize_fx import TestQuantizeFxModels # noqa: F401
|
|
except ImportError:
|
|
# In FBCode we separate FX out into a separate target for the sake of dev
|
|
# velocity. These are covered by a separate test target `quantization_fx`
|
|
pass
|
|
|
|
# Tooling: numeric_suite
|
|
from quantization.test_numeric_suite import TestEagerModeNumericSuite # noqa: F401
|
|
|
|
try:
|
|
from quantization.test_numeric_suite_fx import TestFXGraphMatcher # noqa: F401
|
|
from quantization.test_numeric_suite_fx import TestFXGraphMatcherModels # noqa: F401
|
|
from quantization.test_numeric_suite_fx import TestFXNumericSuiteCoreAPIs # noqa: F401
|
|
from quantization.test_numeric_suite_fx import TestFXNumericSuiteCoreAPIsModels # noqa: F401
|
|
except ImportError:
|
|
pass
|
|
|
|
# Backward Compatibility
|
|
from quantization.test_backward_compatibility import TestSerialization # noqa: F401
|
|
|
|
# Equalization
|
|
from quantization.test_equalize import TestEqualizeEager # noqa: F401
|
|
# Bias Correction
|
|
from quantization.test_bias_correction import TestBiasCorrection # noqa: F401
|
|
|
|
if __name__ == '__main__':
|
|
run_tests()
|