mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-07 00:21:07 +01:00
dc24503a89
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/68201 Hash(c10::Scalar) made a bad assumption that it was valid to just hash over all the bytes of data of the c10::Scalar struct. Becuase c10::Scalar stores a union of different (float/int/complex) types with different sizes, not all bytes are valid in all cases. Hash() should only read the bytes corresponding to the currently active type. Test Plan: Added new unit tests. Verified HashTest.Scalar failed with the original Hash() impl and then fixed. Reviewed By: alanwaketan Differential Revision: D32367564 fbshipit-source-id: ac30dd4f6dd0513954986d3d23c0c11ba802c37b
78 lines
2.7 KiB
C++
78 lines
2.7 KiB
C++
#include <gtest/gtest.h>
|
|
#include <string>
|
|
|
|
#include "torch/csrc/lazy/core/hash.h"
|
|
#include "c10/util/int128.h"
|
|
|
|
namespace torch {
|
|
namespace lazy {
|
|
|
|
template <typename T>
|
|
void test_hash_repeatable_sensitive(T example_a, T example_b) {
|
|
// repeatable
|
|
EXPECT_EQ(Hash(example_a), Hash(example_a));
|
|
EXPECT_EQ(MHash(example_a), MHash(example_a));
|
|
EXPECT_EQ(MHash(example_a, example_a), MHash(example_a, example_a));
|
|
|
|
// sensitive
|
|
EXPECT_NE(Hash(example_a), Hash(example_b));
|
|
EXPECT_NE(MHash(example_a), MHash(example_b));
|
|
EXPECT_NE(MHash(example_a, example_a), MHash(example_a, example_b));
|
|
}
|
|
|
|
TEST(HashTest, Scalar) {
|
|
c10::Scalar a(0);
|
|
c10::Scalar b(0);
|
|
|
|
// simulate some garbage in the unused bits of the
|
|
// the tagged union that is c10::Scalar, which is bigger
|
|
// than the size of the int64_t we're currently using it with
|
|
*((uint8_t*)&b) = 1;
|
|
// actual 'value' of the Scalar as a 64 bit int shouldn't have changed
|
|
EXPECT_EQ(a.toLong(), b.toLong());
|
|
// and hash should ignore this garbage
|
|
EXPECT_EQ(Hash(a), Hash(b));
|
|
EXPECT_EQ(MHash(a), MHash(b));
|
|
EXPECT_EQ(MHash(a, a), MHash(a, b));
|
|
}
|
|
|
|
TEST(HashTest, Sanity) {
|
|
// String
|
|
test_hash_repeatable_sensitive(
|
|
std::string(
|
|
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut at suscipit purus."),
|
|
std::string(
|
|
"Lorem Jpsum dolor sit amet, consectetur adipiscing elit. Ut at suscipit purus."));
|
|
|
|
// Number types
|
|
test_hash_repeatable_sensitive(true, false);
|
|
test_hash_repeatable_sensitive((int8_t)0xfa, (int8_t)0xfb);
|
|
test_hash_repeatable_sensitive((int16_t)0xface, (int16_t)0xfade);
|
|
test_hash_repeatable_sensitive((int32_t)0xfaceb000, (int32_t)0xfadeb000);
|
|
test_hash_repeatable_sensitive((int64_t)0x1faceb000, (int64_t)0x1fadeb000);
|
|
test_hash_repeatable_sensitive((uint8_t)0xfa, (uint8_t)0xfb);
|
|
test_hash_repeatable_sensitive((uint16_t)0xface, (uint16_t)0xfade);
|
|
test_hash_repeatable_sensitive((uint32_t)0xfaceb000, (uint32_t)0xfadeb000);
|
|
test_hash_repeatable_sensitive((uint64_t)0x1faceb000, (uint64_t)0x1fadeb000);
|
|
|
|
// c10 types
|
|
test_hash_repeatable_sensitive(c10::ScalarType::Bool, c10::ScalarType::Byte);
|
|
test_hash_repeatable_sensitive(c10::Scalar(1.334), c10::Scalar(1.335));
|
|
test_hash_repeatable_sensitive(c10::Scalar(true), c10::Scalar(false));
|
|
test_hash_repeatable_sensitive(c10::Scalar(12345), c10::Scalar(12354));
|
|
|
|
// c10::optional
|
|
test_hash_repeatable_sensitive(
|
|
c10::optional<std::string>("I have value!"),
|
|
c10::optional<std::string>(c10::nullopt));
|
|
|
|
// Containers
|
|
test_hash_repeatable_sensitive(
|
|
std::vector<int32_t>({0, 1, 1, 2, 3, 5, 8}),
|
|
std::vector<int32_t>({1, 1, 2, 3, 5, 8, 12}));
|
|
|
|
}
|
|
|
|
} // namespace lazy
|
|
} // namespace torch
|