pytorch/torch/csrc/distributed/rpc/rref_impl.cpp
Shen Li ad4bc8c9b8 Best-effort Error Detection for Using Deleted UserRRefs (#34673)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/34673

Test Plan: Imported from OSS

Differential Revision: D20427839

Pulled By: mrshenli

fbshipit-source-id: b1b12ca42a9ed5294806c53fa7d6f54e7dc8b188
2020-03-12 21:39:15 -07:00

229 lines
7.4 KiB
C++

#include <torch/csrc/distributed/rpc/rref_impl.h>
#include <torch/csrc/distributed/autograd/rpc_messages/rpc_with_autograd.h>
#include <torch/csrc/distributed/autograd/utils.h>
#include <torch/csrc/distributed/rpc/rref_context.h>
#include <torch/csrc/distributed/rpc/rref_proto.h>
#include <torch/csrc/distributed/rpc/utils.h>
namespace {
// If the type is subtype of named type, return its qualifiedname, otherwise
// return its type str.
std::string getTypeStr(const c10::TypePtr& type) {
switch (type->kind()) {
case c10::TypeKind::FunctionType:
return type->cast<c10::FunctionType>()->name()->qualifiedName();
case c10::TypeKind::TupleType:
return type->cast<c10::TupleType>()->name()->qualifiedName();
case c10::TypeKind::ClassType:
return type->cast<c10::ClassType>()->name()->qualifiedName();
case c10::TypeKind::InterfaceType:
return type->cast<c10::InterfaceType>()->name()->qualifiedName();
default:
return type->str();
}
}
} // namespace
namespace torch {
namespace distributed {
namespace rpc {
std::atomic<local_id_t> RRefContext::nextLocalId_{0};
////////////////////////// RRefForkData /////////////////////////////////
RRefForkData::RRefForkData(
worker_id_t ownerId,
const RRefId& rrefId,
const ForkId& forkId,
worker_id_t parent,
std::string typeStr)
: ownerId_(ownerId),
rrefId_(rrefId),
forkId_(forkId),
parent_(parent),
typeStr_(std::move(typeStr)) {}
////////////////////////////// RRef /////////////////////////////////////
RRef::RRef(worker_id_t ownerId, const RRefId& rrefId, TypePtr type)
: RRefInterface(),
ownerId_(ownerId),
rrefId_(rrefId),
type_(std::move(type)) {}
RRefForkData RRef::fork() const {
auto& ctx = RRefContext::getInstance();
return RRefForkData(
ownerId_,
rrefId_,
ctx.genGloballyUniqueId(),
ctx.getWorkerId(),
getTypeStr(type_));
}
////////////////////////// UserRRef /////////////////////////////////////
UserRRef::UserRRef(
worker_id_t ownerId,
const RRefId& rrefId,
const ForkId& forkId,
TypePtr type)
: RRef(ownerId, rrefId, std::move(type)), forkId_(forkId) {
// Do nothing,
// (1) If this UserRRef is a fork of an existing RRef, RRefContext will send
// a RREF_FORK_REQUEST message to the owner.
// (2) If this the creator UserRRef, ScriptRemoteCall or PythonRemoteCall will
// properly notify the owner.
}
void UserRRef::tryDel() {
std::lock_guard<std::mutex> lockGuard(deletedOnOwnerMutex_);
if (!deletedOnOwner_) {
try {
RRefContext::getInstance().delUser(ownerId_, rrefId_, forkId_);
deletedOnOwner_ = true;
} catch (const std::exception& ex) {
LOG(ERROR) << "Error occurred when deleting UserRRef instance, "
<< "RRefId = " << rrefId_ << ", ForkId = " << forkId_ << " : "
<< ex.what();
} catch (...) {
LOG(ERROR) << "Error occurred when deleting UserRRef instance, "
<< "RRefId = " << rrefId_ << ", ForkId = " << forkId_ << " : "
<< "unknown error";
}
}
}
void UserRRef::release_resources() {
tryDel();
}
const ForkId& UserRRef::forkId() const {
return forkId_;
}
IValue UserRRef::toHere() {
// see Note [Best-Effort Check on Deleted UserRRefs]
TORCH_CHECK(
!deletedOnOwner_,
"User RRef with RRefId=",
rrefId(),
" and ForkId=",
forkId(),
" has been deleted. Cannot call to_here() on it after deletion.");
auto agent = RpcAgent::getCurrentRpcAgent();
// ScriptRRefFetchCall message always carries autograd context id even if
// the message itself does not contain any tensor, because the response would
// potentially contain tensors.
Message msgToSend;
if (isPyObj()) {
msgToSend = PythonRRefFetchCall(ownerId_, rrefId()).toMessage();
} else {
msgToSend = ScriptRRefFetchCall(ownerId_, rrefId()).toMessage();
}
auto futureResponse = autograd::sendMessageWithAutograd(
*agent,
agent->getWorkerInfo(ownerId_),
std::move(msgToSend),
true /* forceGradRecording */);
const Message& message = futureResponse->wait();
MessageType msgType = message.type();
auto response = deserializeResponse(message, msgType);
TORCH_INTERNAL_ASSERT(
msgType == MessageType::SCRIPT_RREF_FETCH_RET ||
msgType == MessageType::PYTHON_RREF_FETCH_RET,
"Message type should either be SCRIPT_RREF_FETCH_RET "
"or PYTHON_RREF_FETCH_RET");
RpcCommandBase& rpc = *response;
auto& rrefFetchRet = static_cast<RRefFetchRet&>(rpc);
if (isPyObj()) {
// wrap python serialized vector of ivalues into tuple, this
// made the C++ toHere interface to return single IValue
return ivalue::Tuple::create(rrefFetchRet.values());
} else {
return rrefFetchRet.values().front();
}
}
RRefForkData UserRRef::fork() const {
// Note [Best-Effort Check on Deleted UserRRefs]
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// This check does not guarantee correctness, as there could be another thread
// trying to delete this UserRRef concurrently. Passing this check does not
// mean this RRef will be alive throughout this function. This is just our
// best-effort attempt to raise proper error messages. The behavior of using
// deleted UserRRefs is undefined.
//
// The reason for not implementing strict checks are:
// 1. This would need to acquire lock on deletedOnOwnerMutex_, which would
// introduce unnecessary overhead for most normal use cases.
// 2. This would introduce a lot of complexities to get the behavior correct.
// Assume we acquired the lock here, and there is another thread X block
// waiting in tryDel() on the lock. Exiting this fork function would
// unblock thread X. However, while X proceeds with deleting this UserRRef,
// the call site of fork() might have added the UserRRef to
// pendingChildren_ map, but up to this point, nothing prevents X from
// deleting this RRef even if it shouldn't do so due to the state change
// in pendingChildren_. We might be able to get it right for now by locking
// and checking pendingChildren_ in X, but the gain does not seem to
// worth the complexity.
TORCH_CHECK(
!deletedOnOwner_,
"User RRef with RRefId=",
rrefId(),
" and ForkId=",
forkId(),
" has been deleted. Cannot call fork an UserRRef after deletion.");
return RRef::fork();
}
////////////////////////// OwnerRRef /////////////////////////////////////
const IValue& OwnerRRef::getValue() const {
std::unique_lock<std::mutex> lock(mutex_);
valueCV_.wait(lock, [this] { return value_.has_value(); });
return value_.value();
}
bool OwnerRRef::hasValue() const {
std::lock_guard<std::mutex> lock(mutex_);
return value_.has_value();
}
std::shared_ptr<FutureMessage> OwnerRRef::getFuture() {
std::unique_lock<std::mutex> lock(mutex_);
if (future_.get()) {
return future_;
}
future_ = std::make_shared<FutureMessage>();
std::shared_ptr<FutureMessage> ret = future_;
if (value_.has_value()) {
lock.unlock();
ret->markCompleted(Message());
}
return ret;
}
void OwnerRRef::setValue(IValue&& value) {
std::unique_lock<std::mutex> lock(mutex_);
value_ = std::move(value);
std::shared_ptr<FutureMessage> future;
future.swap(future_);
lock.unlock();
valueCV_.notify_all();
if (future.get() && !future->completed()) {
future->markCompleted(Message());
}
}
} // namespace rpc
} // namespace distributed
} // namespace torch