mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-06 12:20:52 +01:00
9bce208dfb
This is a lot of files changed! Don't panic! Here's how it works: * Previously, we set `follow_imports = silent` for our mypy.ini configuration. Per https://mypy.readthedocs.io/en/stable/running_mypy.html#follow-imports, what this does is whenever we have an import to a module which is not listed as a file to be typechecked in mypy, we typecheck it as normal but suppress all errors that occurred in that file. * When mypy is run inside lintrunner, the list of files is precisely the files covered by the glob in lintrunner.toml, but with files in excludes excluded. * The top-level directive `# mypy: ignore-errors` instructs mypy to typecheck the file as normal, but ignore all errors. * Therefore, it should be equivalent to set `follow_imports = normal`, if we put `# mypy: ignore-errors` on all files that were previously excluded from the file list. * Having done this, we can remove the exclude list from .lintrunner.toml, since excluding a file from typechecking is baked into the files themselves. * torch/_dynamo and torch/_inductor were previously in the exclude list, because they were covered by MYPYINDUCTOR. It is not OK to mark these as `# mypy: ignore-errors` as this will impede typechecking on the alternate configuration. So they are temporarily being checked twice, but I am suppressing the errors in these files as the configurations are not quite the same. I plan to unify the configurations so this is only a temporary state. * There were some straggler type errors after these changes somehow, so I fixed them as needed. There weren't that many. In the future, to start type checking a file, just remove the ignore-errors directive from the top of the file. The codemod was done with this script authored by GPT-4: ``` import glob exclude_patterns = [ ... ] for pattern in exclude_patterns: for filepath in glob.glob(pattern, recursive=True): if filepath.endswith('.py'): with open(filepath, 'r+') as f: content = f.read() f.seek(0, 0) f.write('# mypy: ignore-errors\n\n' + content) ``` Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/118414 Approved by: https://github.com/thiagocrepaldi, https://github.com/albanD
31 lines
557 B
Python
31 lines
557 B
Python
# mypy: ignore-errors
|
|
|
|
from . import fft, linalg, random
|
|
from ._dtypes import * # noqa: F403
|
|
from ._funcs import * # noqa: F403
|
|
from ._getlimits import finfo, iinfo
|
|
from ._ndarray import (
|
|
array,
|
|
asarray,
|
|
ascontiguousarray,
|
|
can_cast,
|
|
from_dlpack,
|
|
ndarray,
|
|
newaxis,
|
|
result_type,
|
|
)
|
|
from ._ufuncs import * # noqa: F403
|
|
from ._util import AxisError, UFuncTypeError
|
|
|
|
# from . import testing
|
|
|
|
alltrue = all
|
|
sometrue = any
|
|
|
|
inf = float("inf")
|
|
nan = float("nan")
|
|
from math import pi, e # isort: skip
|
|
|
|
False_ = False
|
|
True_ = True
|