pytorch/test/cpp/api/ordered_dict.cpp
Nikita Shulga 4cb534f92e Make PyTorch code-base clang-tidy compliant (#56892)
Summary:
This is an automatic change generated by the following script:
```
#!/usr/bin/env python3
from subprocess import check_output, check_call
import os

def get_compiled_files_list():
    import json
    with open("build/compile_commands.json") as f:
        data = json.load(f)
    files = [os.path.relpath(node['file']) for node in data]
    for idx, fname in enumerate(files):
        if fname.startswith('build/') and fname.endswith('.DEFAULT.cpp'):
            files[idx] = fname[len('build/'):-len('.DEFAULT.cpp')]
    return files

def run_clang_tidy(fname):
    check_call(["python3", "tools/clang_tidy.py", "-c", "build", "-x", fname,"-s"])
    changes = check_output(["git", "ls-files", "-m"])
    if len(changes) == 0:
        return
    check_call(["git", "commit","--all", "-m", f"NOLINT stubs for {fname}"])

def main():
    git_files = check_output(["git", "ls-files"]).decode("ascii").split("\n")
    compiled_files = get_compiled_files_list()
    for idx, fname in enumerate(git_files):
        if fname not in compiled_files:
            continue
        if fname.startswith("caffe2/contrib/aten/"):
            continue
        print(f"[{idx}/{len(git_files)}] Processing {fname}")
        run_clang_tidy(fname)

if __name__ == "__main__":
    main()
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/56892

Reviewed By: H-Huang

Differential Revision: D27991944

Pulled By: malfet

fbshipit-source-id: 5415e1eb2c1b34319a4f03024bfaa087007d7179
2021-04-28 14:10:25 -07:00

264 lines
8.8 KiB
C++

#include <gtest/gtest.h>
#include <test/cpp/api/support.h>
#include <torch/torch.h>
template <typename T>
using OrderedDict = torch::OrderedDict<std::string, T>;
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, IsEmptyAfterDefaultConstruction) {
OrderedDict<int> dict;
ASSERT_EQ(dict.key_description(), "Key");
ASSERT_TRUE(dict.is_empty());
ASSERT_EQ(dict.size(), 0);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, InsertAddsElementsWhenTheyAreYetNotPresent) {
OrderedDict<int> dict;
dict.insert("a", 1);
dict.insert("b", 2);
ASSERT_EQ(dict.size(), 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, GetReturnsValuesWhenTheyArePresent) {
OrderedDict<int> dict;
dict.insert("a", 1);
dict.insert("b", 2);
ASSERT_EQ(dict["a"], 1);
ASSERT_EQ(dict["b"], 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, GetThrowsWhenPassedKeysThatAreNotPresent) {
OrderedDict<int> dict;
dict.insert("a", 1);
dict.insert("b", 2);
ASSERT_THROWS_WITH(dict["foo"], "Key 'foo' is not defined");
ASSERT_THROWS_WITH(dict[""], "Key '' is not defined");
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, CanInitializeFromList) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict.size(), 2);
ASSERT_EQ(dict["a"], 1);
ASSERT_EQ(dict["b"], 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, InsertThrowsWhenPassedElementsThatArePresent) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_THROWS_WITH(dict.insert("a", 1), "Key 'a' already defined");
ASSERT_THROWS_WITH(dict.insert("b", 1), "Key 'b' already defined");
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, FrontReturnsTheFirstItem) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict.front().key(), "a");
ASSERT_EQ(dict.front().value(), 1);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, FrontThrowsWhenEmpty) {
OrderedDict<int> dict;
ASSERT_THROWS_WITH(dict.front(), "Called front() on an empty OrderedDict");
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, BackReturnsTheLastItem) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict.back().key(), "b");
ASSERT_EQ(dict.back().value(), 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, BackThrowsWhenEmpty) {
OrderedDict<int> dict;
ASSERT_THROWS_WITH(dict.back(), "Called back() on an empty OrderedDict");
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, FindReturnsPointersToValuesWhenPresent) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_NE(dict.find("a"), nullptr);
ASSERT_EQ(*dict.find("a"), 1);
ASSERT_NE(dict.find("b"), nullptr);
ASSERT_EQ(*dict.find("b"), 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, FindReturnsNullPointersWhenPasesdKeysThatAreNotPresent) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict.find("bar"), nullptr);
ASSERT_EQ(dict.find(""), nullptr);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, SubscriptOperatorThrowsWhenPassedKeysThatAreNotPresent) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict["a"], 1);
ASSERT_EQ(dict["b"], 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(
OrderedDictTest,
SubscriptOperatorReturnsItemsPositionallyWhenPassedIntegers) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict[0].key(), "a");
ASSERT_EQ(dict[0].value(), 1);
ASSERT_EQ(dict[1].key(), "b");
ASSERT_EQ(dict[1].value(), 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, SubscriptOperatorsThrowswhenPassedKeysThatAreNotPresent) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_THROWS_WITH(dict["foo"], "Key 'foo' is not defined");
ASSERT_THROWS_WITH(dict[""], "Key '' is not defined");
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, UpdateInsertsAllItemsFromAnotherOrderedDict) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
OrderedDict<int> dict2 = {{"c", 3}};
dict2.update(dict);
ASSERT_EQ(dict2.size(), 3);
ASSERT_NE(dict2.find("a"), nullptr);
ASSERT_NE(dict2.find("b"), nullptr);
ASSERT_NE(dict2.find("c"), nullptr);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, UpdateAlsoChecksForDuplicates) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
OrderedDict<int> dict2 = {{"a", 1}};
ASSERT_THROWS_WITH(dict2.update(dict), "Key 'a' already defined");
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, CanIterateItems) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
auto iterator = dict.begin();
ASSERT_NE(iterator, dict.end());
ASSERT_EQ(iterator->key(), "a");
ASSERT_EQ(iterator->value(), 1);
++iterator;
ASSERT_NE(iterator, dict.end());
ASSERT_EQ(iterator->key(), "b");
ASSERT_EQ(iterator->value(), 2);
++iterator;
ASSERT_EQ(iterator, dict.end());
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, EraseWorks) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}, {"c", 3}};
dict.erase("b");
ASSERT_FALSE(dict.contains("b"));
ASSERT_EQ(dict["a"], 1);
ASSERT_EQ(dict["c"], 3);
dict.erase("a");
ASSERT_FALSE(dict.contains("a"));
ASSERT_EQ(dict["c"], 3);
dict.erase("c");
ASSERT_FALSE(dict.contains("c"));
ASSERT_TRUE(dict.is_empty());
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, ClearMakesTheDictEmpty) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_FALSE(dict.is_empty());
dict.clear();
ASSERT_TRUE(dict.is_empty());
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, CanCopyConstruct) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
OrderedDict<int> copy = dict;
ASSERT_EQ(copy.size(), 2);
ASSERT_EQ(*copy[0], 1);
ASSERT_EQ(*copy[1], 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, CanCopyAssign) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
OrderedDict<int> copy = {{"c", 1}};
ASSERT_NE(copy.find("c"), nullptr);
copy = dict;
ASSERT_EQ(copy.size(), 2);
ASSERT_EQ(*copy[0], 1);
ASSERT_EQ(*copy[1], 2);
ASSERT_EQ(copy.find("c"), nullptr);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, CanMoveConstruct) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
OrderedDict<int> copy = std::move(dict);
ASSERT_EQ(copy.size(), 2);
ASSERT_EQ(*copy[0], 1);
ASSERT_EQ(*copy[1], 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, CanMoveAssign) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
OrderedDict<int> copy = {{"c", 1}};
ASSERT_NE(copy.find("c"), nullptr);
copy = std::move(dict);
ASSERT_EQ(copy.size(), 2);
ASSERT_EQ(*copy[0], 1);
ASSERT_EQ(*copy[1], 2);
ASSERT_EQ(copy.find("c"), nullptr);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, CanInsertWithBraces) {
OrderedDict<std::pair<int, int>> dict;
dict.insert("a", {1, 2});
ASSERT_FALSE(dict.is_empty());
ASSERT_EQ(dict["a"].first, 1);
ASSERT_EQ(dict["a"].second, 2);
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, ErrorMessagesIncludeTheKeyDescription) {
OrderedDict<int> dict("Penguin");
ASSERT_EQ(dict.key_description(), "Penguin");
dict.insert("a", 1);
ASSERT_FALSE(dict.is_empty());
ASSERT_THROWS_WITH(dict["b"], "Penguin 'b' is not defined");
ASSERT_THROWS_WITH(dict.insert("a", 1), "Penguin 'a' already defined");
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, KeysReturnsAllKeys) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict.keys(), std::vector<std::string>({"a", "b"}));
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, ValuesReturnsAllValues) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
ASSERT_EQ(dict.values(), std::vector<int>({1, 2}));
}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TEST(OrderedDictTest, ItemsReturnsAllItems) {
OrderedDict<int> dict = {{"a", 1}, {"b", 2}};
std::vector<OrderedDict<int>::Item> items = dict.items();
ASSERT_EQ(items.size(), 2);
ASSERT_EQ(items[0].key(), "a");
ASSERT_EQ(items[0].value(), 1);
ASSERT_EQ(items[1].key(), "b");
ASSERT_EQ(items[1].value(), 2);
}