9fff8155c3
This PR applies clang-tidy readability checks to jit sources and all headers in the code base. `readability-redundant-inline-specifier` is suppressed because it incurs too many changes. `readability-redundant-inline-specifier` is used to detect redundant inline specifiers on function and variable declarations. There are many in-class method definitions that are marked inline. Pull Request resolved: https://github.com/pytorch/pytorch/pull/164652 Approved by: https://github.com/Skylion007 |
||
|---|---|---|
| .. | ||
| alloc_cpu.cpp | ||
| alloc_cpu.h | ||
| COW.cpp | ||
| COW.h | ||
| COWDeleter.cpp | ||
| COWDeleter.h | ||
| DeviceGuardImplInterface.cpp | ||
| DeviceGuardImplInterface.h | ||
| FakeGuardImpl.h | ||
| GPUTrace.cpp | ||
| GPUTrace.h | ||
| HermeticPyObjectTLS.cpp | ||
| HermeticPyObjectTLS.h | ||
| InlineDeviceGuard.h | ||
| InlineEvent.h | ||
| InlineStreamGuard.h | ||
| LocalDispatchKeySet.cpp | ||
| LocalDispatchKeySet.h | ||
| PyInterpreter.cpp | ||
| PyInterpreter.h | ||
| PyInterpreterHooks.cpp | ||
| PyInterpreterHooks.h | ||
| PyObjectSlot.cpp | ||
| PyObjectSlot.h | ||
| PythonDispatcherTLS.cpp | ||
| PythonDispatcherTLS.h | ||
| README-cow.md | ||
| README.md | ||
| SizesAndStrides.cpp | ||
| SizesAndStrides.h | ||
| TorchDispatchModeTLS.cpp | ||
| TorchDispatchModeTLS.h | ||
| VirtualGuardImpl.h | ||
c10/core/impl provides headers for functionality that is only needed in very specific use-cases (e.g., you are defining a new device type), which are generally only needed by C10 or PyTorch code. If you are an ordinary end-user, you should not use headers in this folder. We permanently give NO backwards-compatibility guarantees for implementations in this folder.
Compare with c10/util, which provides functionality that is not directly related to being a deep learning library (e.g., C++20 polyfills), but may still be generally useful and visible to users.
(We don't call this c10/detail, because the detail namespace convention is for header private details. However, c10::impl may be utilized from external headers; it simply indicates that the functionality is not for end users.)