pytorch/tools/codegen/api
Edward Yang 9b0ffb9fb3 Delete cpp.group_arguments (#49043)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49043

Previously, this function had nontrivial algorithmic content,
but after #48195, this was just a swiss army knife for pasting
together arguments while maintaining structure.  I added some
more properties for Arguments for convenient access in this way,
and then inlined the implementation of group_arguments into all of its call
sites, simplifying whenever contextual.  This might be controversial, but I
think the resulting code is easier to understand.

You may notice that there is some modest code duplication between
dispatcher.cpparguments_exprs and CppSignature.argument_packs.
This is a known problem and I will be attempting to fix it in
a follow up PR.

Confirmed to be byte-for-byte compatible.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Reviewed By: H-Huang

Differential Revision: D25455885

Pulled By: ezyang

fbshipit-source-id: 8fbe066e8c3cb7ee8adb5b87296ec5bd7b49e01f
2020-12-10 18:20:46 -08:00
..
__init__.py Rewrite of ATen code generator (#42629) 2020-08-31 09:00:22 -07:00
autograd.py [pytorch][codegen] add autograd data model (#48249) 2020-11-19 21:47:05 -08:00
cpp.py Delete cpp.group_arguments (#49043) 2020-12-10 18:20:46 -08:00
dispatcher.py Delete cpp.group_arguments (#49043) 2020-12-10 18:20:46 -08:00
meta.py Rename positional and kwarg_only to have flat prefix (#49042) 2020-12-10 18:20:43 -08:00
native.py Delete cpp.group_arguments (#49043) 2020-12-10 18:20:46 -08:00
python.py Delete cpp.group_arguments (#49043) 2020-12-10 18:20:46 -08:00
types.py Delete cpp.group_arguments (#49043) 2020-12-10 18:20:46 -08:00