mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-07 12:21:27 +01:00
While reviewing https://github.com/pytorch/pytorch/pull/115381 noticed that `torch::jit::GraphFunction::optimized_graph_` is an `std::array<c10::optional<std::shared_ptr<Graph>>, N>`, which feels excessive as `shared_ptr` is already nullable and have `operator bool()`. Looking at https://github.com/pytorch/pytorch/pull/26488 that introduced the change, also does not hint that this indirection is necessary. Test plan: CI Pull Request resolved: https://github.com/pytorch/pytorch/pull/115473 Approved by: https://github.com/davidberard98, https://github.com/Skylion007 |
||
|---|---|---|
| .. | ||
| compilation_unit.h | ||
| function_impl.cpp | ||
| function_impl.h | ||
| method.h | ||
| module_save.cpp | ||
| module.cpp | ||
| module.h | ||
| object.cpp | ||
| object.h | ||