mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-07 12:21:27 +01:00
Summary: There are still a few work to be done: - Move logging and unify AT_WARN with LOG(ERROR). - A few header files are still being plumbed through, need cleaning. - caffe2::EnforceNotMet aliasing is not done yet. - need to unify the macros. See c10/util/Exception.h This is mainly a codemod and not causing functional changes. If you find your job failing and trace back to this diff, usually it can be fixed by the following approaches: (1) add //caffe2/c10:c10 to your dependency (or transitive dependency). (2) change objects such as at::Error, at::Optional to the c10 namespace. (3) change functions to the c10 namespace. Especially, caffe2::MakeString is not overridden by the unified c10::str function. Nothing else changes. Please kindly consider not reverting this diff - it involves multiple rounds of rebasing and the fix is usually simple. Contact jiayq@ or AI Platform Dev for details. Pull Request resolved: https://github.com/pytorch/pytorch/pull/12354 Reviewed By: orionr Differential Revision: D10238910 Pulled By: Yangqing fbshipit-source-id: 7794d5bf2797ab0ca6ebaccaa2f7ebbd50ff8f32
37 lines
939 B
C++
37 lines
939 B
C++
#include <gtest/gtest.h>
|
|
|
|
#include <torch/csrc/utils/memory.h>
|
|
|
|
#include <ATen/optional.h>
|
|
|
|
struct TestValue {
|
|
explicit TestValue(const int& x) : lvalue_(x) {}
|
|
explicit TestValue(int&& x) : rvalue_(x) {}
|
|
|
|
c10::optional<int> lvalue_;
|
|
c10::optional<int> rvalue_;
|
|
};
|
|
|
|
TEST(MakeUniqueTest, ForwardRvaluesCorrectly) {
|
|
auto ptr = torch::make_unique<TestValue>(123);
|
|
ASSERT_FALSE(ptr->lvalue_.has_value());
|
|
ASSERT_TRUE(ptr->rvalue_.has_value());
|
|
ASSERT_EQ(*ptr->rvalue_, 123);
|
|
}
|
|
|
|
TEST(MakeUniqueTest, ForwardLvaluesCorrectly) {
|
|
int x = 5;
|
|
auto ptr = torch::make_unique<TestValue>(x);
|
|
ASSERT_TRUE(ptr->lvalue_.has_value());
|
|
ASSERT_EQ(*ptr->lvalue_, 5);
|
|
ASSERT_FALSE(ptr->rvalue_.has_value());
|
|
}
|
|
|
|
TEST(MakeUniqueTest, CanConstructUniquePtrOfArray) {
|
|
auto ptr = torch::make_unique<int[]>(3);
|
|
// Value initialization is required by the standard.
|
|
ASSERT_EQ(ptr[0], 0);
|
|
ASSERT_EQ(ptr[1], 0);
|
|
ASSERT_EQ(ptr[2], 0);
|
|
}
|