mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-06 12:20:52 +01:00
58b145f515
Summary: Previously when tracing slicing & select negative indices would get normalized, fixing the index to the size of the traced tensor. This makes the behavior the same as script so aten::select with negative indices is emitted. Pull Request resolved: https://github.com/pytorch/pytorch/pull/10560 Differential Revision: D9493614 Pulled By: eellison fbshipit-source-id: ce7a8bae59863723247208d86b9f2948051ccc6c
73 lines
2.3 KiB
C
73 lines
2.3 KiB
C
#pragma once
|
|
|
|
#include "torch/csrc/python_headers.h"
|
|
|
|
#if PY_VERSION_HEX < 0x03060100
|
|
|
|
// PySlice_Unpack not introduced till python 3.6.1
|
|
// included here for backwards compatibility
|
|
// https://docs.python.org/3/c-api/slice.html#c.PySlice_Unpack
|
|
// https://github.com/python/cpython/blob/master/Objects/sliceobject.c#L196
|
|
|
|
inline int
|
|
__PySlice_Unpack(PyObject *_r,
|
|
Py_ssize_t *start, Py_ssize_t *stop, Py_ssize_t *step)
|
|
{
|
|
PySliceObject *r = (PySliceObject*)_r;
|
|
/* this is harder to get right than you might think */
|
|
|
|
// Py_BUILD_ASSERT replaced because it is not available in all versions
|
|
static_assert(PY_SSIZE_T_MIN + 1 <= -PY_SSIZE_T_MAX, "Build failed");
|
|
|
|
if (r->step == Py_None) {
|
|
*step = 1;
|
|
}
|
|
else {
|
|
if (!_PyEval_SliceIndex(r->step, step)) return -1;
|
|
if (*step == 0) {
|
|
PyErr_SetString(PyExc_ValueError,
|
|
"slice step cannot be zero");
|
|
return -1;
|
|
}
|
|
/* Here *step might be -PY_SSIZE_T_MAX-1; in this case we replace it
|
|
* with -PY_SSIZE_T_MAX. This doesn't affect the semantics, and it
|
|
* guards against later undefined behaviour resulting from code that
|
|
* does "step = -step" as part of a slice reversal.
|
|
*/
|
|
if (*step < -PY_SSIZE_T_MAX)
|
|
*step = -PY_SSIZE_T_MAX;
|
|
}
|
|
|
|
if (r->start == Py_None) {
|
|
*start = *step < 0 ? PY_SSIZE_T_MAX : 0;
|
|
}
|
|
else {
|
|
if (!_PyEval_SliceIndex(r->start, start)) return -1;
|
|
}
|
|
|
|
if (r->stop == Py_None) {
|
|
*stop = *step < 0 ? PY_SSIZE_T_MIN : PY_SSIZE_T_MAX;
|
|
}
|
|
else {
|
|
if (!_PyEval_SliceIndex(r->stop, stop)) return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#define THPUtils_unpackSlice(SLICE, START, STOP, STEP) \
|
|
(__PySlice_Unpack(SLICE, START, STOP, STEP) == 0)
|
|
#else
|
|
#define THPUtils_unpackSlice(SLICE, START, STOP, STEP) \
|
|
(PySlice_Unpack(SLICE, START, STOP, STEP) == 0)
|
|
#endif
|
|
|
|
// https://bugsfiles.kde.org/attachment.cgi?id=61186
|
|
#if PY_VERSION_HEX >= 0x03020000
|
|
#define THPUtils_parseSlice(SLICE, LEN, START, STOP, LENGTH, STEP) \
|
|
(PySlice_GetIndicesEx(SLICE, LEN, START, STOP, LENGTH, STEP) == 0)
|
|
#else
|
|
#define THPUtils_parseSlice(SLICE, LEN, START, STOP, LENGTH, STEP) \
|
|
(PySlice_GetIndicesEx((PySliceObject*)SLICE, LEN, START, STOP, LENGTH, STEP) == 0)
|
|
#endif
|