mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-07 12:21:27 +01:00
e880cb2fe0
beartype has served us well in identifying type errors and ensuring we call internal functions with the correct arguments (thanks!). However, the value of having beartype is diminished because of the following: 1. When beartype improves support for better Dict[] type checking, it discovered typing mistakes in some functions that were previously uncaught. This caused the exporter to fail with newer versions beartype when it used to succeed. Since we cannot fix PyTorch and release a new version just because of this, it creates confusion for users that have beartype in their environment from using torch.onnx 2. beartype adds an additional call line in the traceback, which makes the already thick dynamo stack even larger, affecting readability when users diagnose errors with the traceback. 3. Since the typing annotations need to be evaluated, we cannot use new syntaxes like `|` because we need to maintain compatibility with Python 3.8. We don't want to wait for PyTorch take py310 as the lowest supported Python before using the new typing syntaxes. Pull Request resolved: https://github.com/pytorch/pytorch/pull/130484 Approved by: https://github.com/titaiwangms |
||
|---|---|---|
| .. | ||
| assets | ||
| dynamo | ||
| expect | ||
| internal | ||
| model_defs | ||
| torch_export | ||
| autograd_helper.py | ||
| error_reproduction.py | ||
| onnx_test_common.py | ||
| pytorch_test_common.py | ||
| test_autograd_funs.py | ||
| test_custom_ops.py | ||
| test_export_modes.py | ||
| test_fx_op_consistency.py | ||
| test_fx_passes.py | ||
| test_fx_to_onnx_decomp_skip.py | ||
| test_fx_to_onnx_with_onnxruntime.py | ||
| test_fx_to_onnx.py | ||
| test_fx_type_promotion.py | ||
| test_models_onnxruntime.py | ||
| test_models_quantized_onnxruntime.py | ||
| test_models.py | ||
| test_onnx_opset.py | ||
| test_onnxscript_no_runtime.py | ||
| test_onnxscript_runtime.py | ||
| test_op_consistency.py | ||
| test_operators.py | ||
| test_pytorch_jit_onnx.py | ||
| test_pytorch_onnx_no_runtime.py | ||
| test_pytorch_onnx_onnxruntime_cuda.py | ||
| test_pytorch_onnx_onnxruntime.py | ||
| test_pytorch_onnx_shape_inference.py | ||
| test_symbolic_helper.py | ||
| test_utility_funs.py | ||
| test_verification.py | ||
| verify.py | ||