OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-07 12:21:27 +01:00
Code Issues Actions 37 Packages Projects Releases Wiki Activity
637ab85e7f
pytorch/cmake
History
Xu Han f1456c74a0 Fix mkl-static issue for Windows. (#130697) 
Background:
We found the pytorch Windows release/2.4 performance regression: https://github.com/pytorch/pytorch/issues/130619

After some debug works, I found the pytorch Windows static mkl build options are wrong:
<img width="1049" alt="image" src="https://github.com/user-attachments/assets/38692142-bfca-4c98-8092-6e105c82bb13">
1. Thread lib is wrong.
2. Miss `openmp` lib and config.
> Debug history: https://github.com/pytorch/pytorch/issues/130619#issuecomment-2226782504 and https://github.com/pytorch/pytorch/issues/130619#issuecomment-2226418611

This PR will fix `mkl-static` build options issue.
<img width="863" alt="image" src="https://github.com/user-attachments/assets/834f6cee-7e6d-4d74-b2bc-8a270f05e429">

Reference:
<img width="482" alt="image" src="https://github.com/user-attachments/assets/8184dadb-f230-4062-a49f-51df1d7285f5">

https://www.intel.com/content/www/us/en/developer/tools/oneapi/onemkl-link-line-advisor.html#gs.c6izlg

Pull Request resolved: https://github.com/pytorch/pytorch/pull/130697
Approved by: https://github.com/jgong5, https://github.com/atalman
2024-07-15 19:28:11 +00:00
..
External [ROCm] Use AOTriton as a dynamic library (#129094) 2024-07-01 21:39:27 +00:00
Modules Fix mkl-static issue for Windows. (#130697) 2024-07-15 19:28:11 +00:00
Modules_CUDA_fix Allow building for sm90a (#125523) 2024-05-06 20:03:12 +00:00
public Fix python detection in cuda.cmake (#130651) 2024-07-15 03:45:31 +00:00
Allowlist.cmake Replace whitelist with allowlist (#42067) 2020-07-28 08:01:16 -07:00
BuildVariables.cmake Remove Caffe2_MAIN_LIBS (#38408) 2020-05-15 12:27:15 -07:00
Caffe2Config.cmake.in [Submodule] Remove third-party onnx-tensorrt (#126542) 2024-05-19 22:34:24 +00:00
CheckAbi.cmake remove abi uncertainty and potential abi conflict (#94306) 2023-02-09 09:54:04 +00:00
cmake_uninstall.cmake.in
Codegen.cmake Set target dependencies to always build for sm90a on rowwise scaling (#129402) 2024-06-25 13:54:51 +00:00
DebugHelper.cmake Add debug helper function to check target property (#52093) 2021-02-11 15:37:14 -08:00
Dependencies.cmake [CMake] [3/N] Remove unused code (#130322) 2024-07-09 19:33:33 +00:00
FlatBuffers.cmake [pytorch][PR] Add ability for a mobile::Module to save as flatbuffer (#70201) 2022-01-12 16:30:39 -08:00
GoogleTestPatch.cmake Simplify cmake code (#91546) 2023-02-08 01:05:19 +00:00
IncludeSource.cpp.in CMake: Include instead of copying cpu kernel files (#67656) 2021-11-30 19:13:53 -08:00
iOS.cmake [executorch] Update iOS toolchain with a modern cmake syntax. (#115799) 2023-12-15 00:51:30 +00:00
Metal.cmake [CI] Compile on M1 natively (#95719) 2023-03-01 04:20:42 +00:00
MiscCheck.cmake Simplify CMake code (#127683) 2024-06-05 15:17:31 +00:00
prioritized_text.txt [Build] Add linker script optimization (#121975) 2024-04-09 20:22:25 +00:00
ProtoBuf.cmake [BE] Cleanup CMake flag suppressions (#97584) 2023-03-27 18:46:09 +00:00
ProtoBufPatch.cmake Migrate PyTorch to C++17 (#85969) 2022-12-08 02:27:48 +00:00
Summary.cmake [Caffe2] Remove Caffe2 documentation (#130089) 2024-07-10 00:52:16 +00:00
TorchConfig.cmake.in Remove outdated CUDA code from CMake (#128801) 2024-06-21 15:00:00 +00:00
TorchConfigVersion.cmake.in
VulkanCodegen.cmake [BE][CMake] Use FindPython module (#124613) 2024-05-29 13:17:35 +00:00
VulkanDependencies.cmake [Vulkan] Remove GLSL Code Gen (#91912) 2023-01-10 20:29:47 +00:00