mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-06 00:20:18 +01:00
Fix DOS newlines in `onednn/decompose_silu.[cpp|h]` introduced by https://github.com/pytorch/pytorch/pull/85591 as well as one in `.github/PULL_REQUEST_TEMPLATE.md` Pull Request resolved: https://github.com/pytorch/pytorch/pull/86973 Approved by: https://github.com/huydhn, https://github.com/izaitsevfb
164 lines
4.7 KiB
Python
164 lines
4.7 KiB
Python
"""
|
|
NEWLINE: Checks files to make sure there are no trailing newlines.
|
|
"""
|
|
import argparse
|
|
import json
|
|
import logging
|
|
import sys
|
|
|
|
from enum import Enum
|
|
from typing import List, NamedTuple, Optional
|
|
|
|
NEWLINE = 10 # ASCII "\n"
|
|
CARRIAGE_RETURN = 13 # ASCII "\r"
|
|
LINTER_CODE = "NEWLINE"
|
|
|
|
|
|
class LintSeverity(str, Enum):
|
|
ERROR = "error"
|
|
WARNING = "warning"
|
|
ADVICE = "advice"
|
|
DISABLED = "disabled"
|
|
|
|
|
|
class LintMessage(NamedTuple):
|
|
path: Optional[str]
|
|
line: Optional[int]
|
|
char: Optional[int]
|
|
code: str
|
|
severity: LintSeverity
|
|
name: str
|
|
original: Optional[str]
|
|
replacement: Optional[str]
|
|
description: Optional[str]
|
|
|
|
|
|
def check_file(filename: str) -> Optional[LintMessage]:
|
|
logging.debug("Checking file %s", filename)
|
|
|
|
with open(filename, "rb") as f:
|
|
lines = f.readlines()
|
|
|
|
if len(lines) == 0:
|
|
# File is empty, just leave it alone.
|
|
return None
|
|
|
|
if len(lines) == 1 and len(lines[0]) == 1:
|
|
# file is wrong whether or not the only byte is a newline
|
|
return LintMessage(
|
|
path=filename,
|
|
line=None,
|
|
char=None,
|
|
code=LINTER_CODE,
|
|
severity=LintSeverity.ERROR,
|
|
name="testestTrailing newline",
|
|
original=None,
|
|
replacement=None,
|
|
description="Trailing newline found. Run `lintrunner --take NEWLINE -a` to apply changes.",
|
|
)
|
|
|
|
if len(lines[-1]) == 1 and lines[-1][0] == NEWLINE:
|
|
try:
|
|
original = b"".join(lines).decode("utf-8")
|
|
except Exception as err:
|
|
return LintMessage(
|
|
path=filename,
|
|
line=None,
|
|
char=None,
|
|
code=LINTER_CODE,
|
|
severity=LintSeverity.ERROR,
|
|
name="Decoding failure",
|
|
original=None,
|
|
replacement=None,
|
|
description=f"utf-8 decoding failed due to {err.__class__.__name__}:\n{err}",
|
|
)
|
|
|
|
return LintMessage(
|
|
path=filename,
|
|
line=None,
|
|
char=None,
|
|
code=LINTER_CODE,
|
|
severity=LintSeverity.ERROR,
|
|
name="Trailing newline",
|
|
original=original,
|
|
replacement=original.rstrip("\n") + "\n",
|
|
description="Trailing newline found. Run `lintrunner --take NEWLINE -a` to apply changes.",
|
|
)
|
|
has_changes = False
|
|
original_lines: Optional[List[bytes]] = None
|
|
for idx, line in enumerate(lines):
|
|
if len(line) >= 2 and line[-1] == NEWLINE and line[-2] == CARRIAGE_RETURN:
|
|
if not has_changes:
|
|
original_lines = list(lines)
|
|
has_changes = True
|
|
lines[idx] = line[:-2] + b"\n"
|
|
|
|
if has_changes:
|
|
try:
|
|
assert original_lines is not None
|
|
original = b"".join(original_lines).decode("utf-8")
|
|
replacement = b"".join(lines).decode("utf-8")
|
|
except Exception as err:
|
|
return LintMessage(
|
|
path=filename,
|
|
line=None,
|
|
char=None,
|
|
code=LINTER_CODE,
|
|
severity=LintSeverity.ERROR,
|
|
name="Decoding failure",
|
|
original=None,
|
|
replacement=None,
|
|
description=f"utf-8 decoding failed due to {err.__class__.__name__}:\n{err}",
|
|
)
|
|
return LintMessage(
|
|
path=filename,
|
|
line=None,
|
|
char=None,
|
|
code=LINTER_CODE,
|
|
severity=LintSeverity.ERROR,
|
|
name="DOS newline",
|
|
original=original,
|
|
replacement=replacement,
|
|
description="DOS newline found. Run `lintrunner --take NEWLINE -a` to apply changes.",
|
|
)
|
|
|
|
return None
|
|
|
|
|
|
if __name__ == "__main__":
|
|
parser = argparse.ArgumentParser(
|
|
description="native functions linter",
|
|
fromfile_prefix_chars="@",
|
|
)
|
|
parser.add_argument(
|
|
"--verbose",
|
|
action="store_true",
|
|
help="location of native_functions.yaml",
|
|
)
|
|
parser.add_argument(
|
|
"filenames",
|
|
nargs="+",
|
|
help="paths to lint",
|
|
)
|
|
|
|
args = parser.parse_args()
|
|
|
|
logging.basicConfig(
|
|
format="<%(threadName)s:%(levelname)s> %(message)s",
|
|
level=logging.NOTSET
|
|
if args.verbose
|
|
else logging.DEBUG
|
|
if len(args.filenames) < 1000
|
|
else logging.INFO,
|
|
stream=sys.stderr,
|
|
)
|
|
|
|
lint_messages = []
|
|
for filename in args.filenames:
|
|
lint_message = check_file(filename)
|
|
if lint_message is not None:
|
|
lint_messages.append(lint_message)
|
|
|
|
for lint_message in lint_messages:
|
|
print(json.dumps(lint_message._asdict()), flush=True)
|