pytorch/c10/test/util/registry_test.cpp
Nikita Shulga a9b0a921d5 Disable avoid-non-const-global-variables lint check (#62008)
Summary:
As GoogleTest `TEST` macro is non-compliant with it as well as `DEFINE_DISPATCH`

All changes but the ones to `.clang-tidy` are generated using following script:
```
for i in `find . -type f -iname "*.c*" -or -iname "*.h"|xargs grep cppcoreguidelines-avoid-non-const-global-variables|cut -f1 -d:|sort|uniq`;  do sed -i "/\/\/ NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)/d" $i; done
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/62008

Reviewed By: driazati, r-barnes

Differential Revision: D29838584

Pulled By: malfet

fbshipit-source-id: 1b2f8602c945bd4ce50a9bfdd204755556e31d13
2021-07-22 18:04:40 -07:00

93 lines
2.6 KiB
C++

#include <gtest/gtest.h>
#include <iostream>
#include <memory>
#include <c10/util/Registry.h>
// Note: we use a different namespace to test if the macros defined in
// Registry.h actually works with a different namespace from c10.
namespace c10_test {
class Foo {
public:
explicit Foo(int x) {
// LOG(INFO) << "Foo " << x;
}
virtual ~Foo() = default;
};
C10_DECLARE_REGISTRY(FooRegistry, Foo, int);
C10_DEFINE_REGISTRY(FooRegistry, Foo, int);
#define REGISTER_FOO(clsname) C10_REGISTER_CLASS(FooRegistry, clsname, clsname)
class Bar : public Foo {
public:
explicit Bar(int x) : Foo(x) {
// LOG(INFO) << "Bar " << x;
}
};
REGISTER_FOO(Bar);
class AnotherBar : public Foo {
public:
explicit AnotherBar(int x) : Foo(x) {
// LOG(INFO) << "AnotherBar " << x;
}
};
REGISTER_FOO(AnotherBar);
TEST(RegistryTest, CanRunCreator) {
std::unique_ptr<Foo> bar(FooRegistry()->Create("Bar", 1));
EXPECT_TRUE(bar != nullptr) << "Cannot create bar.";
std::unique_ptr<Foo> another_bar(FooRegistry()->Create("AnotherBar", 1));
EXPECT_TRUE(another_bar != nullptr);
}
TEST(RegistryTest, ReturnNullOnNonExistingCreator) {
EXPECT_EQ(FooRegistry()->Create("Non-existing bar", 1), nullptr);
}
// C10_REGISTER_CLASS_WITH_PRIORITY defines static variable
void RegisterFooDefault() {
C10_REGISTER_CLASS_WITH_PRIORITY(
FooRegistry, FooWithPriority, c10::REGISTRY_DEFAULT, Foo);
}
void RegisterFooDefaultAgain() {
C10_REGISTER_CLASS_WITH_PRIORITY(
FooRegistry, FooWithPriority, c10::REGISTRY_DEFAULT, Foo);
}
void RegisterFooBarFallback() {
C10_REGISTER_CLASS_WITH_PRIORITY(
FooRegistry, FooWithPriority, c10::REGISTRY_FALLBACK, Bar);
}
void RegisterFooBarPreferred() {
C10_REGISTER_CLASS_WITH_PRIORITY(
FooRegistry, FooWithPriority, c10::REGISTRY_PREFERRED, Bar);
}
TEST(RegistryTest, RegistryPriorities) {
FooRegistry()->SetTerminate(false);
RegisterFooDefault();
// throws because Foo is already registered with default priority
// NOLINTNEXTLINE(hicpp-avoid-goto,cppcoreguidelines-avoid-goto)
EXPECT_THROW(RegisterFooDefaultAgain(), std::runtime_error);
#ifdef __GXX_RTTI
// not going to register Bar because Foo is registered with Default priority
RegisterFooBarFallback();
std::unique_ptr<Foo> bar1(FooRegistry()->Create("FooWithPriority", 1));
EXPECT_EQ(dynamic_cast<Bar*>(bar1.get()), nullptr);
// will register Bar because of higher priority
RegisterFooBarPreferred();
std::unique_ptr<Foo> bar2(FooRegistry()->Create("FooWithPriority", 1));
EXPECT_NE(dynamic_cast<Bar*>(bar2.get()), nullptr);
#endif
}
} // namespace c10_test