mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-07 12:21:27 +01:00
4cb534f92e
Summary:
This is an automatic change generated by the following script:
```
#!/usr/bin/env python3
from subprocess import check_output, check_call
import os
def get_compiled_files_list():
import json
with open("build/compile_commands.json") as f:
data = json.load(f)
files = [os.path.relpath(node['file']) for node in data]
for idx, fname in enumerate(files):
if fname.startswith('build/') and fname.endswith('.DEFAULT.cpp'):
files[idx] = fname[len('build/'):-len('.DEFAULT.cpp')]
return files
def run_clang_tidy(fname):
check_call(["python3", "tools/clang_tidy.py", "-c", "build", "-x", fname,"-s"])
changes = check_output(["git", "ls-files", "-m"])
if len(changes) == 0:
return
check_call(["git", "commit","--all", "-m", f"NOLINT stubs for {fname}"])
def main():
git_files = check_output(["git", "ls-files"]).decode("ascii").split("\n")
compiled_files = get_compiled_files_list()
for idx, fname in enumerate(git_files):
if fname not in compiled_files:
continue
if fname.startswith("caffe2/contrib/aten/"):
continue
print(f"[{idx}/{len(git_files)}] Processing {fname}")
run_clang_tidy(fname)
if __name__ == "__main__":
main()
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56892
Reviewed By: H-Huang
Differential Revision: D27991944
Pulled By: malfet
fbshipit-source-id: 5415e1eb2c1b34319a4f03024bfaa087007d7179
43 lines
1.3 KiB
C++
43 lines
1.3 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <torch/csrc/utils/memory.h>
|
|
|
|
#include <c10/util/Optional.h>
|
|
|
|
struct TestValue {
|
|
explicit TestValue(const int& x) : lvalue_(x) {}
|
|
explicit TestValue(int&& x) : rvalue_(x) {}
|
|
|
|
c10::optional<int> lvalue_;
|
|
c10::optional<int> rvalue_;
|
|
};
|
|
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
|
|
TEST(MakeUniqueTest, ForwardRvaluesCorrectly) {
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-magic-numbers)
|
|
auto ptr = torch::make_unique<TestValue>(123);
|
|
ASSERT_FALSE(ptr->lvalue_.has_value());
|
|
ASSERT_TRUE(ptr->rvalue_.has_value());
|
|
ASSERT_EQ(*ptr->rvalue_, 123);
|
|
}
|
|
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
|
|
TEST(MakeUniqueTest, ForwardLvaluesCorrectly) {
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-magic-numbers)
|
|
int x = 5;
|
|
auto ptr = torch::make_unique<TestValue>(x);
|
|
ASSERT_TRUE(ptr->lvalue_.has_value());
|
|
ASSERT_EQ(*ptr->lvalue_, 5);
|
|
ASSERT_FALSE(ptr->rvalue_.has_value());
|
|
}
|
|
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
|
|
TEST(MakeUniqueTest, CanConstructUniquePtrOfArray) {
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
|
|
auto ptr = torch::make_unique<int[]>(3);
|
|
// Value initialization is required by the standard.
|
|
ASSERT_EQ(ptr[0], 0);
|
|
ASSERT_EQ(ptr[1], 0);
|
|
ASSERT_EQ(ptr[2], 0);
|
|
}
|