pytorch/torch
Peter Goldsborough 01c7542f43 Use -isystem for system includes in C++ extensions (#11459)
Summary:
I noticed warnings from within pybind11 being shown when building C++ extensions. This can be avoided by including non-user-supplied headers with `-isystem` instead of `-I`

I hope this works on Windows.

soumith ezyang
Pull Request resolved: https://github.com/pytorch/pytorch/pull/11459

Differential Revision: D9764444

Pulled By: goldsborough

fbshipit-source-id: b288572106078f347f0342f158f9e2b63a58c235
2018-09-11 10:40:20 -07:00
..
_thnn Update from Facebook (#8887) 2018-06-26 14:55:48 -07:00
autograd Document torch.allclose (#11185) 2018-09-02 09:26:07 -07:00
backends Also set stdin to subprocess pipe in FindCUDNN windows popen call (#11435) 2018-09-09 11:40:25 -07:00
contrib Add code for TensorBoard visualization of JIT GraphExecutors (#8050) 2018-06-02 20:55:25 +02:00
csrc Bugfix for basic slicing 2018-09-11 09:39:29 -07:00
cuda Make torch.cuda.* take device objects; Update distributed docs (#10833) 2018-08-27 15:24:42 -07:00
distributed C10d release to torch.distributed for PT1 (#11405) 2018-09-10 23:27:22 -07:00
distributions Add .expand() method to distribution classes (#11341) 2018-09-11 06:56:18 -07:00
for_onnx Codemod Toffee -> ONNX, toffee -> onnx. Change file names to match 2017-09-06 13:45:39 -04:00
jit Add initial documentation for JIT (#11357) 2018-09-07 14:27:47 -07:00
legacy check attribute existence in torch.legay.nn.SpatialFullConvolution in method type (#8740) 2018-08-14 10:11:13 -07:00
lib bumping up the default store timeout (#11409) 2018-09-07 23:55:23 -07:00
multiprocessing Don't call into Python during Storage destruction. (#10407) 2018-08-13 11:20:07 -07:00
nn Improvements on conv/pool/fold/stft/ParamDict docs (#11106) 2018-09-11 08:56:21 -07:00
onnx Improve support for tracing sizes, add more tracer warnings (#11288) 2018-09-10 15:22:48 -07:00
optim Remove methods that start with an underscore from at::Tensor (#11152) 2018-09-07 11:55:11 -07:00
sparse Delete dead Tensor code paths (#5417) 2018-02-27 17:58:09 -05:00
testing Codemod to update our codebase to 0.4 standard (#6641) 2018-04-17 22:06:54 -04:00
utils Use -isystem for system includes in C++ extensions (#11459) 2018-09-11 10:40:20 -07:00
__init__.py Fix dir(torch) for python 3.7 (#10271) 2018-08-07 09:57:51 -07:00
_ops.py Resolve builtins using a dict rather than by name (#10927) 2018-08-28 11:25:11 -07:00
_six.py Use _six for inf and nan (#9500) 2018-07-18 10:40:29 -07:00
_storage_docs.py [ready] General documentation improvements (#5450) 2018-03-08 13:21:12 -05:00
_tensor_docs.py Improvements on conv/pool/fold/stft/ParamDict docs (#11106) 2018-09-11 08:56:21 -07:00
_tensor_str.py Sparse tensor printing; add NotImplemented autograd fn (#10181) 2018-09-05 19:41:22 -07:00
_torch_docs.py Improvements on conv/pool/fold/stft/ParamDict docs (#11106) 2018-09-11 08:56:21 -07:00
_utils_internal.py Build system changes (#8627) 2018-06-20 17:45:26 -04:00
_utils.py Remove methods that start with an underscore from at::Tensor (#11152) 2018-09-07 11:55:11 -07:00
CMakeLists.txt Lockdown NO_TEST=1 for tests even more (#11415) 2018-09-10 17:27:48 -07:00
functional.py Improvements on conv/pool/fold/stft/ParamDict docs (#11106) 2018-09-11 08:56:21 -07:00
op.h Integrate custom op tests with CI (#10611) 2018-09-10 15:40:21 -07:00
random.py [ready] General documentation improvements (#5450) 2018-03-08 13:21:12 -05:00
README.txt Make all of TH and THC C++. (#6913) 2018-04-28 07:45:02 -04:00
serialization.py Reimplement storage slicing. (#11314) 2018-09-06 16:11:59 -07:00
storage.py Use torch.save in _StorageBase.__reduce__ (#9184) 2018-07-06 07:24:53 -07:00
tensor.py Remove methods that start with an underscore from at::Tensor (#11152) 2018-09-07 11:55:11 -07:00

Note [TH abstraction violation]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

TH/THC provide some hpp headers, which are proper C++ headers rather than
C headers.  These headers serve double duty as *internal implementation
detail* headers, whose contents should largely not be used by external
clients.

Ideally, we would not install these headers at all; instead, you should
use public functions (in headers like `THTensor.h`, NOT `THTensor.hpp`)
to manipulate these structs.  However, there are a few places
in torch/csrc where we violate this abstraction.  They are marked with
a pointer to this note.  Each of those sites will have to be refactored
when we refactor the guts of THTensor and related structures.