Akihiro Nitta f17d7a5556 Fix exception chaining in torch/ (#43836) ... Summary: ## Motivation Fixes https://github.com/pytorch/pytorch/issues/43770. ## Description of the change This PR fixes exception chaining only in files under `torch/` where appropriate. To fix exception chaining, I used either: 1. `raise new_exception from old_exception` where `new_exception` itself seems not descriptive enough to debug or `old_exception` delivers valuable information. 2. `raise new_exception from None` where raising both of `new_exception` and `old_exception` seems a bit noisy and redundant. I subjectively chose which one to use from the above options. ## List of lines containing raise in except clause: I wrote [this simple script](https://gist.github.com/akihironitta/4223c1b32404b36c1b349d70c4c93b4d) using [ast](https://docs.python.org/3.8/library/ast.html#module-ast) to list lines where `raise`ing in `except` clause. - [x] 000739c31a/torch/jit/annotations.py (L35) - [x] 000739c31a/torch/jit/annotations.py (L150) - [x] 000739c31a/torch/jit/annotations.py (L158) - [x] 000739c31a/torch/jit/annotations.py (L231) - [x] 000739c31a/torch/jit/_trace.py (L432) - [x] 000739c31a/torch/nn/utils/prune.py (L192) - [x] 000739c31a/torch/cuda/nvtx.py (L7) - [x] 000739c31a/torch/utils/cpp_extension.py (L1537) - [x] 000739c31a/torch/utils/tensorboard/_pytorch_graph.py (L292) - [x] 000739c31a/torch/utils/data/dataloader.py (L835) - [x] 000739c31a/torch/utils/data/dataloader.py (L849) - [x] 000739c31a/torch/utils/data/dataloader.py (L856) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L186) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L189) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L424) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L1279) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L1283) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L1356) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L1388) - [x] 000739c31a/torch/testing/_internal/common_utils.py (L1391) - [ ] 000739c31a/torch/testing/_internal/common_utils.py (L1412) - [x] 000739c31a/torch/testing/_internal/codegen/random_topo_test.py (L310) - [x] 000739c31a/torch/testing/_internal/codegen/random_topo_test.py (L329) - [x] 000739c31a/torch/testing/_internal/codegen/random_topo_test.py (L332) - [x] 000739c31a/torch/testing/_internal/jit_utils.py (L183) - [x] 000739c31a/torch/testing/_internal/common_nn.py (L4789) - [x] 000739c31a/torch/onnx/utils.py (L367) - [x] 000739c31a/torch/onnx/utils.py (L659) - [x] 000739c31a/torch/onnx/utils.py (L892) - [x] 000739c31a/torch/onnx/utils.py (L897) - [x] 000739c31a/torch/serialization.py (L108) - [x] 000739c31a/torch/serialization.py (L754) - [x] 000739c31a/torch/distributed/rpc/_testing/faulty_agent_backend_registry.py (L76) - [x] 000739c31a/torch/distributed/rpc/backend_registry.py (L260) - [x] 000739c31a/torch/distributed/distributed_c10d.py (L184) - [x] 000739c31a/torch/_utils_internal.py (L57) - [x] 000739c31a/torch/hub.py (L494) - [x] 000739c31a/torch/contrib/_tensorboard_vis.py (L16) - [x] 000739c31a/torch/distributions/lowrank_multivariate_normal.py (L100) - [x] 000739c31a/torch/distributions/constraint_registry.py (L142) Pull Request resolved: https://github.com/pytorch/pytorch/pull/43836 Reviewed By: ailzhang Differential Revision: D23431212 Pulled By: malfet fbshipit-source-id: 5f7f41b391164a5ad0efc06e55cd58c23408a921		2020-08-31 20:26:23 -07:00
..
__init__.py	remediation of S205607	2020-07-17 17:19:47 -07:00
_tensorboard_vis.py	Fix exception chaining in torch/ (#43836)	2020-08-31 20:26:23 -07:00