PyTorch MergeBot
4557f6e339
Revert "[Dynamo] Disable torch function compilation during guard execution and in compiled bytecode ( #137669 )"
...
This reverts commit bf0b670598https://github.com/pytorch/pytorch/pull/137669 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but it is failing test_public_bindings in trunk, maybe a landrace ([comment](https://github.com/pytorch/pytorch/pull/137669#issuecomment-2415331274 ))
2024-10-15 23:22:58 +00:00
Michael Lazos
bf0b670598
[Dynamo] Disable torch function compilation during guard execution and in compiled bytecode ( #137669 )
...
Fixes https://github.com/pytorch/pytorch/issues/114369
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137669
Approved by: https://github.com/anijain2305
2024-10-15 20:52:58 +00:00
eellison
8543000c27
Search through config changes in compiler bisector ( #137346 )
...
Follow up to https://github.com/pytorch/pytorch/pull/131936 . In the original bisector you'd have to test inline if we were disabling a component - `if BisectionManager.disable_subsystem("inductor", "post_grad_passes", debug_info)`. This adds a convenient way of testing config changes for root causing issue. I've added `emulate_precision_casts` and aot_eager_decomp_partition cse as initial ones.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137346
Approved by: https://github.com/zou3519
2024-10-11 20:24:54 +00:00
Kurt Mohler
383eba5229
Add deterministic path for CUDA cumsum ( #136224 )
...
Change `cumsum` to call its decomposition when `use_deterministic_algorithms(True)` and input is CUDA.
Fixes #89492
Fixes #75240
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136224
Approved by: https://github.com/ezyang , https://github.com/justinchuby , https://github.com/eqy
2024-10-10 06:59:08 +00:00
eellison
47af7cc962
Add compiler bisector ( #131936 )
...
This is a utility to aid the torch.compile debugging. You provide a function that returns True on success, False on failure, or do something out of process and run bisect_helper `good | bad`.
The bisector will first go through backends - `eager`, `aot_eager`, `aot_eager_decomp_partition`, `inductor` to find the first failing backend. Then, it will go through subsystems within the backend - currently limited but could be expanded - and try to find the first subsystem for which disabling fixes the problem. Once it has found the failing subsystem, it will find the number of times the subsystem is applied, and then bisect through it.
An example usage of how to hook it up for aot_eager_decomp_partition and decomposition subsystem is :
```
from torch._inductor.bisect_helper import BisectionManager
if op in CURRENT_DECOMPOSITION_TABLE:
if BisectionManager.disable_subsystem("aot_eager_decomp_partition", "decomposition", lambda: repr(op)):
return NotImplemented
```
Once it has discovered the problematic change, it will print out the associated debug info, and you can set the same limits with `TORCH_BISECT_BACKEND` `TORCH_BISECT_SUBSYSTEM` and `TORCH_BISECT_MAX`.
We could add further options as an automated way of going through a check list for checking divergence - e.g., the mode to emulate amp casts.
Fix for https://github.com/pytorch/pytorch/issues/126546
Pull Request resolved: https://github.com/pytorch/pytorch/pull/131936
Approved by: https://github.com/ezyang
2024-10-09 20:34:11 +00:00
PyTorch MergeBot
16a2c2cfd4
Revert "Introduce torch.sym_sum ( #136429 )"
...
This reverts commit 90bed32b98https://github.com/pytorch/pytorch/pull/136429 on behalf of https://github.com/ezyang due to fails internal stuff ([comment](https://github.com/pytorch/pytorch/pull/136429#issuecomment-2403335147 ))
2024-10-09 20:08:01 +00:00
Edward Z. Yang
90bed32b98
Introduce torch.sym_sum ( #136429 )
...
Partially addresses https://github.com/pytorch/pytorch/issues/128150
When you have big sums of values, we end up computing long chains of
binary addition in our FX graph representation. Not only is this ugly,
it also is quadratic, as the sympy.Add constructor is O(N) in number
of arguments. Instead, ensure that we maintain the summation as a
single FX node so we can do the entire addition all in one go.
update_hint_regression benchmark, before and after:
```
update_hint_regression,compile_time_instruction_count,2648328980
update_hint_regression,compile_time_instruction_count,2563748678
```
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136429
Approved by: https://github.com/isuruf
2024-10-08 18:12:57 +00:00
Edward Z. Yang
6bd9d37266
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes ( #137019 )
...
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137019
Approved by: https://github.com/Skylion007
ghstack dependencies: #136934 , #136935 , #136972
2024-10-01 13:22:10 +00:00
PyTorch MergeBot
e9d2765ec8
Revert "Add deterministic path for CUDA cumsum ( #136224 )"
...
This reverts commit d1bb8e828fhttps://github.com/pytorch/pytorch/pull/136224 on behalf of https://github.com/atalman due to Break internal CI ([comment](https://github.com/pytorch/pytorch/pull/136224#issuecomment-2379214226 ))
2024-09-27 12:54:47 +00:00
Edward Z. Yang
beb46de342
Correctly convert Python float to float64 when passing argument as Tensor ( #136413 )
...
I can't actually test the Dynamo codegen fix as it is impossible to
directly use the Tensor at the moment.
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136413
Approved by: https://github.com/bobrenjc93
ghstack dependencies: #136599
2024-09-26 16:50:13 +00:00
Kurt Mohler
d1bb8e828f
Add deterministic path for CUDA cumsum ( #136224 )
...
Change `cumsum` to call its decomposition when `use_deterministic_algorithms(True)` and input is CUDA.
Fixes #89492
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136224
Approved by: https://github.com/ezyang , https://github.com/justinchuby
2024-09-26 04:52:05 +00:00
PyTorch MergeBot
e3b89ca124
Revert "Add deterministic path for CUDA cumsum ( #136224 )"
...
This reverts commit b1a02bf708https://github.com/pytorch/pytorch/pull/136224 on behalf of https://github.com/ezyang due to Failing internall CI ([comment](https://github.com/pytorch/pytorch/pull/136224#issuecomment-2374201626 ))
2024-09-25 14:11:01 +00:00
Kurt Mohler
b1a02bf708
Add deterministic path for CUDA cumsum ( #136224 )
...
Change `cumsum` to call its decomposition when `use_deterministic_algorithms(True)` and input is CUDA.
Fixes #89492
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136224
Approved by: https://github.com/ezyang , https://github.com/justinchuby
2024-09-24 21:34:43 +00:00
PyTorch MergeBot
0133fbcfe7
Revert "Correctly convert Python float to float64 when passing argument as Tensor ( #136413 )"
...
This reverts commit f0f79dd8f1https://github.com/pytorch/pytorch/pull/136413 on behalf of https://github.com/ezyang due to forward fix is stuck, revert this ([comment](https://github.com/pytorch/pytorch/pull/136413#issuecomment-2372404873 ))
2024-09-24 21:20:37 +00:00
PyTorch MergeBot
fd182b90a7
Revert "Add deterministic path for CUDA cumsum ( #136224 )"
...
This reverts commit d45b0151e5https://github.com/pytorch/pytorch/pull/136224 on behalf of https://github.com/atalman due to Failing internall CI ([comment](https://github.com/pytorch/pytorch/pull/136224#issuecomment-2369244135 ))
2024-09-23 19:57:13 +00:00
Edward Z. Yang
f0f79dd8f1
Correctly convert Python float to float64 when passing argument as Tensor ( #136413 )
...
I can't actually test the Dynamo codegen fix as it is impossible to
directly use the Tensor at the moment.
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136413
Approved by: https://github.com/bobrenjc93
2024-09-23 16:48:08 +00:00
Kurt Mohler
d45b0151e5
Add deterministic path for CUDA cumsum ( #136224 )
...
Change `cumsum` to call its decomposition when `use_deterministic_algorithms(True)` and input is CUDA.
Fixes #89492
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136224
Approved by: https://github.com/ezyang , https://github.com/justinchuby
2024-09-20 02:41:56 +00:00
Wu, Chunyuan
18479c5f70
[Doc] update max-autotune for CPU ( #134986 )
...
The current doc for `max-autotune` is applicable only for GPU. This PR adds the corresponding content for CPU.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/134986
Approved by: https://github.com/jgong5 , https://github.com/malfet
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
2024-09-07 13:42:40 +00:00
Animesh Jain
9e6f4f3f77
[dynamo] Use __eq__ for backend match ( #135039 )
...
Fixes https://github.com/pytorch/pytorch/issues/131150
Pull Request resolved: https://github.com/pytorch/pytorch/pull/135039
Approved by: https://github.com/jansel
2024-09-04 03:35:18 +00:00
PyTorch MergeBot
2db28a9611
Revert "[BE]: Update Typeguard to TypeIs for better type inference ( #133814 )"
...
This reverts commit bce0caba78https://github.com/pytorch/pytorch/pull/133814 on behalf of https://github.com/ezyang due to root cause of internal failures not addressed ([comment](https://github.com/pytorch/pytorch/pull/133814#issuecomment-2302466444 ))
2024-08-21 16:13:34 +00:00
Aaron Gokaslan
bce0caba78
[BE]: Update Typeguard to TypeIs for better type inference ( #133814 )
...
Uses TypeIs instead of TypeGuard for better inference. See https://peps.python.org/pep-0742/
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133814
Approved by: https://github.com/ezyang
2024-08-20 17:19:57 +00:00
Nikita Shulga
f2b57d8831
Fix torch._C submodules population ( #133919 )
...
This fixes regression introduced by https://github.com/pytorch/pytorch/pull/132216 that on some Python runtimes failed with
```
> from torch._C._dynamo.guards import GlobalStateGuard
E ModuleNotFoundError: No module named 'torch._C._dynamo.guards'; 'torch._C._dynamo' is not a package
c:\users\malfet\git\pytorch\torch\_dynamo\convert_frame.py:28: ModuleNotFoundError
```
Simplify it by always registering submodules by its primary name and do not try to add submodules which are not part of the same namespace as parent. Otherwise module can be registered by alias, rather than by primary name.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133919
Approved by: https://github.com/atalman , https://github.com/izaitsevfb , https://github.com/XuehaiPan , https://github.com/albanD , https://github.com/Skylion007
2024-08-20 15:38:32 +00:00
PyTorch MergeBot
42097f0ec1
Revert "[BE]: Update Typeguard to TypeIs for better type inference ( #133814 )"
...
This reverts commit cf60fe53a8https://github.com/pytorch/pytorch/pull/133814 on behalf of https://github.com/jeanschmidt due to Broke 12k internal signals/jobs, @ezyang please help get those changes merged. More details check D61488368 ([comment](https://github.com/pytorch/pytorch/pull/133814#issuecomment-2298210309 ))
2024-08-20 08:02:49 +00:00
Aaron Gokaslan
cf60fe53a8
[BE]: Update Typeguard to TypeIs for better type inference ( #133814 )
...
Uses TypeIs instead of TypeGuard for better inference. See https://peps.python.org/pep-0742/
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133814
Approved by: https://github.com/ezyang
2024-08-18 19:10:16 +00:00
Mikayla Gawarecki
018e48c337
[Reland] Add wrappers for synchronous GPUDirect Storage APIs ( #133489 )
...
Reland #130633
USE_CUFILE turned off by default in this version
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133489
Approved by: https://github.com/albanD
2024-08-15 17:11:52 +00:00
Xuehai Pan
24dee99cb7
Populate submodules of torch._C to sys.modules recursively ( #132216 )
...
See comment:
e9d1c26275/torch/__init__.py (L938-L950)https://github.com/pytorch/pytorch/pull/132216
Approved by: https://github.com/ezyang
2024-08-08 10:20:25 +00:00
PyTorch MergeBot
ff81ca8e0c
Revert "Populate submodules of torch._C to sys.modules recursively ( #132216 )"
...
This reverts commit 672ce4610ehttps://github.com/pytorch/pytorch/pull/132216 on behalf of https://github.com/PaliC due to was breaking internal builds ([comment](https://github.com/pytorch/pytorch/pull/132216#issuecomment-2274112397 ))
2024-08-07 18:45:00 +00:00
PyTorch MergeBot
1749025081
Revert "Fix infinite recursion while walking to submodules ( #132763 )"
...
This reverts commit 063a45ed27https://github.com/pytorch/pytorch/pull/132763 on behalf of https://github.com/PaliC due to We need to now revert https://github.com/pytorch/pytorch/pull/132216 in OSS and there is a dependency on this pr ([comment](https://github.com/pytorch/pytorch/pull/132763#issuecomment-2274059792 ))
2024-08-07 18:20:27 +00:00
Xuehai Pan
063a45ed27
Fix infinite recursion while walking to submodules ( #132763 )
...
Fixes https://github.com/pytorch/pytorch/pull/132216#issuecomment-2271555873
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132763
Approved by: https://github.com/ezyang
2024-08-07 02:20:17 +00:00
Xuehai Pan
4226ed1585
[BE] Format uncategorized Python files with ruff format ( #132576 )
...
Remove patterns `**`, `test/**`, and `torch/**` in `tools/linter/adapters/pyfmt_linter.py` and run `lintrunner`.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132576
Approved by: https://github.com/ezyang , https://github.com/Skylion007
ghstack dependencies: #132574
2024-08-04 17:13:31 +00:00
Xuehai Pan
672ce4610e
Populate submodules of torch._C to sys.modules recursively ( #132216 )
...
See comment:
e9d1c26275/torch/__init__.py (L938-L950)https://github.com/pytorch/pytorch/pull/132216
Approved by: https://github.com/ezyang
2024-08-01 12:04:59 +00:00
Xuehai Pan
e7eeee473c
[BE][Easy][14/19] enforce style for empty lines in import segments in torch/_[a-c]*/ and torch/_[e-h]*/ and torch/_[j-z]*/ ( #129765 )
...
See https://github.com/pytorch/pytorch/pull/129751#issue-2380881501 . Most changes are auto-generated by linter.
You can review these PRs via:
```bash
git diff --ignore-all-space --ignore-blank-lines HEAD~1
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129765
Approved by: https://github.com/ezyang
2024-07-31 10:42:50 +00:00
Yanbo Liang
3c1562158e
[BE] Fix torch.compile docstring formatting issues ( #131837 )
...
Fixes #131815
<img width="1098" alt="Screenshot 2024-07-25 at 6 58 39 PM" src="https://github.com/user-attachments/assets/d0f6edc3-419e-4096-803b-cecd45d8644b ">
Pull Request resolved: https://github.com/pytorch/pytorch/pull/131837
Approved by: https://github.com/williamwen42
2024-07-29 20:52:28 +00:00
PyTorch MergeBot
e191b83462
Revert "Add wrappers for synchronous GPUDirect Storage APIs ( #130633 )"
...
This reverts commit 709ddf7a9dhttps://github.com/pytorch/pytorch/pull/130633 on behalf of https://github.com/clee2000 due to still failing internally D60265673 ([comment](https://github.com/pytorch/pytorch/pull/130633#issuecomment-2253239607 ))
2024-07-26 18:08:20 +00:00
Mikayla Gawarecki
709ddf7a9d
Add wrappers for synchronous GPUDirect Storage APIs ( #130633 )
...
Based in part on https://github.com/NVIDIA/apex/pull/1774
Differential Revision: [D60155434](https://our.internmc.facebook.com/intern/diff/D60155434 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130633
Approved by: https://github.com/albanD
2024-07-25 22:23:38 +00:00
PyTorch MergeBot
e4b5645f83
Revert "Add wrappers for synchronous GPUDirect Storage APIs ( #130633 )"
...
This reverts commit 5b5e0698a5https://github.com/pytorch/pytorch/pull/130633 on behalf of https://github.com/clee2000 due to breaking a lot of jobs and build rules internally D60085885, possibly needs to update some bazel build? ([comment](https://github.com/pytorch/pytorch/pull/130633#issuecomment-2245806738 ))
2024-07-23 17:19:34 +00:00
nikonikolov
781189f25d
Add nvjitlink to the list of loadable global deps ( #131295 )
...
To fix the cusparse dependency resolution in CUDA-12.x, that has nvJitLink dependency:
```
$ ldd -r /usr/local/cuda-11.8/lib64/libcusparse.so.11.7.5.86
linux-vdso.so.1 (0x00007ffea6f51000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fb13306f000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fb133065000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fb13305f000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fb132f10000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fb132eeb000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fb132cf7000)
/lib64/ld-linux-x86-64.so.2 (0x00007fb143db7000)
$ ldd -r /usr/local/cuda-12.1/lib64/libcusparse.so.12.1.0.106
linux-vdso.so.1 (0x00007ffc41909000)
libnvJitLink.so.12 => /usr/local/cuda-12.1/lib64/libnvJitLink.so.12 (0x00007f3916b38000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f3916aea000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f3916ae0000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f3916ada000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f391698b000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f3916964000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f3916772000)
/lib64/ld-linux-x86-64.so.2 (0x00007f3929a8c000)
```
Fixes #131284
Pull Request resolved: https://github.com/pytorch/pytorch/pull/131295
Approved by: https://github.com/malfet
2024-07-23 04:26:33 +00:00
Mikayla Gawarecki
5b5e0698a5
Add wrappers for synchronous GPUDirect Storage APIs ( #130633 )
...
Based in part on https://github.com/NVIDIA/apex/pull/1774
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130633
Approved by: https://github.com/albanD
2024-07-22 14:51:24 +00:00
Edward Z. Yang
408c921d96
Make hashing a SymInt raise an error again ( #130548 )
...
See https://github.com/pytorch/pytorch/issues/130547
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130548
Approved by: https://github.com/Skylion007 , https://github.com/albanD , https://github.com/lezcano
2024-07-16 18:30:30 +00:00
Aaron Orenstein
567482973d
typing fake_tensor.py ( #128041 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128041
Approved by: https://github.com/eellison
ghstack dependencies: #129182
2024-07-13 06:07:40 +00:00
Bertrand Thia
43b98fa521
Add debug repr to SymNode ( #129925 )
...
Fixes #129403
Create a separate printing function to debug SymNode, since we can't easily change `__repr__` that is used by GraphModule.recompile() to create a pythonic version of a graph
This is my first contribution, please let me know if there is anything that I should look into in further details
Thank you for you guidance! 🙏 I hope to contribute more in the future!
@aorenste
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129925
Approved by: https://github.com/aorenste
2024-07-12 18:31:23 +00:00
Tom Ritchford
b0a597fcb4
Fix #121334 : graph break on constant method call ( #130158 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130158
Approved by: https://github.com/lezcano
2024-07-12 17:34:46 +00:00
PyTorch MergeBot
2b1df24877
Revert "Make hashing a SymInt raise an error again ( #130548 )"
...
This reverts commit 3100455b8ehttps://github.com/pytorch/pytorch/pull/130548 on behalf of https://github.com/clee2000 due to broke inductor/test_triton_kernels.py https://github.com/pytorch/pytorch/actions/runs/9908970127/job/27377960411 3100455b8ehttps://github.com/pytorch/pytorch/pull/130548#issuecomment-2225912018 ))
2024-07-12 16:20:12 +00:00
Edward Z. Yang
3100455b8e
Make hashing a SymInt raise an error again ( #130548 )
...
See https://github.com/pytorch/pytorch/issues/130547
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130548
Approved by: https://github.com/Skylion007 , https://github.com/albanD
2024-07-12 13:49:56 +00:00
Xuehai Pan
973037be6a
[BE][Easy] apply autofix for ruff rules unnecessary-collection-call (C408): list() / tuple() / dict() ( #130199 )
...
This PR changes the empty collection factory call to Python literals:
- `list()` -> `[]`
- `tuple()` -> `()`
- `dict()` -> `{}`
The Python literals are more performant and safer. For example, the bytecode for building an empty dictionary:
```bash
$ python3 -m dis - <<EOS
import collections
d1 = {}
d2 = dict()
dict = collections.OrderedDict
d3 = dict()
EOS
```
```text
0 0 RESUME 0
1 2 LOAD_CONST 0 (0)
4 LOAD_CONST 1 (None)
6 IMPORT_NAME 0 (collections)
8 STORE_NAME 0 (collections)
3 10 BUILD_MAP 0
12 STORE_NAME 1 (d1)
4 14 PUSH_NULL
16 LOAD_NAME 2 (dict)
18 CALL 0
26 STORE_NAME 3 (d2)
6 28 LOAD_NAME 0 (collections)
30 LOAD_ATTR 8 (OrderedDict)
50 STORE_NAME 2 (dict)
7 52 PUSH_NULL
54 LOAD_NAME 2 (dict)
56 CALL 0
64 STORE_NAME 5 (d3)
66 RETURN_CONST 1 (None)
```
The dict literal `{}` only has one bytecode `BUILD_MAP`, while the factory call `dict()` has three `PUSH_NULL + LOAD_NAME + CALL`. Also, the factory call is not safe if users override the `dict` name in `locals` or `globals` (see the example of replacing with `OrderedDict` above).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130199
Approved by: https://github.com/malfet
2024-07-11 17:30:28 +00:00
Yuanhao Ji
312652c325
[RFC] Add support for device extension autoloading ( #127074 )
...
Fixes #122468
- Load device extensions at the end of `torch/__init__.py`
- Enabled by default, or you can disable it with `TORCH_DEVICE_BACKEND_AUTOLOAD=0`
run test:
```python
python test/run_test.py -i test_autoload_enable
python test/run_test.py -i test_autoload_disable
```
doc:
https://docs-preview.pytorch.org/pytorch/pytorch/127074/miscellaneous_environment_variables.html
co-author: @jgong5 @bsochack @bkowalskiINTEL @jczaja @FFFrog @hipudding
Co-authored-by: albanD <desmaison.alban@gmail.com>
Co-authored-by: Jiong Gong <jiong.gong@intel.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127074
Approved by: https://github.com/albanD , https://github.com/jgong5
2024-07-09 06:14:13 +00:00
Edward Z. Yang
10c831567b
Make sympify'ing SymInt/etc produce their sympy expression ( #130166 )
...
There is one huge problem this fixes: today, sympify(symint)
produces a float(!!) because Sympy attempts to see if you can
coerce the symint to float in sympify and of course this works on
SymInt.
However, this also has another nontrivial effect: anywhere in Inductor
where sympy expressions are passed around, it is also valid to pass
around a SymInt now. I'm ambivalent about this: it's currently a
mistake to be passing around a SymInt when a sympy expression is
expected. But maybe this is fine?
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130166
Approved by: https://github.com/yf225
2024-07-06 03:56:45 +00:00
Edward Z. Yang
d7680a564b
Bug fixes for disabling 0/1 specialization on plain int ( #129961 )
...
These bug fixes will be exercised in
https://github.com/pytorch/pytorch/pull/128327 but I separate them from
the actual policy change (which is more risky)
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129961
Approved by: https://github.com/lezcano
2024-07-02 23:19:48 +00:00
Edward Z. Yang
dacc33d2fa
Make sym_min/sym_max handle Numpy scalars ( #129917 )
...
Internal xref:
https://fb.workplace.com/groups/1069285536500339/posts/7773876449374514/
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129917
Approved by: https://github.com/Skylion007
2024-07-02 14:59:20 +00:00
zrr1999
db4c7bb7fc
Refine typing annotation for compile ( #129136 )
...
before
after
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129136
Approved by: https://github.com/ezyang
2024-06-28 17:57:44 +00:00
