Commit Graph

3 Commits

Author SHA1 Message Date
Sam Estep
e1551f1678 Clarify .github/scripts/generate_ci_workflows.py (#58498)
Summary:
Followup to https://github.com/pytorch/pytorch/issues/58491:

- use f-string to remove the literal `generated` string from the generator script, so Phabricator no longer thinks it is a generated file
- remove the special logic for `test_runner_type` and instead explicitly specify for every workflow

Pull Request resolved: https://github.com/pytorch/pytorch/pull/58498

Test Plan:
```
make generate-gha-workflows
```
Also, check that Phabricator doesn't classify `.github/scripts/generate_ci_workflows.py` as "Generated changes" in this diff.

Reviewed By: seemethere

Differential Revision: D28516291

Pulled By: samestep

fbshipit-source-id: 8736eaad5d28082490be0a9b2e271c9493c2ba9d
2021-05-18 12:50:00 -07:00
Sam Estep
46484e8dfe Simplify .github/scripts/generate_ci_workflows.py (#58491)
Summary:
This PR simplifies `.github/scripts/generate_ci_workflows.py` by using the same strategy as https://github.com/pytorch/pytorch/issues/54344, representing workflows as plain data to avoid duplicating the definition of the `generate_workflow_file` function. This will make the script easier to maintain if/when that function is modified and/or more workflow types are added.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/58491

Test Plan:
The Lint job in CI; specifically:
```
make generate-gha-workflows
mypy --config mypy-strict.ini
```

Reviewed By: malfet, seemethere

Differential Revision: D28511918

Pulled By: samestep

fbshipit-source-id: aaf415a954d938a29aee7c9367c9bc2b9f44bb01
2021-05-18 11:49:51 -07:00
Eli Uriegas
4310decfbf .github: Add intial Windows CPU GHA workflow (#58199)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/58199

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D28465272

Pulled By: seemethere

fbshipit-source-id: d221ad71d160088883896e018c58800dae85ff2c
2021-05-17 15:04:16 -07:00