Jeff Daily
7c7b2d89ba
[ROCm] set hipblas workspace ( #138791 )
...
Fixes #138532 .
This brings hipblas behavior in line with cublas behavior with respect to setting the workspace to an allocation from the caching allocator as well as the env var HIPBLAS_WORKSPACE_CONFIG.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/138791
Approved by: https://github.com/naromero77amd , https://github.com/eqy , https://github.com/malfet
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
2024-10-29 01:37:55 +00:00
eqy
8321066031
Tweak formatting of note on macros ( #89598 )
...
For readability when viewing the rendered file e.g., from the browser.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/89598
Approved by: https://github.com/kit1980
2022-11-28 20:42:30 +00:00
Pruthvi Madugundu
fbd08fb358
Introduce TORCH_DISABLE_GPU_ASSERTS ( #84190 )
...
- Asserts for CUDA are enabled by default
- Disabled for ROCm by default by setting `TORCH_DISABLE_GPU_ASSERTS` to `ON`
- Can be enabled for ROCm by setting above variable to`OFF` during build or can be forcefully enabled by setting `ROCM_FORCE_ENABLE_GPU_ASSERTS:BOOL=ON`
This is follow up changes as per comment in PR #81790 , comment [link](https://github.com/pytorch/pytorch/pull/81790#issuecomment-1215929021 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84190
Approved by: https://github.com/jeffdaily , https://github.com/malfet
2022-11-04 04:43:05 +00:00
PyTorch MergeBot
0fa23663cc
Revert "Introduce TORCH_DISABLE_GPU_ASSERTS ( #84190 )"
...
This reverts commit 1e2c4a6e0ehttps://github.com/pytorch/pytorch/pull/84190 on behalf of https://github.com/malfet due to Needs internal changes, has to be landed via co-dev
2022-11-02 18:13:37 +00:00
Pruthvi Madugundu
1e2c4a6e0e
Introduce TORCH_DISABLE_GPU_ASSERTS ( #84190 )
...
- Asserts for CUDA are enabled by default
- Disabled for ROCm by default by setting `TORCH_DISABLE_GPU_ASSERTS` to `ON`
- Can be enabled for ROCm by setting above variable to`OFF` during build or can be forcefully enabled by setting `ROCM_FORCE_ENABLE_GPU_ASSERTS:BOOL=ON`
This is follow up changes as per comment in PR #81790 , comment [link](https://github.com/pytorch/pytorch/pull/81790#issuecomment-1215929021 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84190
Approved by: https://github.com/jeffdaily , https://github.com/malfet
2022-11-02 17:41:57 +00:00
Jithun Nair
730ce29baf
Add note on ifdefing based on CUDA_VERSION for ROCm path ( #62850 )
...
Summary:
CUDA_VERSION and HIP_VERSION follow very unrelated versioning schemes, so it does not make sense to use CUDA_VERSION to determine the ROCm path. This note explicitly addresses it.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/62850
Reviewed By: mruberry
Differential Revision: D30547562
Pulled By: malfet
fbshipit-source-id: 02990fa66a88466c2330ab85f446b25b78545150
2021-08-25 15:02:03 -07:00
Jithun Nair
336970c03e
Add note on torch.distributed backends on ROCm ( #58975 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/58975
Reviewed By: soulitzer
Differential Revision: D29595510
Pulled By: rohan-varma
fbshipit-source-id: 384bb67fcd003d65b76e957a474406b2a38099b9
2021-07-10 03:51:19 -07:00
Jithun Nair
ab6b5fa036
Add HIP (ROCm) semantics doc ( #57871 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/57871
Reviewed By: agolynski
Differential Revision: D28385510
Pulled By: malfet
fbshipit-source-id: 9cf69e52d026a1cf74cc12d8727ca17ae026235e
2021-05-12 12:34:07 -07:00
