Commit Graph

16 Commits

Author SHA1 Message Date
Jane Xu
c63a0d0cfe Adding windows CUDA smoke tests on PRs (#59686)
Summary:
Adding windows CUDA smoke tests on PRs (master should run the full suite).

Next step:
- Automate data update so we get a new smoke test list without manual effort

Pull Request resolved: https://github.com/pytorch/pytorch/pull/59686

Test Plan: https://github.com/pytorch/pytorch/actions/runs/958296267 The sharded smoke tests take long still because of dependencies installation

Reviewed By: walterddr

Differential Revision: D29243533

Pulled By: janeyx99

fbshipit-source-id: dde7ba127fa15c95bda0e833cc5311598fb85e2b
2021-06-23 10:13:50 -07:00
Jane Xu
eaa36ee679 Enable sharding for Windows GHA CI (#59970)
Summary:
Enables sharding for Windows on CI. To make that possible, we currently remove the smoke tests tested in shard 1 which don't seem all that important as they are
1. tested on nightlies
2. seems to be tested anyway by running the test suite

Pull Request resolved: https://github.com/pytorch/pytorch/pull/59970

Reviewed By: seemethere

Differential Revision: D29268484

Pulled By: janeyx99

fbshipit-source-id: 7f90d73037cfeb2c267b28714550316eb471b4dd
2021-06-21 11:42:22 -07:00
Sam Estep
3815a013ed Enable xenial-cuda11.1-cudnn8-py3.6-gcc7 in GHA (#60196)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/60196

Test Plan:
https://github.com/pytorch/pytorch/issues/60198: https://github.com/pytorch/pytorch/actions/runs/947796763

I should have used `ghstack` but I forgot; will do that in the future.

Reviewed By: walterddr

Differential Revision: D29231161

Pulled By: samestep

fbshipit-source-id: 8299a248ca9c1d36c3845d1c8a10ca9bf7101124
2021-06-18 09:18:53 -07:00
Eli Uriegas
047925dac1 .github: Run Windows CUDA build on pull requests (#60215)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/60215

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: samestep

Differential Revision: D29214519

Pulled By: seemethere

fbshipit-source-id: 58df5ee49cc5cd46f48938f023f87a6da958f3b6
2021-06-17 16:30:31 -07:00
Jane Xu
462448f07a Enable GHA sharding on linux (#60124)
Summary:
This is branch off of https://github.com/pytorch/pytorch/issues/59970 to only shard on linux so far (we're running in issues with windows gflags).

This would enable sharding of tests on a few Linux jobs on GHA, allowing tts to be essentially halved.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/60124

Reviewed By: zou3519

Differential Revision: D29204211

Pulled By: janeyx99

fbshipit-source-id: 1cc31d1eccd564d96e2aef14c0acae96a3f0fcd0
2021-06-17 13:00:23 -07:00
Eli Uriegas
4afd0b7952 .github: Add Windows CUDA 11.1 workflow (#59960)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/59960

Adds the CUDA 11.1 workflow to GHA

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: janeyx99

Differential Revision: D29116814

Pulled By: seemethere

fbshipit-source-id: 90601610e481e1f70a60eaa1b640373ecb89bdb9
2021-06-15 10:22:30 -07:00
Eli Uriegas
e2c784d940 [reland] .github: Add Windows GPU workflow (#58782) (#59752)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/59752

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: samestep

Differential Revision: D29009775

Pulled By: seemethere

fbshipit-source-id: 5be1b818b5653a4fdbfe4a79731317068dc1a5d1
2021-06-10 13:38:32 -07:00
Eli Uriegas
0f6bd550a4 Revert D28981443: reland D28645531: .github: Add Windows GPU workflow
Test Plan: revert-hammer

Differential Revision:
D28981443 (21121675b3)

Original commit changeset: 5d24cccfb8c8

fbshipit-source-id: 14e5b610978882bace2f834f61e5457f62b11290
2021-06-09 11:43:10 -07:00
Eli Uriegas
21121675b3 reland D28645531: .github: Add Windows GPU workflow (#59678)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/59678

This reverts commit 2956bbaf23.

Reland of https://github.com/pytorch/pytorch/pull/58782

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: samestep

Differential Revision: D28981443

Pulled By: seemethere

fbshipit-source-id: 5d24cccfb8c87832fa0233d0b524575dc04f8f05
2021-06-09 09:51:29 -07:00
Eli Uriegas
2956bbaf23 Revert D28645531: .github: Add Windows GPU workflow
Test Plan: revert-hammer

Differential Revision:
D28645531 (51884c6479)

Original commit changeset: 6ed1a2dead9c

fbshipit-source-id: e082d7d50de77d0572596111e95a3da3a350a319
2021-06-08 16:59:56 -07:00
Eli Uriegas
51884c6479 .github: Add Windows GPU workflow (#58782)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/58782

[skip ci]

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: samestep

Differential Revision: D28645531

Pulled By: seemethere

fbshipit-source-id: 6ed1a2dead9cca29e26e613afdbcf46ba7cee88c
2021-06-08 16:00:21 -07:00
Your Name
18302bcdf3 Add script to cancel workflows (#59019)
Summary:
This removes our cancel_redundant_workflows job in favor of GitHub's built in [`concurrency`](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#concurrency) keyword which limits runs of a particularly named group. Since the group names have to be unique per job per PR, it should end up looking something like `filename-job_name-{pr number | sha (for non-PR workflows)}`. There's also a script to check workflows and ensure that it is being properly gated so people don't forget to add the key in the future.

`ruamel.YAML` also didn't like some of the spacing so that is changed but it also makes it more consistent so �

This also has a minor change of renaming the workflow templates from `.in` to `.j2` which is the standard Jinja2 extension that the VSCode extension automatically picks up for syntax highlighting / errors.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/59019

Test Plan: pushed a commit `reset` and then immediately another commit `test`: the jobs from `reset` are cancelled: https://github.com/pytorch/pytorch/actions/runs/880099510

Reviewed By: samestep

Differential Revision: D28722419

Pulled By: driazati

fbshipit-source-id: c547a161877a0583be9d7edb29244b086b6bcad1
2021-05-27 12:32:15 -07:00
Eli Uriegas
bb4770462f .github: Enable Windows workflow for pull_request (#58418)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/58418

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D28483418

Pulled By: seemethere

fbshipit-source-id: c9f5a4df5a308e0ac6fc6fdc1a26d04723ffded7
2021-05-24 09:34:47 -07:00
Sam Estep
e1551f1678 Clarify .github/scripts/generate_ci_workflows.py (#58498)
Summary:
Followup to https://github.com/pytorch/pytorch/issues/58491:

- use f-string to remove the literal `generated` string from the generator script, so Phabricator no longer thinks it is a generated file
- remove the special logic for `test_runner_type` and instead explicitly specify for every workflow

Pull Request resolved: https://github.com/pytorch/pytorch/pull/58498

Test Plan:
```
make generate-gha-workflows
```
Also, check that Phabricator doesn't classify `.github/scripts/generate_ci_workflows.py` as "Generated changes" in this diff.

Reviewed By: seemethere

Differential Revision: D28516291

Pulled By: samestep

fbshipit-source-id: 8736eaad5d28082490be0a9b2e271c9493c2ba9d
2021-05-18 12:50:00 -07:00
Sam Estep
46484e8dfe Simplify .github/scripts/generate_ci_workflows.py (#58491)
Summary:
This PR simplifies `.github/scripts/generate_ci_workflows.py` by using the same strategy as https://github.com/pytorch/pytorch/issues/54344, representing workflows as plain data to avoid duplicating the definition of the `generate_workflow_file` function. This will make the script easier to maintain if/when that function is modified and/or more workflow types are added.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/58491

Test Plan:
The Lint job in CI; specifically:
```
make generate-gha-workflows
mypy --config mypy-strict.ini
```

Reviewed By: malfet, seemethere

Differential Revision: D28511918

Pulled By: samestep

fbshipit-source-id: aaf415a954d938a29aee7c9367c9bc2b9f44bb01
2021-05-18 11:49:51 -07:00
Eli Uriegas
4310decfbf .github: Add intial Windows CPU GHA workflow (#58199)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/58199

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D28465272

Pulled By: seemethere

fbshipit-source-id: d221ad71d160088883896e018c58800dae85ff2c
2021-05-17 15:04:16 -07:00