Ryan Guo
0d4dbfd9ed
[dynamo] Support torch.Tensor._make_subclass and tracing through tensor subclass __new__ ( #149483 )
...
This builds off the previous patch in the stack, and fully fixes
https://github.com/huggingface/diffusers/issues/10795 .
Essentially, tensor subclass in the issue uses
`torch.Tensor._make_subclass`, which has a pretty simple shallow-copy
plus type change semantics, as far as Dynamo is concerned. So this patch
adds a polyfill for it.
As a result, this allows us to trace through many user-defined `__new__`
in tensor subclass (it's similar to how we trace through user-defined
`__new__` for `UserDefinedClassVariable`), so this patch also faithfully
trace through these `__new__` methods.
Differential Revision: [D71906139](https://our.internmc.facebook.com/intern/diff/D71906139 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/149483
Approved by: https://github.com/zou3519 , https://github.com/mlazos
ghstack dependencies: #149482
2025-04-02 20:56:52 +00:00
PyTorch MergeBot
18908c8ced
Revert "[dynamo] Support torch.Tensor._make_subclass and tracing through tensor subclass __new__ ( #149483 )"
...
This reverts commit 203e1d681dhttps://github.com/pytorch/pytorch/pull/149483 on behalf of https://github.com/malfet due to Broke trunk, see b03c42109c/1https://github.com/pytorch/pytorch/pull/149482#issuecomment-2773650522 ))
2025-04-02 20:30:33 +00:00
Ryan Guo
203e1d681d
[dynamo] Support torch.Tensor._make_subclass and tracing through tensor subclass __new__ ( #149483 )
...
This builds off the previous patch in the stack, and fully fixes
https://github.com/huggingface/diffusers/issues/10795 .
Essentially, tensor subclass in the issue uses
`torch.Tensor._make_subclass`, which has a pretty simple shallow-copy
plus type change semantics, as far as Dynamo is concerned. So this patch
adds a polyfill for it.
As a result, this allows us to trace through many user-defined `__new__`
in tensor subclass (it's similar to how we trace through user-defined
`__new__` for `UserDefinedClassVariable`), so this patch also faithfully
trace through these `__new__` methods.
Differential Revision: [D71906139](https://our.internmc.facebook.com/intern/diff/D71906139 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/149483
Approved by: https://github.com/zou3519 , https://github.com/mlazos
ghstack dependencies: #149482
2025-04-02 17:05:19 +00:00
Jason Ansel
bec7bdad47
[fx] Move map_aggregate to C++ ( #148243 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
30603618 function calls (29403419 primitive calls) in 13.744 seconds
```
after:
```
25203549 function calls (24403352 primitive calls) in 12.090 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148243
Approved by: https://github.com/oulgen
2025-03-10 16:05:53 +00:00
PyTorch MergeBot
92beda54c8
Revert "[fx] Move map_aggregate to C++ ( #148243 )"
...
This reverts commit edaff88f69https://github.com/pytorch/pytorch/pull/148243 on behalf of https://github.com/jovianjaison due to breaking internal builds [T216910920] ([comment](https://github.com/pytorch/pytorch/pull/148243#issuecomment-2698724058 ))
2025-03-04 19:40:21 +00:00
Jason Ansel
edaff88f69
[fx] Move map_aggregate to C++ ( #148243 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
30603618 function calls (29403419 primitive calls) in 13.744 seconds
```
after:
```
25203549 function calls (24403352 primitive calls) in 12.090 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148243
Approved by: https://github.com/oulgen
2025-03-02 22:42:31 +00:00
bobrenjc93
1fe3af2c68
Migrate from Tuple -> tuple in torch/_dynamo ( #144261 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144261
Approved by: https://github.com/aorenste , https://github.com/zou3519
2025-01-10 07:45:57 +00:00
Xuehai Pan
78543e6002
[dynamo][pytree][1/N] make CXX pytree traceable: tree_iter / tree_leaves ( #137397 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137397
Approved by: https://github.com/jansel
2024-12-03 11:17:39 +00:00
PyTorch MergeBot
9012e7a62f
Revert "[dynamo][pytree][1/N] make CXX pytree traceable: tree_iter / tree_leaves ( #137397 )"
...
This reverts commit 07850bb2c1https://github.com/pytorch/pytorch/pull/137397 on behalf of https://github.com/atalman due to Failing internal test ([comment](https://github.com/pytorch/pytorch/pull/137397#issuecomment-2511934283 ))
2024-12-02 16:05:14 +00:00
Xuehai Pan
07850bb2c1
[dynamo][pytree][1/N] make CXX pytree traceable: tree_iter / tree_leaves ( #137397 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137397
Approved by: https://github.com/jansel
ghstack dependencies: #141360
2024-11-27 00:21:58 +00:00
Xuehai Pan
d65f194ab9
[dynamo] support operator.attrgetter and operator.itemgetter ( #141122 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/141122
Approved by: https://github.com/Skylion007 , https://github.com/jansel
2024-11-21 06:48:33 +00:00
Xuehai Pan
ebbdeeede1
[dynamo][itertools] refactor itertools.chain and itertools.chain.from_iterable to use polyfills ( #133864 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133864
Approved by: https://github.com/jansel
2024-08-31 00:11:54 +00:00
PyTorch MergeBot
1ad08c7a5b
Revert "[dynamo][itertools] refactor itertools.chain and itertools.chain.from_iterable to use polyfills ( #133864 )"
...
This reverts commit 1b70366957https://github.com/pytorch/pytorch/pull/133864 on behalf of https://github.com/ZainRizvi due to This is still failing internally with the same error about 'Graph break due to unsupported builtin _functools.reduce' ([comment](https://github.com/pytorch/pytorch/pull/133778#issuecomment-2321787968 ))
2024-08-30 16:06:10 +00:00
Xuehai Pan
1b70366957
[dynamo][itertools] refactor itertools.chain and itertools.chain.from_iterable to use polyfills ( #133864 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133864
Approved by: https://github.com/jansel
ghstack dependencies: #133769 , #133778 , #133779
2024-08-29 20:56:16 +00:00
Xuehai Pan
9e806c1a60
[dynamo] simplify implementation for os.fspath ( #133801 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133801
Approved by: https://github.com/anijain2305
2024-08-29 13:36:52 +00:00
PyTorch MergeBot
4811dc3de9
Revert "[dynamo] simplify polyfill registration for builtins.all and builtins.any ( #133769 )"
...
This reverts commit cc3a76edbahttps://github.com/pytorch/pytorch/pull/133769 on behalf of https://github.com/ZainRizvi due to Sorry but this has been discovered to be causing a performance regression internally ([comment](https://github.com/pytorch/pytorch/pull/133769#issuecomment-2316620213 ))
2024-08-29 03:00:47 +00:00
PyTorch MergeBot
f65df5edae
Revert "[dynamo][itertools] support itertools.tee ( #133771 )"
...
This reverts commit 1dbd3476dehttps://github.com/pytorch/pytorch/pull/133771 on behalf of https://github.com/ZainRizvi due to Sorry, have to revert this in order to be able to revert https://github.com/pytorch/pytorch/pull/133769 ([comment](https://github.com/pytorch/pytorch/pull/133771#issuecomment-2316611158 ))
2024-08-29 02:49:30 +00:00
PyTorch MergeBot
eaec9e80b8
Revert "[dynamo] simplify implementation for os.fspath ( #133801 )"
...
This reverts commit 74341e1150https://github.com/pytorch/pytorch/pull/133801 on behalf of https://github.com/ZainRizvi due to Sorry, have to revert this in order to be able to revert https://github.com/pytorch/pytorch/pull/133769 ([comment](https://github.com/pytorch/pytorch/pull/133771#issuecomment-2316611158 ))
2024-08-29 02:49:30 +00:00
Xuehai Pan
74341e1150
[dynamo] simplify implementation for os.fspath ( #133801 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133801
Approved by: https://github.com/anijain2305
ghstack dependencies: #133771
2024-08-27 00:08:04 +00:00
Xuehai Pan
1dbd3476de
[dynamo][itertools] support itertools.tee ( #133771 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133771
Approved by: https://github.com/jansel
2024-08-27 00:08:04 +00:00
PyTorch MergeBot
50e90d7203
Revert "[dynamo] simplify implementation for functools.reduce ( #133778 )"
...
This reverts commit 6c0b15e382https://github.com/pytorch/pytorch/pull/133778 on behalf of https://github.com/ZainRizvi due to Sorry, but this breaks internal tests because of using functools ([comment](https://github.com/pytorch/pytorch/pull/133778#issuecomment-2310445169 ))
2024-08-26 15:16:17 +00:00
PyTorch MergeBot
3d7f3f6a55
Revert "[dynamo][itertools] support itertools.tee ( #133771 )"
...
This reverts commit 0e49b2f18ehttps://github.com/pytorch/pytorch/pull/133771 on behalf of https://github.com/ZainRizvi due to Sorry, but this breaks internal tests because of using functools ([comment](https://github.com/pytorch/pytorch/pull/133778#issuecomment-2310445169 ))
2024-08-26 15:16:17 +00:00
PyTorch MergeBot
e1fc4362fb
Revert "[dynamo] simplify implementation for os.fspath ( #133801 )"
...
This reverts commit c5f6b72041https://github.com/pytorch/pytorch/pull/133801 on behalf of https://github.com/ZainRizvi due to Sorry, but this breaks internal tests because of using functools ([comment](https://github.com/pytorch/pytorch/pull/133778#issuecomment-2310445169 ))
2024-08-26 15:16:17 +00:00
Xuehai Pan
c5f6b72041
[dynamo] simplify implementation for os.fspath ( #133801 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133801
Approved by: https://github.com/anijain2305
ghstack dependencies: #133769 , #133778 , #133779 , #133771
2024-08-26 07:12:15 +00:00
Xuehai Pan
0e49b2f18e
[dynamo][itertools] support itertools.tee ( #133771 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133771
Approved by: https://github.com/jansel
ghstack dependencies: #133769 , #133778 , #133779
2024-08-23 10:13:12 +00:00
Xuehai Pan
6c0b15e382
[dynamo] simplify implementation for functools.reduce ( #133778 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133778
Approved by: https://github.com/jansel
ghstack dependencies: #133769
2024-08-23 09:10:44 +00:00
Xuehai Pan
cc3a76edba
[dynamo] simplify polyfill registration for builtins.all and builtins.any ( #133769 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133769
Approved by: https://github.com/jansel
2024-08-23 09:05:24 +00:00
Xuehai Pan
b6abac68ec
[BE][dynamo] reorganize polyfill module hierarchy ( #133977 )
...
Changes:
1. Move `polyfill.py` -> `polyfills/__init__.py`. It can be used as `polyfill.xxx` -> `polyfills.xxx`.
2. Move submodule loading from `polyfills/__init__.py` to `polyfills/loader.py`.
Merge `polyfill.py` and `polyfills/` packages. Each polyfill module have its own namespace for better code organization.
The ultimate goal is make `polyfills/__init__.py` empty and all polyfill functions move to its own namespace.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133977
Approved by: https://github.com/jansel
2024-08-22 16:42:29 +00:00
