OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity
94,926 Commits 8,304 Branches 150 Tags 1.5 GiB
b55b779ad3
Commit Graph

5600 Commits

Author SHA1 Message Date
Aaron Orenstein
b55b779ad3 Add file size limits to linters and refactor grep_linter (#166202) 
- Add 1GB file size limits to grep_linter, newlines_linter, codespell_linter
- Refactor grep_linter
  - process files once instead of per-line
  - Extract allowlist check to separate function
  - Add 512KB limit for computing replacements, 100 match limit per file
  - Detect duplicate arguments
- Fix .lintrunner.toml: RAWCUDADEVICE used --pattern twice
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166202
Approved by: https://github.com/Skylion007
 2025-10-25 14:57:19 +00:00
Catherine Lee
32ac38f85d [lint] workflow consistency linter to look at all files instead of just changed files (#165171) 
As in title

If you change only one workflow file, lintrunner (default arg, also the one in CI since it only inputs changed files) won't look at other files in the repo, but the sync-tag might come from those other files

This makes it so that it looks at all workflow files so it will catch those failures

Also change output line so it prints which file + which job it is different from

Pros:
catches errors

Cons:
unusual behavior (getting around what lintrunner says the linter should run on)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165171
Approved by: https://github.com/malfet, https://github.com/izaitsevfb, https://github.com/atalman
 2025-10-24 21:43:18 +00:00
Simon Layton
0b58d87aec [Submodule] Bump FBGEMM to latest (#165544) 
Summary:

* FBGEMM submodule updated to main
* CMake updated to reflect necessary changes
* Notably pulls in NVFP4 grouped gemm kernels

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Simon Layton <simonlayton@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165544
Approved by: https://github.com/cyyever, https://github.com/jeffdaily
 2025-10-22 20:57:15 +00:00
PyTorch MergeBot
05b2e02cb4 Revert "[lint] workflow consistency linter to look at all files instead of just changed files (#165171)" 
This reverts commit c746feb86a.

Reverted https://github.com/pytorch/pytorch/pull/165171 on behalf of https://github.com/clee2000 due to broke lint [GH job link](https://github.com/pytorch/pytorch/actions/runs/18723760085/job/53402955955) [HUD commit link](c746feb86a) ([comment](https://github.com/pytorch/pytorch/pull/165171#issuecomment-3433501457))
 2025-10-22 17:47:29 +00:00
Catherine Lee
c746feb86a [lint] workflow consistency linter to look at all files instead of just changed files (#165171) 
As in title

If you change only one workflow file, lintrunner (default arg, also the one in CI since it only inputs changed files) won't look at other files in the repo, but the sync-tag might come from those other files

This makes it so that it looks at all workflow files so it will catch those failures

Pros:
catches errors

Cons:
unusual behavior (getting around what lintrunner says the linter should run on)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165171
Approved by: https://github.com/malfet
 2025-10-22 16:57:59 +00:00
Yuanyuan Chen
f9953e0f61 Enable PLC0414 on ruff (#165828) 
This PR enables `PLC0414` that fixes redundant import aliases.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165828
Approved by: https://github.com/albanD
 2025-10-22 04:56:52 +00:00
inventshah
715449ca76 [MPS] Fix parity between CPU and MPS on singular matrices in linalg.lu_factor (#165871) 
Fixes #165870. Follow up from #165254.

This PR [a] removes the MPS specific version of `lu_factor` in favor of the version in BatchedLinearAlgebra.cpp which uses `lu_factor_ex`, and [b] updates `lu_factor_ex` error codes to match expectations.

When `lu_factor` was first implemented for MPS (#99269), it bypassed the implementation in BatchedLinearAlgebra.cpp since we did not have `lu_factor_ex`. Since #144651 implements `lu_factor_ex`, we can now remove the MPS specific wrapper.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165871
Approved by: https://github.com/kulinseth, https://github.com/albanD
 2025-10-22 02:48:40 +00:00
Tushar Jain
d1269a0434 update fr trace analysis (#165994) 
Summary:
- allow empty entries from ranks
- allow not all ranks to provide dump

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/pytorch/pull/165994).
* #165638
* #165640
* #165642
* __->__ #165994
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165994
Approved by: https://github.com/fduwjj
 2025-10-21 19:14:33 +00:00
Maggie Moss
0be0de4ffa Add type suppressions to _inductor/runtime (#165918) 
Original PR that did this was reverted due to merge conflicts.

Trying it again

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165918
Approved by: https://github.com/oulgen
 2025-10-21 02:54:22 +00:00
PyTorch MergeBot
0da1f911dc Revert "[Submodule] Bump FBGEMM to latest (#165544)" 
This reverts commit 23417ae50f.

Reverted https://github.com/pytorch/pytorch/pull/165544 on behalf of https://github.com/clee2000 due to failing in internal D84996252, probably needs some sort of update to fbgemm internally? ([comment](https://github.com/pytorch/pytorch/pull/165544#issuecomment-3422993703))
 2025-10-20 17:06:07 +00:00
Yuanyuan Chen
3255e7872b Enable all flake8-logging-format rules (#164655) 
These rules are enabled by removing existing suppressions.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164655
Approved by: https://github.com/janeyx99, https://github.com/mlazos
 2025-10-19 00:59:28 +00:00
Maggie Moss
f02e3947f6 Expand type checking to mypy strict files (#165697) 
Expands Pyrefly type checking to check the files outlined in the mypy-strict.ini configuration file:

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165697
Approved by: https://github.com/ezyang
 2025-10-18 04:34:45 +00:00
Simon Layton
23417ae50f [Submodule] Bump FBGEMM to latest (#165544) 
Summary:

* FBGEMM submodule updated to main
* CMake updated to reflect necessary changes
* Notably pulls in NVFP4 grouped gemm kernels

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Simon Layton <simonlayton@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165544
Approved by: https://github.com/cyyever, https://github.com/jeffdaily
 2025-10-18 03:58:08 +00:00
bobrenjc93
7dabfb07cb [torchfuzz] add support for --stop-at-first-failure flag (#165529) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165529
Approved by: https://github.com/pianpwk
ghstack dependencies: #164749
 2025-10-17 02:18:07 +00:00
bobrenjc93
d0add0be43 [torchfuzz] check in some more ignore regexes (#164749) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164749
Approved by: https://github.com/pianpwk
 2025-10-17 02:18:07 +00:00
Shangdi Yu
d82527b32a [Windows] Add AOTI cross-compilation CI (#165573) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165573
Approved by: https://github.com/malfet
ghstack dependencies: #165560
 2025-10-17 01:05:35 +00:00
Yuanyuan Chen
b2953f5643 [9/N] Apply ruff UP035 rule (#165515) 
This is follow-up of #165214 to continue applying ruff UP035 rule to the code base.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165515
Approved by: https://github.com/Lucaskabela
 2025-10-17 00:09:51 +00:00
Maggie Moss
d795fb225a [RFC] Add pyrefly to lintrunner (#165179) 
This will add pyrefly to lint runner as a warning only - and allow us to collect feedback about the tool before switching to pyrefly as the main type checker.

References the steps outlined here: : https://github.com/pytorch/pytorch/issues/163283:

test plan:
`lintrunner init`
`lintrunner`
confirm when pyrefly errors are present results look like: https://gist.github.com/maggiemoss/e6cb2d015dd1ded560ae1329098cf33f

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165179
Approved by: https://github.com/ezyang
 2025-10-16 20:07:09 +00:00
Catherine Lee
ffc7552e01 See if we can handle uploading all test data (#165484) 
Fixes #ISSUE_NUMBER

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165484
Approved by: https://github.com/izaitsevfb
 2025-10-15 19:57:41 +00:00
can-gaa-hou
2c600bb665 [torchfuzz] fix some errors when walkthroughing README.md (#165225) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165225
Approved by: https://github.com/soulitzer
 2025-10-13 17:17:50 +00:00
Yuanyuan Chen
8de85896e0 Enable ruff rule E721 (#165162) 
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
 2025-10-13 01:48:55 +00:00
PyTorch MergeBot
816fb7f48d Revert "Enable ruff rule E721 (#165162)" 
This reverts commit 9e7c19f72b.

Reverted https://github.com/pytorch/pytorch/pull/165162 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](https://github.com/pytorch/pytorch/pull/165162#issuecomment-3393328271))
 2025-10-11 13:25:40 +00:00
Yuanyuan Chen
9e7c19f72b Enable ruff rule E721 (#165162) 
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
 2025-10-11 06:43:53 +00:00
can-gaa-hou
af42256db4 Fix missing brackets (#165138) 
As stated in the title.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165138
Approved by: https://github.com/Aidyn-A, https://github.com/Skylion007
 2025-10-10 17:23:31 +00:00
Yuanyuan Chen
a029675f6f More ruff SIM fixes (#164695) 
This PR applies ruff `SIM` rules to more files. Most changes are about simplifying `dict.get` because `None` is already the default value.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164695
Approved by: https://github.com/ezyang
 2025-10-09 03:24:50 +00:00
Mikayla Gawarecki
f37a6523ef Move version.h to torch/headeronly (#164381) 
Differential Revision: [D83685392](https://our.internmc.facebook.com/intern/diff/D83685392)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164381
Approved by: https://github.com/janeyx99
 2025-10-07 17:47:30 +00:00
bobrenjc93
4bcc05777e [torchfuzz] synthesize inputs for data dependent ops (#164716) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164716
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688, #164693, #164694, #164715
 2025-10-07 05:40:32 +00:00
bobrenjc93
2a6cdba6e5 [torchfuzz] various edge case fixes (#164715) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164715
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688, #164693, #164694
 2025-10-07 05:30:46 +00:00
bobrenjc93
53f6cc7529 [torchfuzz] make ops_fuzzer deterministic (#164694) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164694
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688, #164693
 2025-10-07 05:30:46 +00:00
bobrenjc93
ac901bf79a [torchfuzz] consolidate on a base implementation of args_codegen (#164693) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164693
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688
 2025-10-07 05:20:28 +00:00
bobrenjc93
c965d6dbb2 [torchfuzz] move into experimental dir (#164688) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164688
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687
 2025-10-07 05:09:08 +00:00
bobrenjc93
ac08556f67 [torchfuzz] support more unbacked functions (#164687) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164687
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649
 2025-10-07 05:00:03 +00:00
bobrenjc93
5fe7f29b9e [torchfuzz] add support for operator weights (#164649) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164649
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647
 2025-10-07 05:00:03 +00:00
bobrenjc93
ded099ecbf [torchfuzz] don't use the first gpu in multi process fuzzer (#164647) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164647
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646
 2025-10-07 04:59:56 +00:00
bobrenjc93
63fcc3e6c4 [torchfuzz] update README.md (#164646) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164646
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514
 2025-10-07 04:59:50 +00:00
rraminen
49f7d8d19d [ROCm] Fix test_cuda_synchronize failure on ROCm (#164735) 
This PR skips the hipify step of torch/csrc/jit/ir/ir.h to avoid a build-time error for the JIT cuda namespace.  This fixes two skipped tests in test/jit/test_cuda.py.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164735
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
 2025-10-07 01:14:24 +00:00
fduwjj
86c789849e [fr] Re-order mismatch check in fr analysis script (#164606) 
In reality we found the current mismatch order does not match the actual error distribution, so we reorder it a bit as following:
1. We do collective type check first
2. Then size check (excluding all2all)
3. dtype check
4. state check

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164606
Approved by: https://github.com/VieEeEw
 2025-10-04 01:16:15 +00:00
bobrenjc93
3db2164341 [torchfuzz] add norm operators (#164514) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164514
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434
 2025-10-03 14:44:19 +00:00
bobrenjc93
5bb8f04d3e [torchfuzz] add nn functional ops (#164434) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164434
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432
 2025-10-03 14:44:19 +00:00
bobrenjc93
7617b113ad [torchfuzz] Support EagerVsFullGraphDynamicCompileWithNumericsCheck (#164432) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164432
Approved by: https://github.com/pianpwk
 2025-10-03 06:42:20 +00:00
PyTorch MergeBot
c6329524d8 Revert "Add magic TORCH_MAKE_PYBIND_ENUM_FASTER macro (#163527)" 
This reverts commit 50c0550f5a.

Reverted https://github.com/pytorch/pytorch/pull/163527 on behalf of https://github.com/swolchok due to breaking import torch in debug builds, see #164297 ([comment](https://github.com/pytorch/pytorch/pull/163527#issuecomment-3361919142))
 2025-10-02 15:42:42 +00:00
Xuehai Pan
9697a7ce9e Better path handling for nightly setup tool (#164215) 
Resolves https://github.com/pytorch/pytorch/issues/164010#issuecomment-3349283789, cc @filipviz

Previously, the `checkout` subcommand would reuse the `venv`, while the `pull` subcommand would remove and recreate a fresh new `venv` (without prompting before deleting).

This PR:

- Keep and reuse the existing `venv` by default (both `pull` and `checkout`).
- Add a new `--fresh` option to delete and recreate a fresh new `venv`.
- Prompt the user for confirmation (add a new `--yes` option) before deleting the existing prefix path.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164215
Approved by: https://github.com/ezyang, https://github.com/malfet
ghstack dependencies: #162324, #164214
 2025-10-02 07:59:17 +00:00
bobrenjc93
39b31a6bfd [torchfuzz] keep track of operator stats (#164334) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164334
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034, #164209, #164211, #164210, #164397, #164284
 2025-10-02 03:48:07 +00:00
bobrenjc93
0fbe3f19c7 [torchfuzz] add matmuls (#164284) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164284
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034, #164209, #164211, #164210, #164397
 2025-10-02 03:33:10 +00:00
bobrenjc93
144378615a [torchfuzz] make fuzzer deterministic (#164397) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164397
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034, #164209, #164211, #164210
 2025-10-02 03:10:30 +00:00
Catherine Lee
e5c0e6b5e3 [testing] Better short job name during upload additional stats (#164287) 
I think we usually we leave the ` / test` in for clarity
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164287
Approved by: https://github.com/atalman, https://github.com/malfet
 2025-10-01 19:56:20 +00:00
Xuehai Pan
17ab99463a [Easy] Add notes for setting up dev venv with specific Python version (#164214) 
Resolves https://github.com/pytorch/pytorch/issues/164010#issuecomment-3340751377

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164214
Approved by: https://github.com/ezyang
ghstack dependencies: #162324
 2025-10-01 08:25:13 +00:00
Xuehai Pan
eca6ac2293 [BE][Easy] update CUDA and ROCm sources in nightly tool (#162324) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/162324
Approved by: https://github.com/ezyang
 2025-10-01 08:25:13 +00:00
bobrenjc93
10a005e87f [torchfuzz] add layout operators (#164210) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164210
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034, #164209, #164211
 2025-10-01 02:33:19 +00:00
bobrenjc93
1f3995cdc8 [torchfuzz] raise if Operator abstract method is not implemented (#164211) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164211
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034, #164209
 2025-10-01 02:33:19 +00:00