OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 00:20:18 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity
94,926 Commits 8,304 Branches 150 Tags 1.5 GiB
b55b779ad3
Commit Graph

715 Commits

Author SHA1 Message Date
Aaron Orenstein
b55b779ad3 Add file size limits to linters and refactor grep_linter (#166202) 
- Add 1GB file size limits to grep_linter, newlines_linter, codespell_linter
- Refactor grep_linter
  - process files once instead of per-line
  - Extract allowlist check to separate function
  - Add 512KB limit for computing replacements, 100 match limit per file
  - Detect duplicate arguments
- Fix .lintrunner.toml: RAWCUDADEVICE used --pattern twice
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166202
Approved by: https://github.com/Skylion007
 2025-10-25 14:57:19 +00:00
Catherine Lee
0977cc4474 [lint] Extend workflowsync linter to more files (#166082) 
And fix the lint issues found
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166082
Approved by: https://github.com/izaitsevfb, https://github.com/atalman
 2025-10-23 20:29:29 +00:00
Maggie Moss
d795fb225a [RFC] Add pyrefly to lintrunner (#165179) 
This will add pyrefly to lint runner as a warning only - and allow us to collect feedback about the tool before switching to pyrefly as the main type checker.

References the steps outlined here: : https://github.com/pytorch/pytorch/issues/163283:

test plan:
`lintrunner init`
`lintrunner`
confirm when pyrefly errors are present results look like: https://gist.github.com/maggiemoss/e6cb2d015dd1ded560ae1329098cf33f

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165179
Approved by: https://github.com/ezyang
 2025-10-16 20:07:09 +00:00
bobrenjc93
c965d6dbb2 [torchfuzz] move into experimental dir (#164688) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164688
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687
 2025-10-07 05:09:08 +00:00
bobrenjc93
39d0c06ed0 [torchfuzz] check in some more xfail repros (#164619) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164619
Approved by: https://github.com/ezyang
 2025-10-06 16:20:44 +00:00
bobrenjc93
5bb8f04d3e [torchfuzz] add nn functional ops (#164434) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164434
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432
 2025-10-03 14:44:19 +00:00
bobrenjc93
00f0365b95 [torchfuzz] add test suite of fuzzer repros that we xfail (#164430) 
i'll add the rest of the repros once in a follow up PR once we agree on a good test harness
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164430
Approved by: https://github.com/ezyang
 2025-10-02 08:05:11 +00:00
Simon Layton
7a9119948e Split scaled-mm tests into separate file (#164266) 
Summary:

* Split scaled-mm-specific tests into `test/test_scaled_matmul.py`

Test Plan:

```
pytest test/test_matmul_cuda.py
pytest test/test_scaled_matmul_cuda.py
```

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Simon Layton <simonlayton@meta.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164266
Approved by: https://github.com/Skylion007, https://github.com/albanD
 2025-10-01 02:23:21 +00:00
Yuanyuan Chen
7441a1b9b1 Update ruff to 0.13.1 (#163744) 
Update ruff to 0.13.1 so that we can remove `UP038` from `pyproject.toml` because it has been removed from supported rules of ruff.
There are some fixes, the most notable one is [(PYI059)](https://docs.astral.sh/ruff/rules/generic-not-last-base-class/#generic-not-last-base-class-pyi059)
```
Checks for classes inheriting from typing.Generic[] where Generic[] is not the last base class in the bases tuple.

```

A BC-breaking change is introduced to change the typing of `OrderedSet .storage`

Pull Request resolved: https://github.com/pytorch/pytorch/pull/163744
Approved by: https://github.com/Skylion007, https://github.com/jingsh
 2025-09-26 10:12:21 +00:00
PyTorch MergeBot
7bad9c5a64 Revert "Update ruff to 0.13.1 (#163744)" 
This reverts commit 3dd89a079f.

Reverted https://github.com/pytorch/pytorch/pull/163744 on behalf of https://github.com/malfet due to Broke lint, see https://github.com/pytorch/pytorch/actions/runs/18016220484/job/51261729375 looks like a landrace with PR that updated min-version to 3.10 ([comment](https://github.com/pytorch/pytorch/pull/163744#issuecomment-3335534084))
 2025-09-25 18:54:03 +00:00
Yuanyuan Chen
3dd89a079f Update ruff to 0.13.1 (#163744) 
Update ruff to 0.13.1 so that we can remove `UP038` from `pyproject.toml` because it has been removed from supported rules of ruff.
There are some fixes, the most notable one is [(PYI059)](https://docs.astral.sh/ruff/rules/generic-not-last-base-class/#generic-not-last-base-class-pyi059)
```
Checks for classes inheriting from typing.Generic[] where Generic[] is not the last base class in the bases tuple.

```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/163744
Approved by: https://github.com/Skylion007, https://github.com/jingsh
 2025-09-25 17:52:35 +00:00
FFFrog
bf0747c6c6 [Code Clean] Remove deadcodes about Python3.9 [1/N] (#163626) 
As the title stated.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/163626
Approved by: https://github.com/Skylion007, https://github.com/albanD
 2025-09-24 07:30:50 +00:00
bobrenjc93
0b75a16200 [torchfuzz] Encapsulate fuzzing and codegen logic into ops (#163547) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/163547
Approved by: https://github.com/laithsakka
 2025-09-23 04:26:00 +00:00
Edward Yang
97eb7a281d torchdim Python port (#160236) 
The big semantic change (and the reason for this port) is that we no longer monkeypatch Tensor with torchdim's special methods. The new algorithm for handling dispatch is that we first land in `__torch_function__` and we see if a special FCD implementation needs to be dispatch to first, and if there is nothing we fallback to the standard level strategy.

Because there is no longer C binding equivalent of classes, we've condensed _C.Dim and Dim together, and similar for Tensor. This resulted in some bugs as the Python API is sometimes different from the C API. I've attempted to disambiguate these but there may still be mistakes (many early bugs were due to this problem). Dim and DimEntry are especially painful as Dim must abide by Tensor equality semantics, but is pointer equality in C (DimEntry doesn't have this problem). Another difference between C/Python that is subtle is we no longer get implicit conversions from Dim to DimEntry, this also caused some bugs.

Much of the mechanical porting work was done by claude code. I have a separate PR that deletes functorch._C, but it was useful having dim.cpp to point claude at it so I haven't done it in this PR. From a reviewing perspective, I need to re-review that I didn't forget to port anything, some noticeably missing "small" things are patched_dim_method. I am still in progress of carefully doing a side-by-side review of ports; "simplifications" from claude code were also a major source of bugs.

There are two major feature gaps in the implementation:

- DelayedTensor and dot handling are not implemented yet. This should be reasonably easy, just need to do it.  However, for the purposes of sharded propagation it is actually better not to reconstruct matmuls.
- Splitting dimensions with an index like `[x, y]` doesn't work. The problem is that `__getitem__` interprets this as advanced indexing and sends the list to torch.tensor to turn into a tensor, instead of being eligible for `__torch_function__`. I think I might need to hard code a special case for this or something?

Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/160236
Approved by: https://github.com/zdevito, https://github.com/albanD
 2025-09-21 03:01:04 +00:00
PaliC
c43ccfbc2d [BE] Remove bottleneck (#163210) 
Some cleanup related to this RFC: https://github.com/pytorch/pytorch/issues/68742
Pull Request resolved: https://github.com/pytorch/pytorch/pull/163210
Approved by: https://github.com/ezyang
 2025-09-18 12:08:13 +00:00
Klaus Zimmermann
31345fb4f7 Make functorch notebook symlinks PEP 517 valid (#157813) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157813
Approved by: https://github.com/zou3519, https://github.com/atalman
 2025-09-12 03:52:08 +00:00
PyTorch MergeBot
420c52ecf3 Revert "Make distributed modules importable even when backend not built (#159889)" 
This reverts commit 626cb7df81.

Reverted https://github.com/pytorch/pytorch/pull/159889 on behalf of https://github.com/jeanschmidt due to Breaking internal builds, can't be landed with forward fix due to internal tooling problems ([comment](https://github.com/pytorch/pytorch/pull/159889#issuecomment-3246677982))
 2025-09-02 20:24:01 +00:00
PyTorch MergeBot
82f63c8f6d Revert "[HOTFIX] Disable DISTRIBUTED_C10D_DIRECT_ACCESS for now (#161946)" 
This reverts commit 5561e45758.

Reverted https://github.com/pytorch/pytorch/pull/161946 on behalf of https://github.com/jeanschmidt due to Need to be reverted so https://github.com/pytorch/pytorch/pull/159889 can be ([comment](https://github.com/pytorch/pytorch/pull/161946#issuecomment-3246663376))
 2025-09-02 20:18:52 +00:00
Edward Yang
5561e45758 [HOTFIX] Disable DISTRIBUTED_C10D_DIRECT_ACCESS for now (#161946) 
Signed-off-by: Edward Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/161946
Approved by: https://github.com/msaroufim
 2025-09-02 05:01:46 +00:00
Edward Z. Yang
626cb7df81 Make distributed modules importable even when backend not built (#159889) 
This PR is greatly simplified now that it stacked on top of a PR that builds with distributed always. We only need to stub functions that may not be defined due to a backend not being enabled.

Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/159889
Approved by: https://github.com/wconstab
ghstack dependencies: #160449
 2025-09-01 23:00:21 +00:00
Benjamin Glass
007935a802 [cpp_wrapper] Swap to new PyBind11 simple GIL header (#161063) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/161063
Approved by: https://github.com/Skylion007
ghstack dependencies: #160754
 2025-08-27 21:15:01 +00:00
PyTorch MergeBot
1ce423274d Revert "[cpp_wrapper] Swap to new PyBind11 simple GIL header (#161063)" 
This reverts commit 74c4c758af.

Reverted https://github.com/pytorch/pytorch/pull/161063 on behalf of https://github.com/atalman due to sorry broke vllm tests please see https://github.com/pytorch/pytorch/pull/160754#issuecomment-3226051449 ([comment](https://github.com/pytorch/pytorch/pull/161063#issuecomment-3226065212))
 2025-08-26 23:31:23 +00:00
Benjamin Glass
74c4c758af [cpp_wrapper] Swap to new PyBind11 simple GIL header (#161063) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/161063
Approved by: https://github.com/Skylion007
ghstack dependencies: #160754
 2025-08-26 01:21:18 +00:00
zeshengzong
f09458c2e1 Enable test/test_numpy_interop.py config in mypy (#158556) 
## Test Result

```bash
lintrunner --take MYPY test/test_numpy_interop.py

Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.
ok No lint issues.
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/158556
Approved by: https://github.com/soulitzer
 2025-08-22 16:18:58 +00:00
Aaron Gokaslan
ed8bcccf31 [BE][Ez]: Update ruff to 0.12.9 (#160896) 
Updates ruff. Fixes false positives and other miscellaneous ruff linting and formatting fixes.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/160896
Approved by: https://github.com/zou3519
 2025-08-19 19:56:24 +00:00
Xuehai Pan
178515d0ff [BE][PYFMT] remove black: finish black -> ruff format migration (#144557) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144557
Approved by: https://github.com/ezyang
 2025-08-08 07:46:10 +00:00
Xuehai Pan
efcf87654e [CI] update flake8 and mypy lint dependencies (#158720) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158720
Approved by: https://github.com/Skylion007
 2025-07-29 08:05:56 +00:00
PyTorch MergeBot
59e261bbd8 Revert "[CI] update flake8 and mypy lint dependencies (#158720)" 
This reverts commit f5130bf339.

Reverted https://github.com/pytorch/pytorch/pull/158720 on behalf of https://github.com/yangw-dev due to this pr failed internally when build torchgen due to rror: fail: Unknown PyPI project: pyyaml, it seems like this is caused by change PyYAML into  pyyaml, please fix it ([comment](https://github.com/pytorch/pytorch/pull/158720#issuecomment-3129995414))
 2025-07-28 22:02:10 +00:00
Xuehai Pan
f5130bf339 [CI] update flake8 and mypy lint dependencies (#158720) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158720
Approved by: https://github.com/Skylion007
 2025-07-26 17:12:29 +00:00
Sidharth
4d5d56a30e [dynamo] lintrunner for gb_registry adds/updates (#158460) 
This PR adds automation to adding/updating the JSON registry through the lintrunner.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/158460
Approved by: https://github.com/williamwen42
 2025-07-23 21:02:54 +00:00
PyTorch MergeBot
393377d215 Revert "[CI] update flake8 and mypy lint dependencies (#158720)" 
This reverts commit a527e81693.

Reverted https://github.com/pytorch/pytorch/pull/158720 on behalf of https://github.com/malfet due to This broke lint, see 8e57cdb746/1 ([comment](https://github.com/pytorch/pytorch/pull/158720#issuecomment-3096893256))
 2025-07-21 13:58:50 +00:00
Xuehai Pan
a527e81693 [CI] update flake8 and mypy lint dependencies (#158720) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158720
Approved by: https://github.com/Skylion007
 2025-07-21 09:24:29 +00:00
Xuehai Pan
d5af0eca8d [BE][3/5] fix typos in aten/ (aten/src/ATen/native/) (#157552) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157552
Approved by: https://github.com/albanD
ghstack dependencies: #156605, #157637, #157550, #157551
 2025-07-17 12:08:34 +00:00
Xuehai Pan
f57ef62ebc [BE][2/5] fix typos in aten/ (aten/src/ATen/native/) (#157551) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157551
Approved by: https://github.com/albanD
ghstack dependencies: #156605, #157637, #157550
 2025-07-17 12:08:33 +00:00
Xuehai Pan
4c8b408d16 [BE][1/5] fix typos in aten/ (#157550) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157550
Approved by: https://github.com/albanD
ghstack dependencies: #156605, #157637
 2025-07-17 12:08:33 +00:00
Xuehai Pan
c8d43cbc6e [BE][3/6] fix typos in test/ (#157637) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157637
Approved by: https://github.com/yewentao256, https://github.com/albanD
ghstack dependencies: #156605
 2025-07-17 12:08:33 +00:00
Xuehai Pan
3f8e2e91ad [BE][15/16] fix typos in torch/ (torch/distributed/tensor/) (#156605) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156605
Approved by: https://github.com/wanchaol, https://github.com/albanD
 2025-07-17 12:08:33 +00:00
Catherine Lee
473208cb18 [ez][lint] Add pr_time_benchmarks to merge conflictless csv linter (#158353) 
Discovered this when looking at a PR I was trying to revert and was surprised that the PR got rid of the spaces but didn't trigger the linter.  Turns out the file was following the rule but wasn't actually being checked
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158353
Approved by: https://github.com/seemethere, https://github.com/Camyll
 2025-07-16 20:31:07 +00:00
Jane Xu
2b0f9b1f61 Move c10/macros/Macros.h to headeronly (#158365) 
^

Differential Revision: [D78361893](https://our.internmc.facebook.com/intern/diff/D78361893/)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158365
Approved by: https://github.com/swolchok
ghstack dependencies: #158358
 2025-07-16 18:46:52 +00:00
Xuehai Pan
7f14b42adf [BE][2/16] fix typos in torch/ (torch/_*/) (#156312) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156312
Approved by: https://github.com/albanD
 2025-07-12 05:47:06 +00:00
PyTorch MergeBot
e15f4248ad Revert "[BE][2/16] fix typos in torch/ (torch/_*/) (#156312)" 
This reverts commit 7a92b51196.

Reverted https://github.com/pytorch/pytorch/pull/156312 on behalf of https://github.com/XuehaiPan due to landrace ([comment](https://github.com/pytorch/pytorch/pull/156312#issuecomment-3064672250))
 2025-07-12 04:40:52 +00:00
Xuehai Pan
7a92b51196 [BE][2/16] fix typos in torch/ (torch/_*/) (#156312) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156312
Approved by: https://github.com/albanD
 2025-07-12 01:47:22 +00:00
Aaron Gokaslan
7a08755c5f [BE][Ez]: Update ruff to 0.12.2 (#157937) 
Updates to the latest version of ruff and apply some fixes that it flagged and silence a few new lints

Pull Request resolved: https://github.com/pytorch/pytorch/pull/157937
Approved by: https://github.com/ezyang
 2025-07-11 15:16:20 +00:00
Xuehai Pan
0d17029fea [BE][6/6] fix typos in test/ (test/distributed/) (#157640) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157640
Approved by: https://github.com/yewentao256, https://github.com/malfet
 2025-07-11 14:09:37 +00:00
Shangdi Yu
4781d72faa [AOTI] codegen for static linkage (#157129) 
Design doc: https://docs.google.com/document/d/1ncV7RpJ8xDwy8-_aCBfvZmpTTL824C-aoNPBLLVkOHM/edit?tab=t.0 (internal)

- Add codegen for static linkage
- refactor test code for test_compile_after_package tests

For now,  the following options must be used together with `"aot_inductor.compile_standalone": True`.
"aot_inductor.package_cpp_only": True,

Will change `"aot_inductor.package_cpp_only"` to be automatically set to True in followup PR.

```
python test/inductor/test_aot_inductor_package.py -k test_compile_after_package
python test/inductor/test_aot_inductor_package.py -k test_run_static_linkage_model
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/157129
Approved by: https://github.com/desertfire
 2025-07-10 16:03:50 +00:00
Xuehai Pan
fc0376e8b1 [BE][2/6] fix typos in test/ (test/test_*.py) (#157636) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157636
Approved by: https://github.com/yewentao256, https://github.com/mlazos
ghstack dependencies: #156311, #156609
 2025-07-09 11:02:23 +00:00
Xuehai Pan
4cc8b60d1b [BE][1/16] fix typos in torch/ (#156311) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156311
Approved by: https://github.com/albanD
 2025-07-09 11:02:22 +00:00
Xuehai Pan
924fc52e18 [BE] add a linter to check consistency for cmake minimum version in requirements (#156961) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156961
Approved by: https://github.com/ezyang, https://github.com/malfet
 2025-07-09 10:44:17 +00:00
Xuehai Pan
84b77ec128 [BE] add a minimal linter to check pyproject.toml consistency (#156017) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156017
Approved by: https://github.com/ezyang
 2025-07-08 08:17:36 +00:00
Xuehai Pan
02715d0876 [BE][5/6] fix typos in test/ (test/dynamo/) (#157639) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157639
Approved by: https://github.com/yewentao256, https://github.com/jansel
ghstack dependencies: #157638
 2025-07-06 06:34:25 +00:00