7 Commits

Author	SHA1	Message	Date
cyy	64d9ee88d7	[11/N] Fix extra warnings brought by clang-tidy-17 (#139599) ... Follows #139385 Pull Request resolved: https://github.com/pytorch/pytorch/pull/139599 Approved by: https://github.com/sraikund16	2024-11-04 23:57:41 +00:00
cyy	20f769544c	[12/N] Apply clang-tidy and fix warnings in headers of torch/csrc (#116486) ... This PR follows #116751. Pull Request resolved: https://github.com/pytorch/pytorch/pull/116486 Approved by: https://github.com/albanD	2024-01-10 08:48:14 +00:00
PyTorch MergeBot	0aa50909f3	Revert "[12/N] Apply clang-tidy and fix warnings in headers of torch/csrc (#116486)" ... This reverts commit 5aa258eb09. Reverted https://github.com/pytorch/pytorch/pull/116486 on behalf of https://github.com/izaitsevfb due to Reverting, as it depends on https://github.com/pytorch/pytorch/pull/116353, which has to be reverted ([comment](https://github.com/pytorch/pytorch/pull/116486#issuecomment-1876042948))	2024-01-03 22:18:54 +00:00
cyy	5aa258eb09	[12/N] Apply clang-tidy and fix warnings in headers of torch/csrc (#116486) ... Fixes #ISSUE_NUMBER Pull Request resolved: https://github.com/pytorch/pytorch/pull/116486 Approved by: https://github.com/albanD	2023-12-30 18:38:53 +00:00
Michael Suo	30fb2c4aba	[lint] autoformat test/cpp and torch/csrc ... Let's have some fun. Pull Request resolved: https://github.com/pytorch/pytorch/pull/78828 Approved by: https://github.com/ezyang	2022-06-11 21:11:16 +00:00
Ralf Gommers	1b4951d3a5	Fix remaining invalid function cast warnings that show up with GCC 8/9 (#26104) ... Summary: Follow-up to gh-25483, more of the same fixes for warnings like: ``` ../torch/csrc/autograd/python_variable.cpp:503:31: warning: cast between incompatible function types from ‘PyObject* (*)(THPVariable*)’ {aka ‘_object* (*)(THPVariable*)’} to ‘getter’ {aka ‘_object* (*)(_object*, void*)’} [-Wcast-function-type] 503 | {"_backward_hooks", (getter)THPVariable_get_backwards_hooks, (setter)THPVariable_set_backwards_hooks, nullptr, nullptr}, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` This takes the build log output for a full rebuild with GCC 9.1 from ~10,000 to ~7,000 lines. `clang-tidy` is going to complain, no way around that - see discussion at the end of gh-25483. Pull Request resolved: https://github.com/pytorch/pytorch/pull/26104 Differential Revision: D17396831 Pulled By: ezyang fbshipit-source-id: d71696bfe4dbe25519e4bcb7753151c118bd39f7	2019-09-17 07:43:37 -07:00
Wanchao Liang	8756ec989e	bind autograd functions into C++ (#24342) ... Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/24342 Right now the two APIs that provided in autograd package only have python bindings and we could not call them either in C++ API or in TorchScript. This PR make these two APIs available purely in C++ (with preserving semantics) and can be used in C++ API and TorchScript Differential Revision: D16923271 fbshipit-source-id: 049d6fbd94cd71ecc08b2716f74d52ac061f861e	2019-08-20 15:36:34 -07:00